51 lines
1.2 KiB
Ruby
Raw Normal View History

rubocop: Use `Sorbet/StrictSigil` as it's better than comments - Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
2024-08-12 10:30:59 +01:00
# typed: true # rubocop:todo Sorbet/StrictSigil
# frozen_string_literal: true
module OS
module Linux
2020-08-25 00:18:36 +02:00
# Helper functions for querying `glibc` information.
module Glibc
module_function
sig { returns(Version) }
def system_version
2021-04-02 10:58:01 -07:00
@system_version ||= begin
version = Utils.popen_read("/usr/bin/ldd", "--version")[/ (\d+\.\d+)/, 1]
if version
Version.new version
else
Version::NULL
end
end
end
sig { returns(Version) }
2021-04-01 22:16:33 -07:00
def version
@version ||= begin
2021-04-02 10:58:01 -07:00
version = Utils.popen_read(HOMEBREW_PREFIX/"opt/glibc/bin/ldd", "--version")[/ (\d+\.\d+)/, 1]
if version
Version.new version
else
system_version
end
2021-04-02 10:58:01 -07:00
end
2021-04-01 22:16:33 -07:00
end
2020-10-20 12:03:48 +02:00
sig { returns(Version) }
def minimum_version
2021-01-16 11:49:01 -08:00
Version.new(ENV.fetch("HOMEBREW_LINUX_MINIMUM_GLIBC_VERSION"))
end
sig { returns(T::Boolean) }
def below_minimum_version?
system_version < minimum_version
end
sig { returns(T::Boolean) }
def below_ci_version?
system_version < LINUX_GLIBC_CI_VERSION
end
end
end
end