brew/Library/Homebrew/cask/artifact/binary.rb

# typed: true # rubocop:todo Sorbet/StrictSigil
# frozen_string_literal: true

require "cask/artifact/symlinked"

module Cask
  module Artifact
    # Artifact corresponding to the `binary` stanza.
    class Binary < Symlinked
      def link(command: nil, **options)
        super
        return if source.executable?

        if source.writable?
          FileUtils.chmod "+x", source
        else
          command.run!("/bin/chmod", args: ["+x", source], sudo: true)
        end
      end
    end
  end
end
rubocop: Use `Sorbet/StrictSigil` as it's better than comments - Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' \| wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ``` 2024-08-12 10:30:59 +01:00			`# typed: true # rubocop:todo Sorbet/StrictSigil`
Add frozen_string_literal to all files. 2019-04-19 15:38:03 +09:00			`# frozen_string_literal: true`

cask: move cask/lib/hbc/* to cask/*. Fix the load path, requires and some filenames accordingly. 2018-09-03 19:39:07 +01:00			`require "cask/artifact/symlinked"`
init 2016-08-18 22:11:42 +03:00
Rename `Hbc` module to `Cask`. 2018-09-06 08:29:14 +02:00			`module Cask`
Cask: Use nested classes and modules. 2016-09-24 13:52:43 +02:00			`module Artifact`
Document `Artifact`. 2020-08-19 10:23:41 +02:00			# Artifact corresponding to the `binary` stanza.
Cask: Use nested classes and modules. 2016-09-24 13:52:43 +02:00			`class Binary < Symlinked`
Treat every `Artifact` instance as a single artifact. 2017-04-06 00:33:31 +02:00			`def link(command: nil, **options)`
brew style --fix 2024-05-23 17:08:41 +01:00			`super`
Replace `FileUtils.chmod` with `/bin/chmod` for cask binaries. [WIP] Update binary.rb Update binary.rb Update binary.rb 2017-04-20 14:38:16 +10:00			`return if source.executable?`
Update to RuboCop 0.59.1. 2018-09-17 02:45:00 +02:00
Replace `FileUtils.chmod` with `/bin/chmod` for cask binaries. [WIP] Update binary.rb Update binary.rb Update binary.rb 2017-04-20 14:38:16 +10:00			`if source.writable?`
			`FileUtils.chmod "+x", source`
			`else`
Treat every `Artifact` instance as a single artifact. 2017-04-06 00:33:31 +02:00			`command.run!("/bin/chmod", args: ["+x", source], sudo: true)`
Replace `FileUtils.chmod` with `/bin/chmod` for cask binaries. [WIP] Update binary.rb Update binary.rb Update binary.rb 2017-04-20 14:38:16 +10:00			`end`
Always `chmod +x` `binary` stanzas. 2017-03-08 16:35:02 +01:00			`end`
Cask: Use nested classes and modules. 2016-09-24 13:52:43 +02:00			`end`
init 2016-08-18 22:11:42 +03:00			`end`
			`end`