89 lines
2.4 KiB
Ruby
Raw Normal View History

rubocop: Use `Sorbet/StrictSigil` as it's better than comments - Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
2024-08-12 10:30:59 +01:00
# typed: true # rubocop:todo Sorbet/StrictSigil
# frozen_string_literal: true
require "plist"
2016-08-18 22:11:42 +03:00
require "utils/user"
require "cask/artifact/abstract_artifact"
2024-01-12 09:38:49 -08:00
require "extend/hash/keys"
2016-10-04 15:24:58 +02:00
2018-09-06 08:29:14 +02:00
module Cask
2016-09-24 13:52:43 +02:00
module Artifact
2020-08-19 10:23:41 +02:00
# Artifact corresponding to the `pkg` stanza.
class Pkg < AbstractArtifact
2020-12-06 07:04:47 +01:00
attr_reader :path, :stanza_options
2016-08-18 22:11:42 +03:00
def self.from_args(cask, path, **stanza_options)
stanza_options.assert_valid_keys(:allow_untrusted, :choices)
new(cask, path, **stanza_options)
2016-09-24 13:52:43 +02:00
end
2016-08-18 22:11:42 +03:00
def initialize(cask, path, **stanza_options)
2024-05-23 17:08:41 +01:00
super
@path = cask.staged_path.join(path)
@stanza_options = stanza_options
2016-08-18 22:11:42 +03:00
end
def summarize
path.relative_path_from(cask.staged_path).to_s
2016-09-24 13:52:43 +02:00
end
2016-08-18 22:11:42 +03:00
def install_phase(**options)
run_installer(**options)
2016-09-24 13:52:43 +02:00
end
2016-08-18 22:11:42 +03:00
private
def run_installer(command: nil, verbose: false, **_options)
ohai "Running installer for #{cask} with sudo; the password may be necessary."
unless path.exist?
pkg = path.relative_path_from(cask.staged_path)
pkgs = Pathname.glob(cask.staged_path/"**"/"*.pkg").map { |path| path.relative_path_from(cask.staged_path) }
message = "Could not find PKG source file '#{pkg}'"
message += ", found #{pkgs.map { |path| "'#{path}'" }.to_sentence} instead" if pkgs.any?
message += "."
raise CaskError, message
2016-09-24 13:52:43 +02:00
end
2018-09-17 02:45:00 +02:00
2016-09-24 13:52:43 +02:00
args = [
"-pkg", path,
2016-10-14 20:33:16 +02:00
"-target", "/"
]
args << "-verboseR" if verbose
args << "-allowUntrusted" if stanza_options.fetch(:allow_untrusted, false)
2016-11-21 04:13:29 +09:00
with_choices_file do |choices_path|
args << "-applyChoiceChangesXML" << choices_path if choices_path
env = {
2018-11-02 17:18:07 +00:00
"LOGNAME" => User.current,
"USER" => User.current,
"USERNAME" => User.current,
}
command.run!(
"/usr/sbin/installer",
sudo: true,
sudo_as_root: true,
2024-03-07 16:20:20 +00:00
args:,
print_stdout: true,
2024-03-07 16:20:20 +00:00
env:,
)
end
2016-09-24 13:52:43 +02:00
end
2016-11-21 04:13:29 +09:00
def with_choices_file
choices = stanza_options.fetch(:choices, {})
return yield nil if choices.empty?
2016-11-21 04:13:29 +09:00
Tempfile.open(["choices", ".xml"]) do |file|
file.write Plist::Emit.dump(choices)
file.close
yield file.path
ensure
file.unlink
end
end
2016-08-18 22:11:42 +03:00
end
end
end