105 lines
3.2 KiB
Ruby
Raw Normal View History

rubocop: Use `Sorbet/StrictSigil` as it's better than comments - Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
2024-08-12 10:30:59 +01:00
# typed: true # rubocop:todo Sorbet/StrictSigil
# frozen_string_literal: true
require "cask/artifact/abstract_artifact"
2024-01-12 09:38:49 -08:00
require "extend/hash/keys"
2016-08-18 22:11:42 +03:00
2018-09-06 08:29:14 +02:00
module Cask
2016-09-24 13:52:43 +02:00
module Artifact
2020-08-19 10:23:41 +02:00
# Superclass for all artifacts which have a source and a target location.
class Relocated < AbstractArtifact
def self.from_args(cask, *args)
source_string, target_hash = args
if target_hash
2023-11-05 09:10:28 -08:00
raise CaskInvalidError, cask unless target_hash.respond_to?(:keys)
2018-09-17 02:45:00 +02:00
target_hash.assert_valid_keys(:target)
end
target_hash ||= {}
new(cask, source_string, **target_hash)
end
2020-12-13 03:12:30 +01:00
def resolve_target(target, base_dir: config.public_send(self.class.dirmethod))
target = Pathname(target)
if target.relative?
return target.expand_path if target.descend.first.to_s == "~"
return base_dir/target if base_dir
end
target
2016-09-24 13:52:43 +02:00
end
sig {
2022-09-10 11:51:54 -07:00
params(cask: Cask, source: T.nilable(T.any(String, Pathname)), target_hash: T.any(String, Pathname))
2020-12-13 03:12:30 +01:00
.void
}
2022-08-25 02:52:40 -04:00
def initialize(cask, source, **target_hash)
2024-05-23 17:08:41 +01:00
super
2022-08-25 02:52:40 -04:00
target = target_hash[:target]
@source_string = source.to_s
@target_string = target.to_s
end
def source
@source ||= begin
base_path = cask.staged_path
base_path = base_path.join(cask.url.only_path) if cask.url&.only_path.present?
base_path.join(@source_string)
end
end
def target
@target ||= resolve_target(@target_string.presence || source.basename)
2016-09-24 13:52:43 +02:00
end
2017-08-04 14:59:18 +02:00
def to_a
[@source_string].tap do |ary|
ary << { target: @target_string } unless @target_string.empty?
end
end
2023-02-22 09:11:29 -08:00
sig { override.returns(String) }
def summarize
target_string = @target_string.empty? ? "" : " -> #{@target_string}"
"#{@source_string}#{target_string}"
end
private
ALT_NAME_ATTRIBUTE = "com.apple.metadata:kMDItemAlternateNames"
2016-09-24 13:52:43 +02:00
2019-04-01 16:02:13 -04:00
# Try to make the asset searchable under the target name. Spotlight
2016-09-24 13:52:43 +02:00
# respects this attribute for many filetypes, but ignores it for App
# bundles. Alfred 2.2 respects it even for App bundles.
def add_altname_metadata(file, altname, command: nil)
return if altname.to_s.casecmp(file.basename.to_s).zero?
2018-09-17 02:45:00 +02:00
2016-09-24 13:52:43 +02:00
odebug "Adding #{ALT_NAME_ATTRIBUTE} metadata"
altnames = command.run("/usr/bin/xattr",
2019-04-30 08:44:35 +01:00
args: ["-p", ALT_NAME_ATTRIBUTE, file],
print_stderr: false).stdout.sub(/\A\((.*)\)\Z/, '\1')
2021-01-26 15:21:24 -05:00
odebug "Existing metadata is: #{altnames}"
2016-09-24 13:52:43 +02:00
altnames.concat(", ") unless altnames.empty?
altnames.concat(%Q("#{altname}"))
2016-09-24 13:52:43 +02:00
altnames = "(#{altnames})"
2017-09-10 16:39:03 +00:00
# Some packages are shipped as u=rx (e.g. Bitcoin Core)
command.run!("/bin/chmod", args: ["--", "u+rw", file, file.realpath])
2016-09-24 13:52:43 +02:00
command.run!("/usr/bin/xattr",
2019-04-30 08:44:35 +01:00
args: ["-w", ALT_NAME_ATTRIBUTE, altnames, file],
print_stderr: false)
2016-09-24 13:52:43 +02:00
end
def printable_target
2022-05-30 04:48:54 +01:00
target.to_s.sub(/^#{Dir.home}(#{File::SEPARATOR}|$)/, "~/")
2016-09-24 13:52:43 +02:00
end
2016-08-18 22:11:42 +03:00
end
end
end