brew/Library/Homebrew/lock_file.rb

90 lines
2.0 KiB
Ruby
Raw Normal View History

rubocop: Use `Sorbet/StrictSigil` as it's better than comments - Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
2024-08-12 10:30:59 +01:00
# typed: true # rubocop:todo Sorbet/StrictSigil
# frozen_string_literal: true
require "fcntl"
# A lock file to prevent multiple Homebrew processes from modifying the same path.
2017-05-22 03:23:50 +02:00
class LockFile
2018-08-09 16:46:39 +02:00
attr_reader :path
sig { params(type: Symbol, locked_path: Pathname).void }
def initialize(type, locked_path)
@locked_path = locked_path
lock_name = locked_path.basename.to_s
@path = HOMEBREW_LOCKS/"#{lock_name}.#{type}.lock"
2013-04-05 22:06:52 -05:00
@lockfile = nil
2013-02-09 18:19:50 -06:00
end
2024-11-23 23:45:17 +01:00
sig { void }
2013-02-09 18:19:50 -06:00
def lock
2024-11-23 23:45:17 +01:00
ignore_interrupts do
create_lockfile
2018-09-17 02:45:00 +02:00
2024-11-23 23:45:17 +01:00
next if @lockfile.flock(File::LOCK_EX | File::LOCK_NB)
raise OperationInProgressError, @locked_path
end
2013-02-09 18:19:50 -06:00
end
2024-11-23 23:45:17 +01:00
sig { params(unlink: T::Boolean).void }
def unlock(unlink: false)
ignore_interrupts do
next if @lockfile.nil? || @lockfile.closed?
@lockfile.flock(File::LOCK_UN)
@lockfile.close
2018-09-17 02:45:00 +02:00
2024-11-23 23:45:17 +01:00
if unlink
@path.unlink if @path.exist?
@lockfile = nil
end
end
2013-02-09 18:19:50 -06:00
end
def with_lock
lock
yield
ensure
unlock
end
private
2016-09-24 17:59:14 +02:00
def create_lockfile
return if @lockfile.present? && !@lockfile.closed?
2018-09-17 02:45:00 +02:00
2024-11-23 23:45:17 +01:00
@path.dirname.mkpath
begin
@lockfile = @path.open(File::RDWR | File::CREAT)
rescue Errno::EMFILE
odie "The maximum number of open files on this system has been reached. Use `ulimit -n` to increase this limit."
end
2016-09-24 17:59:14 +02:00
@lockfile.fcntl(Fcntl::F_SETFD, Fcntl::FD_CLOEXEC)
2013-02-09 18:19:50 -06:00
end
end
2017-05-22 03:23:50 +02:00
2020-08-09 03:16:22 +02:00
# A lock file for a formula.
2017-05-22 03:23:50 +02:00
class FormulaLock < LockFile
sig { params(rack_name: String).void }
def initialize(rack_name)
super(:formula, HOMEBREW_CELLAR/rack_name)
2017-05-22 03:23:50 +02:00
end
end
2020-08-09 03:16:22 +02:00
# A lock file for a cask.
2017-05-22 03:23:50 +02:00
class CaskLock < LockFile
sig { params(cask_token: String).void }
def initialize(cask_token)
super(:cask, HOMEBREW_PREFIX/"Caskroom/#{cask_token}")
end
end
# A lock file for a download.
class DownloadLock < LockFile
sig { params(download_path: Pathname).void }
def initialize(download_path)
super(:download, download_path)
2017-05-22 03:23:50 +02:00
end
end