55 lines
2.0 KiB
Ruby
Raw Normal View History

require "rubocops/extend/formula"
module RuboCop
module Cop
module FormulaAudit
# This cop audits `options` in Formulae.
class Options < FormulaCop
DEPRECATION_MSG = "macOS has been 64-bit only since 10.6 so 32-bit options are deprecated.".freeze
2018-10-27 21:47:58 +10:00
UNI_DEPRECATION_MSG = "macOS has been 64-bit only since 10.6 so universal options are deprecated.".freeze
def audit_formula(_node, _class_node, _parent_class_node, body_node)
option_call_nodes = find_every_method_call_by_name(body_node, :option)
option_call_nodes.each do |option_call|
option = parameters(option_call).first
problem DEPRECATION_MSG if regex_match_group(option, /32-bit/)
end
option_call_nodes.each do |option_call|
offending_node(option_call)
option = string_content(parameters(option_call).first)
2018-10-27 21:47:58 +10:00
problem UNI_DEPRECATION_MSG if option == "universal"
if option !~ /with(out)?-/ &&
option != "cxx11" &&
option != "universal"
problem "Options should begin with with/without."\
" Migrate '--#{option}' with `deprecated_option`."
end
next unless option =~ /^with(out)?-(?:checks?|tests)$/
next if depends_on?("check", :optional, :recommended)
2018-09-17 02:45:00 +02:00
problem "Use '--with#{Regexp.last_match(1)}-test' instead of '--#{option}'."\
" Migrate '--#{option}' with `deprecated_option`."
end
end
end
end
module NewFormulaAudit
class Options < FormulaCop
2018-06-02 16:56:50 +10:00
DEP_OPTION = "New formulae should not use `deprecated_option`".freeze
OPTION = "Formulae should not have an `option`".freeze
def audit_formula(_node, _class_node, _parent_class_node, body_node)
problem DEP_OPTION if method_called_ever?(body_node, :deprecated_option)
return unless formula_tap == "homebrew-core"
2018-09-17 02:45:00 +02:00
problem OPTION if method_called_ever?(body_node, :option)
end
end
end
end
end