brew/Library/Homebrew/rubocops/uses_from_macos.rb

126 lines
3.3 KiB
Ruby
Raw Normal View History

rubocop: Use `Sorbet/StrictSigil` as it's better than comments - Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
2024-08-12 10:30:59 +01:00
# typed: true # rubocop:todo Sorbet/StrictSigil
# frozen_string_literal: true
2023-02-20 10:22:39 -08:00
require "rubocops/extend/formula_cop"
module RuboCop
module Cop
module FormulaAudit
2020-11-27 13:13:09 -05:00
# This cop audits formulae that are keg-only because they are provided by macos.
2023-02-20 18:10:59 -08:00
class ProvidedByMacos < FormulaCop
PROVIDED_BY_MACOS_FORMULAE = %w[
apr
bc
berkeley-db
bison
bzip2
cups
curl
cyrus-sasl
dyld-headers
ed
expat
file-formula
flex
gnu-getopt
gperf
icu4c
krb5
libarchive
libedit
libffi
libiconv
libpcap
libressl
2022-04-18 17:54:20 +01:00
libxcrypt
libxml2
libxslt
llvm
lsof
m4
ncompress
ncurses
net-snmp
2021-01-07 22:27:15 +01:00
netcat
openldap
2022-06-29 09:55:54 -07:00
pax
2021-03-08 23:40:29 -08:00
pcsc-lite
pod2man
rpcgen
ruby
sqlite
ssh-copy-id
swift
tcl-tk
unifdef
unzip
whois
zip
zlib
].freeze
sig { override.params(formula_nodes: FormulaNodes).void }
def audit_formula(formula_nodes)
return if (body_node = formula_nodes.body_node).nil?
2020-11-27 13:13:09 -05:00
find_method_with_args(body_node, :keg_only, :provided_by_macos) do
return if PROVIDED_BY_MACOS_FORMULAE.include? @formula_name
2022-06-28 10:09:59 +01:00
problem "Formulae that are `keg_only :provided_by_macos` should be " \
"added to the `PROVIDED_BY_MACOS_FORMULAE` list (in the Homebrew/brew repo)"
2020-11-27 13:13:09 -05:00
end
end
end
# This cop audits `uses_from_macos` dependencies in formulae.
2023-02-20 18:10:59 -08:00
class UsesFromMacos < FormulaCop
# These formulae aren't `keg_only :provided_by_macos` but are provided by
# macOS (or very similarly, e.g. OpenSSL where system provides LibreSSL).
# TODO: consider making some of these keg-only.
ALLOWED_USES_FROM_MACOS_DEPS = %w[
bash
cpio
expect
2021-06-08 13:03:25 +01:00
git
groff
gzip
2022-07-11 22:13:11 -07:00
less
mandoc
openssl
perl
php
python
rsync
vim
xz
zsh
].freeze
sig { override.params(formula_nodes: FormulaNodes).void }
def audit_formula(formula_nodes)
return if (body_node = formula_nodes.body_node).nil?
depends_on_linux = depends_on?(:linux)
find_method_with_args(body_node, :uses_from_macos, /^"(.+)"/).each do |method|
@offensive_node = method
problem "`uses_from_macos` should not be used when Linux is required." if depends_on_linux
2020-10-09 11:12:06 +02:00
dep = if parameters(method).first.instance_of?(RuboCop::AST::StrNode)
parameters(method).first
2020-10-09 11:12:06 +02:00
elsif parameters(method).first.instance_of?(RuboCop::AST::HashNode)
parameters(method).first.keys.first
end
dep_name = string_content(dep)
next if ALLOWED_USES_FROM_MACOS_DEPS.include? dep_name
next if ProvidedByMacos::PROVIDED_BY_MACOS_FORMULAE.include? dep_name
problem "`uses_from_macos` should only be used for macOS dependencies, not #{dep_name}."
end
end
end
end
end
end