2021-07-28 13:20:12 -04:00
|
|
|
# typed: true
|
2020-08-08 07:16:06 +05:30
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
module Homebrew
|
|
|
|
module Livecheck
|
|
|
|
module Strategy
|
2020-11-05 17:17:03 -05:00
|
|
|
# The {Sourceforge} strategy identifies versions of software at
|
2020-08-08 07:16:06 +05:30
|
|
|
# sourceforge.net by checking a project's RSS feed.
|
|
|
|
#
|
|
|
|
# SourceForge URLs take a few different formats:
|
2020-11-05 17:17:03 -05:00
|
|
|
#
|
|
|
|
# * `https://downloads.sourceforge.net/project/example/example-1.2.3.tar.gz`
|
|
|
|
# * `https://svn.code.sf.net/p/example/code/trunk`
|
|
|
|
# * `:pserver:anonymous:@example.cvs.sourceforge.net:/cvsroot/example`
|
2020-08-08 07:16:06 +05:30
|
|
|
#
|
|
|
|
# The RSS feed for a project contains the most recent release archives
|
2020-11-05 17:17:03 -05:00
|
|
|
# and while this is fine for most projects, this approach has some
|
2020-08-08 07:16:06 +05:30
|
|
|
# shortcomings. Some project releases involve so many files that the one
|
|
|
|
# we're interested in isn't present in the feed content. Some projects
|
|
|
|
# contain additional software and the archive we're interested in is
|
|
|
|
# pushed out of the feed (especially if it hasn't been updated recently).
|
|
|
|
#
|
|
|
|
# Usually we address this situation by adding a `livecheck` block to
|
2021-01-11 17:12:48 -05:00
|
|
|
# the formula/cask that checks the page for the relevant directory in the
|
2020-08-08 07:16:06 +05:30
|
|
|
# project instead. In this situation, it's necessary to use
|
2020-11-05 17:17:03 -05:00
|
|
|
# `strategy :page_match` to prevent the {Sourceforge} stratgy from
|
2020-08-08 07:16:06 +05:30
|
|
|
# being used.
|
|
|
|
#
|
|
|
|
# The default regex matches within `url` attributes in the RSS feed
|
|
|
|
# and identifies versions within directory names or filenames.
|
|
|
|
#
|
|
|
|
# @api public
|
|
|
|
class Sourceforge
|
2021-04-04 03:00:34 +02:00
|
|
|
extend T::Sig
|
|
|
|
|
2020-08-08 07:16:06 +05:30
|
|
|
NICE_NAME = "SourceForge"
|
|
|
|
|
|
|
|
# The `Regexp` used to determine if the strategy applies to the URL.
|
2020-12-21 00:48:31 -05:00
|
|
|
URL_MATCH_REGEX = %r{
|
|
|
|
^https?://(?:[^/]+?\.)*(?:sourceforge|sf)\.net
|
|
|
|
(?:/projects?/(?<project_name>[^/]+)/
|
|
|
|
|/p/(?<project_name>[^/]+)/
|
|
|
|
|(?::/cvsroot)?/(?<project_name>[^/]+))
|
|
|
|
}ix.freeze
|
2020-08-08 07:16:06 +05:30
|
|
|
|
|
|
|
# Whether the strategy can be applied to the provided URL.
|
2020-11-05 17:17:03 -05:00
|
|
|
#
|
2020-08-08 07:16:06 +05:30
|
|
|
# @param url [String] the URL to match against
|
|
|
|
# @return [Boolean]
|
2021-08-10 18:24:51 -04:00
|
|
|
sig { params(url: String).returns(T::Boolean) }
|
2020-08-08 07:16:06 +05:30
|
|
|
def self.match?(url)
|
|
|
|
URL_MATCH_REGEX.match?(url)
|
|
|
|
end
|
|
|
|
|
2021-07-28 13:20:12 -04:00
|
|
|
# Extracts information from a provided URL and uses it to generate
|
|
|
|
# various input values used by the strategy to check for new versions.
|
|
|
|
# Some of these values act as defaults and can be overridden in a
|
|
|
|
# `livecheck` block.
|
|
|
|
#
|
|
|
|
# @param url [String] the URL used to generate values
|
|
|
|
# @return [Hash]
|
|
|
|
sig { params(url: String).returns(T::Hash[Symbol, T.untyped]) }
|
|
|
|
def self.generate_input_values(url)
|
|
|
|
values = {}
|
|
|
|
|
|
|
|
match = url.match(URL_MATCH_REGEX)
|
|
|
|
return values if match.blank?
|
|
|
|
|
|
|
|
# Don't generate a URL if the URL already points to the RSS feed
|
|
|
|
unless url.match?(%r{/rss(?:/?$|\?)})
|
|
|
|
values[:url] = "https://sourceforge.net/projects/#{match[:project_name]}/rss"
|
|
|
|
end
|
|
|
|
|
|
|
|
regex_name = Regexp.escape(T.must(match[:project_name])).gsub("\\-", "-")
|
|
|
|
|
|
|
|
# It may be possible to improve the generated regex but there's quite
|
|
|
|
# a bit of variation between projects and it can be challenging to
|
|
|
|
# create something that works for most URLs.
|
|
|
|
values[:regex] = %r{url=.*?/#{regex_name}/files/.*?[-_/](\d+(?:[-.]\d+)+)[-_/%.]}i
|
|
|
|
|
|
|
|
values
|
|
|
|
end
|
|
|
|
|
2020-08-08 07:16:06 +05:30
|
|
|
# Generates a URL and regex (if one isn't provided) and passes them
|
2020-11-05 17:17:03 -05:00
|
|
|
# to {PageMatch.find_versions} to identify versions in the content.
|
|
|
|
#
|
2020-08-08 07:16:06 +05:30
|
|
|
# @param url [String] the URL of the content to check
|
|
|
|
# @param regex [Regexp] a regex used for matching versions in content
|
|
|
|
# @return [Hash]
|
2021-04-04 03:00:34 +02:00
|
|
|
sig {
|
|
|
|
params(
|
2021-08-12 11:54:29 -04:00
|
|
|
url: String,
|
|
|
|
regex: T.nilable(Regexp),
|
|
|
|
unused: T.nilable(T::Hash[Symbol, T.untyped]),
|
Handle variable strategy block arguments
There are times where a regex isn't needed in a `strategy` block and
these changes explicitly handle that situation.
This allows the Symbol Proc format used in some `Sparkle` `livecheck`
blocks (e.g., `strategy :sparkle, &:version`) to continue working
instead of failing with a "wrong number of arguments (given 1,
expected 0)" error. This error would occur because a Symbol Proc only
only expects one argument (e.g., an `Item`, not an `Item` and a
regex/nil).
There's an argument to be made for avoiding the Symbol Proc format
for `strategy` blocks but I haven't found a way of selectively
disabling the Style/SymbolProc cop only for a `strategy` DSL method
call. That is to say, if we don't use the Symbol Proc format, `brew
style` will give a "Pass &:version as an argument to strategy instead
of a block." offense.
Besides that, this also replaces the `block` type signatures in
livecheck strategies with `T.untyped`. Sorbet doesn't know how to
handle a `Proc` with a variable number of arguments and can't be
taught how (i.e., `T.any` with a `Proc` signature for each variation
doesn't work). The aforementioned changes cause Sorbet to complain
about there being both too many and too few arguments, so the only
way to win is not to play the game. Hopefully we can restore the
`block` type signatures in the future (if upstream resolves this
years-old issue) but `T.untyped` seems to be our only option for now.
2021-11-19 22:42:15 -05:00
|
|
|
block: T.untyped,
|
2021-04-04 03:00:34 +02:00
|
|
|
).returns(T::Hash[Symbol, T.untyped])
|
|
|
|
}
|
2021-08-12 11:54:29 -04:00
|
|
|
def self.find_versions(url:, regex: nil, **unused, &block)
|
2021-07-28 13:20:12 -04:00
|
|
|
generated = generate_input_values(url)
|
2020-08-08 07:16:06 +05:30
|
|
|
|
2021-07-28 13:20:12 -04:00
|
|
|
T.unsafe(PageMatch).find_versions(
|
|
|
|
url: generated[:url] || url,
|
|
|
|
regex: regex || generated[:regex],
|
|
|
|
**unused,
|
|
|
|
&block
|
|
|
|
)
|
2020-08-08 07:16:06 +05:30
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|