brew/Library/Homebrew/test/rubocops/components_order_spec.rb

113 lines
3.0 KiB
Ruby
Raw Normal View History

require "rubocops/components_order"
2018-04-24 18:27:37 +10:00
describe RuboCop::Cop::FormulaAudit::ComponentsOrder do
subject(:cop) { described_class.new }
context "When auditing formula components order" do
it "When url precedes homepage" do
2017-10-21 03:12:50 +02:00
expect_offense(<<~RUBY)
class Foo < Formula
2018-08-06 20:41:21 +02:00
url "https://example.com/foo-1.0.tgz"
homepage "https://example.com"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `homepage` (line 3) should be put before `url` (line 2)
end
2017-10-21 03:12:50 +02:00
RUBY
end
it "When `resource` precedes `depends_on`" do
2017-10-21 03:12:50 +02:00
expect_offense(<<~RUBY)
class Foo < Formula
url "https://example.com/foo-1.0.tgz"
resource "foo2" do
url "https://example.com/foo-2.0.tgz"
end
depends_on "openssl"
2017-10-21 03:12:50 +02:00
^^^^^^^^^^^^^^^^^^^^ `depends_on` (line 8) should be put before `resource` (line 4)
end
2017-10-21 03:12:50 +02:00
RUBY
end
it "When `test` precedes `plist`" do
2017-10-21 03:12:50 +02:00
expect_offense(<<~RUBY)
class Foo < Formula
url "https://example.com/foo-1.0.tgz"
test do
expect(shell_output("./dogs")).to match("Dogs are terrific")
end
def plist
2017-10-21 03:12:50 +02:00
^^^^^^^^^ `plist` (line 8) should be put before `test` (line 4)
end
end
2017-10-21 03:12:50 +02:00
RUBY
end
it "When only one of many `depends_on` precedes `conflicts_with`" do
2017-10-21 03:12:50 +02:00
expect_offense(<<~RUBY)
class Foo < Formula
depends_on "autoconf" => :build
conflicts_with "visionmedia-watch"
depends_on "automake" => :build
2017-10-21 03:12:50 +02:00
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `depends_on` (line 4) should be put before `conflicts_with` (line 3)
depends_on "libtool" => :build
depends_on "pkg-config" => :build
depends_on "gettext"
end
2017-10-21 03:12:50 +02:00
RUBY
end
end
context "When auditing formula components order with autocorrect" do
it "When url precedes homepage" do
2018-07-11 15:17:40 +02:00
source = <<~RUBY
class Foo < Formula
2018-08-06 20:41:21 +02:00
url "https://example.com/foo-1.0.tgz"
homepage "https://example.com"
end
2018-07-11 15:17:40 +02:00
RUBY
2017-10-21 03:12:50 +02:00
2018-07-11 15:17:40 +02:00
correct_source = <<~RUBY
class Foo < Formula
2018-08-06 20:41:21 +02:00
homepage "https://example.com"
url "https://example.com/foo-1.0.tgz"
end
2018-07-11 15:17:40 +02:00
RUBY
2017-10-07 22:31:23 +02:00
corrected_source = autocorrect_source(source)
expect(corrected_source).to eq(correct_source)
end
it "When `resource` precedes `depends_on`" do
2018-07-11 15:17:40 +02:00
source = <<~RUBY
class Foo < Formula
url "https://example.com/foo-1.0.tgz"
resource "foo2" do
url "https://example.com/foo-2.0.tgz"
end
depends_on "openssl"
end
2018-07-11 15:17:40 +02:00
RUBY
2017-10-21 03:12:50 +02:00
2018-07-11 15:17:40 +02:00
correct_source = <<~RUBY
class Foo < Formula
url "https://example.com/foo-1.0.tgz"
depends_on "openssl"
resource "foo2" do
url "https://example.com/foo-2.0.tgz"
end
end
2018-07-11 15:17:40 +02:00
RUBY
2017-10-21 03:12:50 +02:00
2017-10-07 22:31:23 +02:00
corrected_source = autocorrect_source(source)
expect(corrected_source).to eq(correct_source)
end
end
end