32 lines
721 B
Ruby
Raw Normal View History

rubocop: Use `Sorbet/StrictSigil` as it's better than comments - Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
2024-08-12 10:30:59 +01:00
# typed: true # rubocop:todo Sorbet/StrictSigil
2019-10-22 15:19:40 +03:00
# frozen_string_literal: true
2019-10-23 16:28:00 +03:00
require "cask/artifact/symlinked"
2019-10-22 15:19:40 +03:00
module Cask
module Artifact
2020-08-19 10:23:41 +02:00
# Artifact corresponding to the `manpage` stanza.
2019-10-23 16:28:00 +03:00
class Manpage < Symlinked
2019-10-23 18:34:16 +03:00
attr_reader :section
2019-10-23 16:28:00 +03:00
def self.from_args(cask, source)
section = source.to_s[/\.([1-8]|n|l)(?:\.gz)?$/, 1]
2019-10-22 15:19:40 +03:00
2019-10-23 18:34:16 +03:00
raise CaskInvalidError, "'#{source}' is not a valid man page name" unless section
2019-10-22 15:19:40 +03:00
2019-10-23 18:34:16 +03:00
new(cask, source, section)
2019-10-23 16:28:00 +03:00
end
2019-10-22 15:19:40 +03:00
2019-10-23 18:34:16 +03:00
def initialize(cask, source, section)
@section = section
super(cask, source)
2019-10-22 15:19:40 +03:00
end
2019-10-24 09:43:59 +03:00
def resolve_target(target)
config.manpagedir.join("man#{section}", target)
2019-10-22 15:19:40 +03:00
end
end
end
end