944 lines
29 KiB
Ruby
Raw Normal View History

2023-02-24 16:20:51 -08:00
# typed: true
# frozen_string_literal: true
require "cask/denylist"
require "cask/download"
2016-08-18 22:11:42 +03:00
require "digest"
2020-12-14 14:30:36 +01:00
require "livecheck/livecheck"
require "source_location"
2023-09-18 12:38:10 -04:00
require "system_command"
require "utils/curl"
require "utils/git"
2020-08-26 09:42:39 +02:00
require "utils/shared_audits"
2016-08-18 22:11:42 +03:00
2018-09-06 08:29:14 +02:00
module Cask
2020-08-24 21:32:40 +02:00
# Audit a cask for various problems.
#
# @api private
2016-09-24 13:52:43 +02:00
class Audit
include ::Utils::Curl
extend Predicable
2016-08-18 22:11:42 +03:00
attr_reader :cask, :download
2016-08-18 22:11:42 +03:00
2023-03-29 20:49:29 +02:00
attr_predicate :new_cask?, :strict?, :signing?, :online?, :token_conflicts?
def initialize(
cask,
2023-03-29 20:49:29 +02:00
download: nil, quarantine: nil,
token_conflicts: nil, online: nil, strict: nil, signing: nil,
new_cask: nil, only: [], except: []
)
# `new_cask` implies `online`, `token_conflicts`, `strict` and `signing`
online = new_cask if online.nil?
strict = new_cask if strict.nil?
2022-08-01 14:30:04 +02:00
signing = new_cask if signing.nil?
token_conflicts = new_cask if token_conflicts.nil?
2023-03-29 20:49:29 +02:00
# `online` and `signing` imply `download`
download = online || signing if download.nil?
2016-09-24 13:52:43 +02:00
@cask = cask
@download = Download.new(cask, quarantine: quarantine) if download
2020-04-23 21:16:17 +02:00
@online = online
@strict = strict
2022-08-01 14:30:04 +02:00
@signing = signing
2020-04-23 21:16:17 +02:00
@new_cask = new_cask
@token_conflicts = token_conflicts
@only = only || []
@except = except || []
2016-09-24 13:52:43 +02:00
end
2016-08-18 22:11:42 +03:00
2016-09-24 13:52:43 +02:00
def run!
only_audits = @only
except_audits = @except
private_methods.map(&:to_s).grep(/^audit_/).each do |audit_method_name|
name = audit_method_name.delete_prefix("audit_")
next if !only_audits.empty? && only_audits&.exclude?(name)
next if except_audits&.include?(name)
send(audit_method_name)
end
2016-09-24 13:52:43 +02:00
self
rescue => e
odebug e, ::Utils::Backtrace.clean(e)
2016-09-24 13:52:43 +02:00
add_error "exception while auditing #{cask}: #{e.message}"
self
end
2016-08-18 22:11:42 +03:00
def errors
@errors ||= []
end
sig { returns(T::Boolean) }
def errors?
errors.any?
end
sig { returns(T::Boolean) }
def success?
!errors?
end
sig {
params(
message: T.nilable(String),
location: T.nilable(Homebrew::SourceLocation),
strict_only: T::Boolean,
).void
}
def add_error(message, location: nil, strict_only: false)
# Only raise non-critical audits if the user specified `--strict`.
return if strict_only && !@strict
2016-08-18 22:11:42 +03:00
2023-05-19 16:59:14 +02:00
errors << ({ message: message, location: location, corrected: false })
end
def result
Formatter.error("failed") if errors?
end
sig { returns(T.nilable(String)) }
def summary
return if success?
2021-03-21 13:59:43 -04:00
summary = ["audit for #{cask}: #{result}"]
errors.each do |error|
2021-04-03 03:49:41 +02:00
summary << " #{Formatter.error("-")} #{error[:message]}"
end
summary.join("\n")
end
2016-09-24 13:52:43 +02:00
private
2016-08-18 22:11:42 +03:00
sig { void }
def audit_untrusted_pkg
2018-03-25 15:30:16 +10:00
odebug "Auditing pkg stanza: allow_untrusted"
return if @cask.sourcefile_path.nil?
tap = @cask.tap
return if tap.nil?
2018-05-25 18:03:16 +02:00
return if tap.user != "Homebrew"
2018-03-25 15:30:16 +10:00
return if cask.artifacts.none? { |k| k.is_a?(Artifact::Pkg) && k.stanza_options.key?(:allow_untrusted) }
2018-09-17 02:45:00 +02:00
add_error "allow_untrusted is not permitted in official Homebrew Cask taps"
2018-03-25 15:30:16 +10:00
end
sig { void }
def audit_stanza_requires_uninstall
odebug "Auditing stanzas which require an uninstall"
2018-09-06 06:47:29 +02:00
return if cask.artifacts.none? { |k| k.is_a?(Artifact::Pkg) || k.is_a?(Artifact::Installer) }
2021-03-01 13:43:47 +00:00
return if cask.artifacts.any?(Artifact::Uninstall)
2018-09-17 02:45:00 +02:00
add_error "installer and pkg stanzas require an uninstall stanza"
end
sig { void }
def audit_single_pre_postflight
odebug "Auditing preflight and postflight stanzas"
2018-09-06 06:47:29 +02:00
if cask.artifacts.count { |k| k.is_a?(Artifact::PreflightBlock) && k.directives.key?(:preflight) } > 1
add_error "only a single preflight stanza is allowed"
2017-11-01 22:35:41 -03:00
end
count = cask.artifacts.count do |k|
2018-09-06 06:47:29 +02:00
k.is_a?(Artifact::PostflightBlock) &&
k.directives.key?(:postflight)
end
2023-04-18 15:06:50 -07:00
return if count <= 1
add_error "only a single postflight stanza is allowed"
end
sig { void }
def audit_single_uninstall_zap
odebug "Auditing single uninstall_* and zap stanzas"
count = cask.artifacts.count do |k|
2018-09-06 06:47:29 +02:00
k.is_a?(Artifact::PreflightBlock) &&
k.directives.key?(:uninstall_preflight)
end
add_error "only a single uninstall_preflight stanza is allowed" if count > 1
count = cask.artifacts.count do |k|
2018-09-06 06:47:29 +02:00
k.is_a?(Artifact::PostflightBlock) &&
k.directives.key?(:uninstall_postflight)
end
add_error "only a single uninstall_postflight stanza is allowed" if count > 1
2023-04-18 15:06:50 -07:00
return if cask.artifacts.count { |k| k.is_a?(Artifact::Zap) } <= 1
2018-09-17 02:45:00 +02:00
add_error "only a single zap stanza is allowed"
end
sig { void }
def audit_required_stanzas
2016-09-24 13:52:43 +02:00
odebug "Auditing required stanzas"
2016-10-14 20:17:25 +02:00
[:version, :sha256, :url, :homepage].each do |sym|
2016-09-24 13:52:43 +02:00
add_error "a #{sym} stanza is required" unless cask.send(sym)
end
add_error "at least one name stanza is required" if cask.name.empty?
# TODO: specific DSL knowledge should not be spread around in various files like this
2020-09-11 10:29:21 +01:00
rejected_artifacts = [:uninstall, :zap]
installable_artifacts = cask.artifacts.reject { |k| rejected_artifacts.include?(k) }
2016-09-24 13:52:43 +02:00
add_error "at least one activatable artifact stanza is required" if installable_artifacts.empty?
2016-08-18 22:11:42 +03:00
end
sig { void }
def audit_description
# Fonts seldom benefit from descriptions and requiring them disproportionately
# increases the maintenance burden.
return if cask.tap == "homebrew/cask-fonts"
2018-09-17 02:45:00 +02:00
add_error("Cask should have a description. Please add a `desc` stanza.", strict_only: true) if cask.desc.blank?
2016-09-24 13:52:43 +02:00
end
2016-08-18 22:11:42 +03:00
sig { void }
def audit_version_special_characters
return unless cask.version
return if cask.version.latest?
raw_version = cask.version.raw_version
return if raw_version.exclude?(":") && raw_version.exclude?("/")
add_error "version should not contain colons or slashes"
end
sig { void }
def audit_no_string_version_latest
return unless cask.version
odebug "Auditing version :latest does not appear as a string ('latest')"
2023-04-18 15:06:50 -07:00
return if cask.version.raw_version != "latest"
2018-09-17 02:45:00 +02:00
2016-09-24 13:52:43 +02:00
add_error "you should use version :latest instead of version 'latest'"
end
2016-08-18 22:11:42 +03:00
sig { void }
def audit_sha256_no_check_if_latest
2016-09-24 13:52:43 +02:00
return unless cask.sha256
return unless cask.version
2018-09-17 02:45:00 +02:00
odebug "Auditing sha256 :no_check with version :latest"
return unless cask.version.latest?
return if cask.sha256 == :no_check
2018-09-17 02:45:00 +02:00
2016-09-24 13:52:43 +02:00
add_error "you should use sha256 :no_check when version is :latest"
end
2016-08-18 22:11:42 +03:00
sig { void }
def audit_sha256_no_check_if_unversioned
return unless cask.sha256
return if cask.sha256 == :no_check
return unless cask.url&.unversioned?
add_error "Use `sha256 :no_check` when URL is unversioned."
end
sig { void }
def audit_sha256_actually_256
return unless cask.sha256
odebug "Auditing sha256 string is a legal SHA-256 digest"
2020-11-19 18:12:16 +01:00
return unless cask.sha256.is_a?(Checksum)
return if cask.sha256.length == 64 && cask.sha256[/^[0-9a-f]+$/i]
2018-09-17 02:45:00 +02:00
2020-11-19 18:12:16 +01:00
add_error "sha256 string must be of 64 hexadecimal characters"
2016-09-24 13:52:43 +02:00
end
2016-08-18 22:11:42 +03:00
sig { void }
def audit_sha256_invalid
return unless cask.sha256
odebug "Auditing sha256 is not a known invalid value"
2016-09-24 13:52:43 +02:00
empty_sha256 = "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"
2023-04-18 15:06:50 -07:00
return if cask.sha256 != empty_sha256
2018-09-17 02:45:00 +02:00
2020-11-19 18:12:16 +01:00
add_error "cannot use the sha256 for an empty string: #{empty_sha256}"
2016-09-24 13:52:43 +02:00
end
2016-08-18 22:11:42 +03:00
sig { void }
2023-03-29 20:49:29 +02:00
def audit_latest_with_livecheck
return unless cask.version&.latest?
return unless cask.livecheckable?
return if cask.livecheck.skip?
add_error "Casks with a `livecheck` should not use `version :latest`."
end
sig { void }
def audit_latest_with_auto_updates
return unless cask.version&.latest?
return unless cask.auto_updates
add_error "Casks with `version :latest` should not use `auto_updates`."
end
LIVECHECK_REFERENCE_URL = "https://docs.brew.sh/Cask-Cookbook#stanza-livecheck"
2023-02-24 16:20:51 -08:00
sig { params(livecheck_result: T.any(NilClass, T::Boolean, Symbol)).void }
def audit_hosting_with_livecheck(livecheck_result: audit_livecheck_version)
2023-03-29 20:49:29 +02:00
return if cask.discontinued?
return if cask.version&.latest?
return unless cask.url
2023-03-29 20:49:29 +02:00
return if block_url_offline?
return if cask.livecheckable?
return if livecheck_result == :auto_detected
add_livecheck = "please add a livecheck. See #{Formatter.url(LIVECHECK_REFERENCE_URL)}"
case cask.url.to_s
when %r{sourceforge.net/(\S+)}
return unless online?
2018-09-17 02:45:00 +02:00
add_error "Download is hosted on SourceForge, #{add_livecheck}", location: cask.url.location
when %r{dl.devmate.com/(\S+)}
add_error "Download is hosted on DevMate, #{add_livecheck}", location: cask.url.location
when %r{rink.hockeyapp.net/(\S+)}
add_error "Download is hosted on HockeyApp, #{add_livecheck}", location: cask.url.location
end
end
SOURCEFORGE_OSDN_REFERENCE_URL = "https://docs.brew.sh/Cask-Cookbook#sourceforgeosdn-urls"
sig { void }
def audit_download_url_format
return unless cask.url
return if block_url_offline?
2016-09-24 13:52:43 +02:00
odebug "Auditing URL format"
if bad_sourceforge_url?
add_error "SourceForge URL format incorrect. See #{Formatter.url(SOURCEFORGE_OSDN_REFERENCE_URL)}",
location: cask.url.location
2016-09-24 13:52:43 +02:00
elsif bad_osdn_url?
add_error "OSDN URL format incorrect. See #{Formatter.url(SOURCEFORGE_OSDN_REFERENCE_URL)}",
location: cask.url.location
2016-09-24 13:52:43 +02:00
end
2016-08-18 22:11:42 +03:00
end
2021-11-07 01:23:31 +00:00
VERIFIED_URL_REFERENCE_URL = "https://docs.brew.sh/Cask-Cookbook#when-url-and-homepage-domains-differ-add-verified"
sig { void }
def audit_unnecessary_verified
return unless cask.url
2021-03-31 06:15:06 +02:00
return if block_url_offline?
2020-09-08 22:12:26 +08:00
return unless verified_present?
return unless url_match_homepage?
return unless verified_matches_url?
add_error "The URL's domain #{Formatter.url(domain)} matches the homepage domain " \
"#{Formatter.url(homepage)}, the 'verified' parameter of the 'url' stanza is unnecessary. " \
"See #{Formatter.url(VERIFIED_URL_REFERENCE_URL)}"
2020-09-08 22:12:26 +08:00
end
sig { void }
def audit_missing_verified
return unless cask.url
2021-03-31 06:15:06 +02:00
return if block_url_offline?
2020-12-12 05:55:39 +01:00
return if file_url?
2020-09-08 22:12:26 +08:00
return if url_match_homepage?
return if verified_present?
add_error "The URL's domain #{Formatter.url(domain)} does not match the homepage domain " \
"#{Formatter.url(homepage)}, a 'verified' parameter has to be added to the 'url' stanza. " \
"See #{Formatter.url(VERIFIED_URL_REFERENCE_URL)}"
2020-09-08 22:12:26 +08:00
end
sig { void }
def audit_no_match
return unless cask.url
2021-03-31 06:15:06 +02:00
return if block_url_offline?
2020-09-08 22:12:26 +08:00
return unless verified_present?
return if verified_matches_url?
2020-09-08 22:12:26 +08:00
add_error "Verified URL #{Formatter.url(url_from_verified)} does not match URL " \
"#{Formatter.url(strip_url_scheme(cask.url.to_s))}. " \
"See #{Formatter.url(VERIFIED_URL_REFERENCE_URL)}",
location: cask.url.location
2020-09-08 22:12:26 +08:00
end
sig { void }
def audit_generic_artifacts
2018-09-06 06:47:29 +02:00
cask.artifacts.select { |a| a.is_a?(Artifact::Artifact) }.each do |artifact|
unless artifact.target.absolute?
add_error "target must be absolute path for #{artifact.class.english_name} #{artifact.source}"
2016-09-24 13:52:43 +02:00
end
2016-08-18 22:11:42 +03:00
end
end
sig { void }
def audit_languages
2020-06-04 23:37:54 +02:00
@cask.languages.each do |language|
2020-08-12 00:04:20 +02:00
Locale.parse(language)
rescue Locale::ParserError
add_error "Locale '#{language}' is invalid."
2020-06-04 23:37:54 +02:00
end
end
sig { void }
def audit_token_conflicts
2020-09-04 05:29:56 +02:00
return unless token_conflicts?
2018-09-17 02:45:00 +02:00
Homebrew.with_no_api_env do
return unless core_formula_names.include?(cask.token)
add_error(
"possible duplicate, cask token conflicts with Homebrew core formula: #{Formatter.url(core_formula_url)}",
strict_only: true,
)
end
2016-09-24 13:52:43 +02:00
end
2016-08-18 22:11:42 +03:00
sig { void }
def audit_token_valid
add_error "cask token contains non-ascii characters" unless cask.token.ascii_only?
add_error "cask token + should be replaced by -plus-" if cask.token.include? "+"
add_error "cask token whitespace should be replaced by hyphens" if cask.token.include? " "
add_error "cask token @ should be replaced by -at-" if cask.token.include? "@"
add_error "cask token underscores should be replaced by hyphens" if cask.token.include? "_"
add_error "cask token should not contain double hyphens" if cask.token.include? "--"
2020-06-04 23:11:51 +02:00
2022-12-13 10:54:22 +00:00
if cask.token.match?(/[^a-z0-9-]/)
add_error "cask token should only contain lowercase alphanumeric characters and hyphens"
2020-06-04 23:11:51 +02:00
end
return if !cask.token.start_with?("-") && !cask.token.end_with?("-")
2020-06-04 23:11:51 +02:00
add_error "cask token should not have leading or trailing hyphens"
2020-06-04 23:11:51 +02:00
end
sig { void }
def audit_token_bad_words
return unless new_cask?
2020-06-04 23:11:51 +02:00
token = cask.token
add_error "cask token contains .app" if token.end_with? ".app"
2020-06-04 23:11:51 +02:00
2023-02-24 16:20:51 -08:00
match_data = /-(?<designation>alpha|beta|rc|release-candidate)$/.match(cask.token)
if match_data && cask.tap&.official? && cask.tap != "homebrew/cask-versions"
add_error "cask token contains version designation '#{match_data[:designation]}'"
2020-06-04 23:11:51 +02:00
end
add_error("cask token mentions launcher", strict_only: true) if token.end_with? "launcher"
2020-06-04 23:11:51 +02:00
add_error("cask token mentions desktop", strict_only: true) if token.end_with? "desktop"
2020-06-04 23:11:51 +02:00
add_error("cask token mentions platform", strict_only: true) if token.end_with? "mac", "osx", "macos"
2020-06-04 23:11:51 +02:00
add_error("cask token mentions architecture", strict_only: true) if token.end_with? "x86", "32_bit", "x86_64",
"64_bit"
2020-06-04 23:11:51 +02:00
frameworks = %w[cocoa qt gtk wx java]
return if frameworks.include?(token) || !token.end_with?(*frameworks)
2020-06-04 23:11:51 +02:00
add_error("cask token mentions framework", strict_only: true)
2020-06-04 23:11:51 +02:00
end
sig { void }
def audit_download
return if download.blank? || cask.url.blank?
2018-09-17 02:45:00 +02:00
begin
download.fetch
rescue => e
add_error "download not possible: #{e}", location: cask.url.location
end
2016-09-24 13:52:43 +02:00
end
sig { void }
2023-03-29 20:49:29 +02:00
def audit_livecheck_unneeded_long_version
return if cask.version.nil? || cask.url.nil?
2023-04-18 15:06:50 -07:00
return if cask.livecheck.strategy != :sparkle
return unless cask.version.csv.second
return if cask.url.to_s.include? cask.version.csv.second
2023-02-22 19:43:02 +01:00
return if cask.version.csv.third.present? && cask.url.to_s.include?(cask.version.csv.third)
add_error "Download does not require additional version components. Use `&:short_version` in the livecheck",
location: cask.url.location,
strict_only: true
end
sig { void }
def audit_signing
2022-08-01 14:30:04 +02:00
return if !signing? || download.blank? || cask.url.blank?
odebug "Auditing signing"
2023-11-05 17:18:21 -05:00
extract_artifacts do |artifacts, tmpdir|
artifacts.each do |artifact|
artifact_path = artifact.is_a?(Artifact::Pkg) ? artifact.path : artifact.source
path = tmpdir/artifact_path.relative_path_from(cask.staged_path)
next unless path.exist?
result = system_command("spctl", args: ["--assess", "--type", "install", path], print_stderr: false)
next if result.success?
add_error <<~EOS, location: cask.url.location, strict_only: true
Signature verification failed:
#{result.merged_output}
macOS on ARM requires software to be signed.
Please contact the upstream developer to let them know they should sign and notarize their software.
EOS
2022-08-01 14:30:04 +02:00
end
end
end
2023-11-05 17:18:21 -05:00
sig { void }
def extract_artifacts
return unless online?
artifacts = cask.artifacts.select do |artifact|
artifact.is_a?(Artifact::Pkg) || artifact.is_a?(Artifact::App) || artifact.is_a?(Artifact::Binary)
end
if @artifacts_extracted && @tmpdir
yield artifacts, @tmpdir if block_given?
return
end
return if artifacts.empty?
@tmpdir ||= Pathname(Dir.mktmpdir)
ohai "Downloading and extracting artifacts"
downloaded_path = download.fetch
primary_container = UnpackStrategy.detect(downloaded_path, type: @cask.container&.type, merge_xattrs: true)
return if primary_container.nil?
# Extract the container to the temporary directory.
primary_container.extract_nestedly(to: @tmpdir, basename: downloaded_path.basename, verbose: false)
@artifacts_extracted = true # Set the flag to indicate that extraction has occurred.
# Yield the artifacts and temp directory to the block if provided.
yield artifacts, @tmpdir if block_given?
end
2023-02-24 16:20:51 -08:00
sig { returns(T.any(NilClass, T::Boolean, Symbol)) }
def audit_livecheck_version
2023-03-29 20:49:29 +02:00
return unless online?
return unless cask.version
referenced_cask, = Homebrew::Livecheck.resolve_livecheck_reference(cask)
# Respect skip conditions for a referenced cask
if referenced_cask
skip_info = Homebrew::Livecheck::SkipConditions.referenced_skip_information(
referenced_cask,
Homebrew::Livecheck.cask_name(cask),
)
end
# Respect cask skip conditions (e.g. discontinued, latest, unversioned)
skip_info ||= Homebrew::Livecheck::SkipConditions.skip_information(cask)
return :skip if skip_info.present?
2020-12-14 14:30:36 +01:00
latest_version = Homebrew::Livecheck.latest_version(
cask,
referenced_formula_or_cask: referenced_cask,
)&.fetch(:latest)
2023-03-29 20:49:29 +02:00
return :auto_detected if cask.version.to_s == latest_version.to_s
2020-12-14 14:30:36 +01:00
add_error "Version '#{cask.version}' differs from '#{latest_version}' retrieved by livecheck."
false
2020-12-14 14:30:36 +01:00
end
2023-09-18 12:38:10 -04:00
sig { void }
def audit_min_os
return unless online?
2023-10-26 15:45:06 -04:00
return unless strict?
2023-09-18 12:38:10 -04:00
odebug "Auditing minimum OS version"
plist_min_os = cask_plist_min_os
2023-11-05 17:18:21 -05:00
sparkle_min_os = livecheck_min_os
debug_messages = []
debug_messages << "Plist #{plist_min_os}" if plist_min_os
debug_messages << "Sparkle #{sparkle_min_os}" if sparkle_min_os
odebug "Minimum OS version: #{debug_messages.join(" | ")}" unless debug_messages.empty?
min_os = [sparkle_min_os, plist_min_os].compact.max
2023-09-18 12:38:10 -04:00
2023-11-05 17:18:21 -05:00
return if min_os.nil? || min_os <= HOMEBREW_MACOS_OLDEST_ALLOWED
2023-09-18 12:38:10 -04:00
cask_min_os = cask.depends_on.macos&.version
2023-11-05 17:18:21 -05:00
return if cask_min_os == min_os
2023-09-18 12:38:10 -04:00
min_os_symbol = if cask_min_os.present?
cask_min_os.to_sym.inspect
else
"no minimum OS version"
end
2023-11-05 17:18:21 -05:00
add_error "Upstream defined #{min_os.to_sym.inspect} as the minimum OS version " \
2023-09-18 12:38:10 -04:00
"and the cask defined #{min_os_symbol}",
strict_only: true
end
2023-11-05 17:18:21 -05:00
sig { returns(T.nilable(MacOSVersion)) }
2023-09-18 12:38:10 -04:00
def livecheck_min_os
return unless online?
return unless cask.livecheckable?
2023-04-18 15:06:50 -07:00
return if cask.livecheck.strategy != :sparkle
out, _, status = curl_output("--fail", "--silent", "--location", cask.livecheck.url)
return unless status.success?
require "rexml/document"
xml = begin
REXML::Document.new(out)
rescue REXML::ParseException
nil
end
return if xml.blank?
item = xml.elements["//rss//channel//item"]
return if item.blank?
min_os = item.elements["sparkle:minimumSystemVersion"]&.text
min_os = "11" if min_os == "10.16"
return if min_os.blank?
begin
2023-09-18 12:38:10 -04:00
MacOSVersion.new(min_os).strip_patch
rescue MacOSVersion::Error
2023-09-18 12:38:10 -04:00
nil
end
2023-09-18 12:38:10 -04:00
end
2023-11-05 17:18:21 -05:00
sig { returns(T.nilable(MacOSVersion)) }
2023-09-18 12:38:10 -04:00
def cask_plist_min_os
return unless online?
2023-09-18 12:38:10 -04:00
plist_min_os = T.let(nil, T.untyped)
2023-11-05 17:18:21 -05:00
@staged_path ||= cask.staged_path
2023-09-18 12:38:10 -04:00
2023-11-05 17:18:21 -05:00
extract_artifacts do |artifacts, tmpdir|
2023-09-18 12:38:10 -04:00
artifacts.each do |artifact|
artifact_path = artifact.is_a?(Artifact::Pkg) ? artifact.path : artifact.source
path = tmpdir/artifact_path.relative_path_from(cask.staged_path)
plist_path = "#{path}/Contents/Info.plist"
next unless File.exist?(plist_path)
plist = system_command!("plutil", args: ["-convert", "xml1", "-o", "-", plist_path]).plist
plist_min_os = plist["LSMinimumSystemVersion"].presence
break if plist_min_os
end
end
2023-10-26 15:45:06 -04:00
2023-09-18 12:38:10 -04:00
begin
MacOSVersion.new(plist_min_os).strip_patch
rescue MacOSVersion::Error
nil
end
end
sig { void }
def audit_github_prerelease_version
return if cask.tap == "homebrew/cask-versions"
2020-08-13 16:17:47 +02:00
odebug "Auditing GitHub prerelease"
2021-03-31 06:15:06 +02:00
user, repo = get_repo_data(%r{https?://github\.com/([^/]+)/([^/]+)/?.*}) if online?
2020-08-13 16:17:47 +02:00
return if user.nil?
2020-09-09 08:57:56 -07:00
tag = SharedAudits.github_tag_from_url(cask.url)
tag ||= cask.version
error = SharedAudits.github_release(user, repo, tag, cask: cask)
add_error error, location: cask.url.location if error
2020-08-13 16:17:47 +02:00
end
sig { void }
def audit_gitlab_prerelease_version
return if cask.tap == "homebrew/cask-versions"
2021-03-31 06:15:06 +02:00
user, repo = get_repo_data(%r{https?://gitlab\.com/([^/]+)/([^/]+)/?.*}) if online?
2020-08-13 16:17:47 +02:00
return if user.nil?
odebug "Auditing GitLab prerelease"
2020-09-09 08:57:56 -07:00
tag = SharedAudits.gitlab_tag_from_url(cask.url)
tag ||= cask.version
2020-12-21 12:53:12 -05:00
error = SharedAudits.gitlab_release(user, repo, tag, cask: cask)
add_error error, location: cask.url.location if error
2020-08-13 16:17:47 +02:00
end
sig { void }
def audit_github_repository_archived
2023-04-14 18:55:29 +02:00
# Discontinued casks may have an archived repo.
return if cask.discontinued?
2021-03-31 06:15:06 +02:00
user, repo = get_repo_data(%r{https?://github\.com/([^/]+)/([^/]+)/?.*}) if online?
2020-08-13 16:17:47 +02:00
return if user.nil?
metadata = SharedAudits.github_repo_data(user, repo)
return if metadata.nil?
add_error "GitHub repo is archived", location: cask.url.location if metadata["archived"]
2020-08-13 16:17:47 +02:00
end
sig { void }
def audit_gitlab_repository_archived
2023-04-14 18:55:29 +02:00
# Discontinued casks may have an archived repo.
return if cask.discontinued?
2021-03-31 06:15:06 +02:00
user, repo = get_repo_data(%r{https?://gitlab\.com/([^/]+)/([^/]+)/?.*}) if online?
2020-08-13 16:17:47 +02:00
return if user.nil?
odebug "Auditing GitLab repo archived"
metadata = SharedAudits.gitlab_repo_data(user, repo)
return if metadata.nil?
add_error "GitLab repo is archived", location: cask.url.location if metadata["archived"]
2020-08-13 16:17:47 +02:00
end
sig { void }
def audit_github_repository
2020-09-21 04:40:32 -05:00
return unless new_cask?
2020-08-13 16:17:47 +02:00
2020-04-23 21:16:17 +02:00
user, repo = get_repo_data(%r{https?://github\.com/([^/]+)/([^/]+)/?.*})
return if user.nil?
odebug "Auditing GitHub repo"
error = SharedAudits.github(user, repo)
add_error error, location: cask.url.location if error
2020-04-23 21:16:17 +02:00
end
sig { void }
def audit_gitlab_repository
return unless new_cask?
2020-08-13 16:17:47 +02:00
2020-04-23 21:16:17 +02:00
user, repo = get_repo_data(%r{https?://gitlab\.com/([^/]+)/([^/]+)/?.*})
return if user.nil?
odebug "Auditing GitLab repo"
error = SharedAudits.gitlab(user, repo)
add_error error, location: cask.url.location if error
2020-04-23 21:16:17 +02:00
end
sig { void }
def audit_bitbucket_repository
2020-09-21 04:40:32 -05:00
return unless new_cask?
2020-08-13 16:17:47 +02:00
2020-04-23 21:16:17 +02:00
user, repo = get_repo_data(%r{https?://bitbucket\.org/([^/]+)/([^/]+)/?.*})
return if user.nil?
odebug "Auditing Bitbucket repo"
error = SharedAudits.bitbucket(user, repo)
add_error error, location: cask.url.location if error
2020-04-23 21:16:17 +02:00
end
sig { void }
def audit_denylist
return unless cask.tap
return unless cask.tap.official?
return unless (reason = Denylist.reason(cask.token))
add_error "#{cask.token} is not allowed: #{reason}"
end
sig { void }
def audit_reverse_migration
return unless new_cask?
return unless cask.tap
return unless cask.tap.official?
return unless cask.tap.tap_migrations.key?(cask.token)
add_error "#{cask.token} is listed in tap_migrations.json"
end
sig { void }
def audit_https_availability
return unless download
if cask.url && !cask.url.using
validate_url_for_https_availability(cask.url, "binary URL", cask.token, cask.tap,
location: cask.url.location,
user_agents: [cask.url.user_agent], referer: cask.url&.referer)
end
2023-03-29 20:49:29 +02:00
if cask.livecheckable? && !cask.livecheck.url.is_a?(Symbol)
validate_url_for_https_availability(cask.livecheck.url, "livecheck URL", cask.token, cask.tap,
check_content: true)
2021-10-04 21:45:20 -04:00
end
return unless cask.homepage
validate_url_for_https_availability(cask.homepage, SharedAudits::URL_TYPE_HOMEPAGE, cask.token, cask.tap,
user_agents: [:browser, :default],
check_content: true,
strict: strict?)
end
sig { void }
def audit_cask_path
return if cask.tap != "homebrew/cask"
expected_path = cask.tap.new_cask_path(cask.token)
2023-08-09 15:27:36 -04:00
return if cask.sourcefile_path.to_s.end_with?(expected_path)
add_error "Cask should be located in '#{expected_path}'"
end
# sig {
# params(url_to_check: T.any(String, URL), url_type: String, cask_token: String, tap: Tap,
# options: T.untyped).void
# }
def validate_url_for_https_availability(url_to_check, url_type, cask_token, tap, location: nil, **options)
problem = curl_check_http_content(url_to_check.to_s, url_type, **options)
exception = tap&.audit_exception(:secure_connection_audit_skiplist, cask_token, url_to_check.to_s)
if problem
add_error problem, location: location unless exception
elsif exception
add_error "#{url_to_check} is in the secure connection audit skiplist but does not need to be skipped",
location: location
end
end
sig { params(regex: T.any(String, Regexp)).returns(T.nilable(T::Array[String])) }
def get_repo_data(regex)
return unless online?
_, user, repo = *regex.match(cask.url.to_s)
_, user, repo = *regex.match(cask.homepage) unless user
return if !user || !repo
repo.gsub!(/.git$/, "")
[user, repo]
end
sig {
params(regex: T.any(String, Regexp), valid_formats_array: T::Array[T.any(String, Regexp)]).returns(T::Boolean)
}
def bad_url_format?(regex, valid_formats_array)
return false unless cask.url.to_s.match?(regex)
valid_formats_array.none? { |format| cask.url.to_s =~ format }
end
sig { returns(T::Boolean) }
def bad_sourceforge_url?
bad_url_format?(/sourceforge/,
[
%r{\Ahttps://sourceforge\.net/projects/[^/]+/files/latest/download\Z},
%r{\Ahttps://downloads\.sourceforge\.net/(?!(project|sourceforge)/)},
])
end
sig { returns(T::Boolean) }
def bad_osdn_url?
bad_url_format?(/osd/, [%r{\Ahttps?://([^/]+.)?dl\.osdn\.jp/}])
end
# sig { returns(String) }
def homepage
URI(cask.homepage.to_s).host
end
# sig { returns(String) }
def domain
URI(cask.url.to_s).host
end
sig { returns(T::Boolean) }
def url_match_homepage?
host = cask.url.to_s
host_uri = URI(host)
host = if host.match?(/:\d/) && host_uri.port != 80
"#{host_uri.host}:#{host_uri.port}"
else
host_uri.host
end
return false if homepage.blank?
home = homepage.downcase
2023-02-24 16:20:51 -08:00
if (split_host = T.must(host).split(".")).length >= 3
host = T.must(split_host[-2..]).join(".")
end
if (split_home = homepage.split(".")).length >= 3
home = split_home[-2..].join(".")
end
host == home
end
# sig { params(url: String).returns(String) }
def strip_url_scheme(url)
url.sub(%r{^[^:/]+://(www\.)?}, "")
end
# sig { returns(String) }
def url_from_verified
strip_url_scheme(cask.url.verified)
end
sig { returns(T::Boolean) }
def verified_matches_url?
url_domain, url_path = strip_url_scheme(cask.url.to_s).split("/", 2)
verified_domain, verified_path = url_from_verified.split("/", 2)
(url_domain == verified_domain || (verified_domain && url_domain&.end_with?(".#{verified_domain}"))) &&
(!verified_path || url_path&.start_with?(verified_path))
end
sig { returns(T::Boolean) }
def verified_present?
cask.url.verified.present?
end
sig { returns(T::Boolean) }
def file_url?
URI(cask.url.to_s).scheme == "file"
end
sig { returns(T::Boolean) }
def block_url_offline?
return false if online?
cask.url.from_block?
end
sig { returns(Tap) }
def core_tap
@core_tap ||= CoreTap.instance
end
# sig { returns(T::Array[String]) }
def core_formula_names
core_tap.formula_names
end
sig { returns(String) }
def core_formula_url
formula_path = Formulary.core_path(cask.token)
.to_s
.delete_prefix(core_tap.path.to_s)
"#{core_tap.default_remote}/blob/HEAD/Formula/#{formula_path}"
end
2016-08-18 22:11:42 +03:00
end
end