206 lines
7.5 KiB
Ruby
Raw Normal View History

rubocop: Use `Sorbet/StrictSigil` as it's better than comments - Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
2024-08-12 10:30:59 +01:00
# typed: true # rubocop:todo Sorbet/StrictSigil
# frozen_string_literal: true
require "cask/artifact/relocated"
require "cask/quarantine"
2016-08-18 22:11:42 +03:00
2018-09-06 08:29:14 +02:00
module Cask
2016-09-24 13:52:43 +02:00
module Artifact
# Superclass for all artifacts that are installed by moving them to the target location.
2016-09-24 13:52:43 +02:00
class Moved < Relocated
2020-10-20 12:03:48 +02:00
sig { returns(String) }
2016-09-24 13:52:43 +02:00
def self.english_description
"#{english_name}s"
2016-09-24 13:52:43 +02:00
end
2016-08-18 22:11:42 +03:00
def install_phase(**options)
move(**options)
2016-09-24 13:52:43 +02:00
end
2016-08-18 22:11:42 +03:00
def uninstall_phase(**options)
move_back(**options)
end
def summarize_installed
if target.exist?
"#{printable_target} (#{target.abv})"
else
Formatter.error(printable_target, label: "Missing #{self.class.english_name}")
end
2016-09-24 13:52:43 +02:00
end
2016-08-18 22:11:42 +03:00
2016-09-24 13:52:43 +02:00
private
2016-08-18 22:11:42 +03:00
def move(adopt: false, auto_updates: false, force: false, verbose: false, predecessor: nil, reinstall: false,
command: nil, **options)
unless source.exist?
raise CaskError, "It seems the #{self.class.english_name} source '#{source}' is not there."
end
2016-09-24 13:52:43 +02:00
if Utils.path_occupied?(target)
if target.directory? && target.children.empty? && matching_artifact?(predecessor)
# An upgrade removed the directory contents but left the directory itself (see below).
unless source.directory?
if target.parent.writable? && !force
target.rmdir
else
2024-03-07 16:20:20 +00:00
Utils.gain_permissions_remove(target, command:)
end
end
else
if adopt
ohai "Adopting existing #{self.class.english_name} at '#{target}'"
unless auto_updates
source_plist = Pathname("#{source}/Contents/Info.plist")
target_plist = Pathname("#{target}/Contents/Info.plist")
same = if source_plist.size? &&
(source_bundle_version = Homebrew::BundleVersion.from_info_plist(source_plist)) &&
target_plist.size? &&
(target_bundle_version = Homebrew::BundleVersion.from_info_plist(target_plist))
if source_bundle_version.short_version == target_bundle_version.short_version
if source_bundle_version.version == target_bundle_version.version
true
else
onoe "The bundle version of #{source} is #{source_bundle_version.version} but " \
"is #{target_bundle_version.version} for #{target}!"
false
end
else
onoe "The bundle short version of #{source} is #{source_bundle_version.short_version} but " \
"is #{target_bundle_version.short_version} for #{target}!"
false
end
else
command.run(
"/usr/bin/diff",
args: ["--recursive", "--brief", source, target],
verbose:,
print_stdout: verbose,
).success?
end
unless same
raise CaskError,
"It seems the existing #{self.class.english_name} is different from " \
"the one being installed."
end
end
# Remove the source as we don't need to move it to the target location
FileUtils.rm_r(source)
return post_move(command)
end
message = "It seems there is already #{self.class.english_article} " \
"#{self.class.english_name} at '#{target}'"
raise CaskError, "#{message}." if !force && !adopt
opoo "#{message}; overwriting."
2024-03-07 16:20:20 +00:00
delete(target, force:, command:, **options)
end
2016-09-24 13:52:43 +02:00
end
2017-03-10 09:33:48 +01:00
2021-01-26 15:21:24 -05:00
ohai "Moving #{self.class.english_name} '#{source.basename}' to '#{target}'"
2024-03-07 16:20:20 +00:00
Utils.gain_permissions_mkpath(target.dirname, command:) unless target.dirname.exist?
2024-03-07 16:20:20 +00:00
if target.directory? && Quarantine.app_management_permissions_granted?(app: target, command:)
if target.writable?
2023-05-11 12:47:37 -05:00
source.children.each { |child| FileUtils.move(child, target/child.basename) }
else
command.run!("/bin/cp", args: ["-pR", *source.children, target],
sudo: true)
end
2024-03-07 16:20:20 +00:00
Quarantine.copy_xattrs(source, target, command:)
FileUtils.rm_r(source)
elsif target.dirname.writable?
FileUtils.move(source, target)
else
# default sudo user isn't necessarily able to write to Homebrew's locations
# e.g. with runas_default set in the sudoers (5) file.
command.run!("/bin/cp", args: ["-pR", source, target], sudo: true)
FileUtils.rm_r(source)
end
post_move(command)
end
# Performs any actions necessary after the source has been moved to the target location.
def post_move(command)
FileUtils.ln_sf target, source
2024-03-07 16:20:20 +00:00
add_altname_metadata(target, source.basename, command:)
2016-09-24 13:52:43 +02:00
end
2016-08-18 22:11:42 +03:00
def matching_artifact?(cask)
return false unless cask
cask.artifacts.any? do |a|
a.instance_of?(self.class) && instance_of?(a.class) && a.target == target
end
end
def move_back(skip: false, force: false, adopt: false, command: nil, **options)
FileUtils.rm source if source.symlink? && source.dirname.join(source.readlink) == target
if Utils.path_occupied?(source)
message = "It seems there is already #{self.class.english_article} " \
"#{self.class.english_name} at '#{source}'"
raise CaskError, "#{message}." if !force && !adopt
2018-09-17 02:45:00 +02:00
opoo "#{message}; overwriting."
2024-03-07 16:20:20 +00:00
delete(source, force:, command:, **options)
end
unless target.exist?
return if skip || force
2018-09-17 02:45:00 +02:00
raise CaskError, "It seems the #{self.class.english_name} source '#{target}' is not there."
end
2021-01-26 15:21:24 -05:00
ohai "Backing #{self.class.english_name} '#{target.basename}' up to '#{source}'"
source.dirname.mkpath
# We need to preserve extended attributes between copies.
# This may fail and need sudo if the source has files with restricted permissions.
[!source.parent.writable?, true].uniq.each do |sudo|
result = command.run(
"/bin/cp",
args: ["-pR", target, source],
must_succeed: sudo,
sudo:,
)
break if result.success?
end
2018-01-21 19:10:30 +10:00
2024-03-07 16:20:20 +00:00
delete(target, force:, command:, **options)
end
def delete(target, force: false, successor: nil, command: nil, **_)
2021-01-26 15:21:24 -05:00
ohai "Removing #{self.class.english_name} '#{target}'"
raise CaskError, "Cannot remove undeletable #{self.class.english_name}." if undeletable?(target)
2016-09-20 15:11:33 +02:00
return unless Utils.path_occupied?(target)
if target.directory? && matching_artifact?(successor) && Quarantine.app_management_permissions_granted?(
2024-03-07 16:20:20 +00:00
app: target, command:,
)
# If an app folder is deleted, macOS considers the app uninstalled and removes some data.
# Remove only the contents to handle this case.
target.children.each do |child|
Utils.gain_permissions_remove(child, command:)
end
else
2024-03-07 16:20:20 +00:00
Utils.gain_permissions_remove(target, command:)
2016-09-24 13:52:43 +02:00
end
end
def undeletable?(target); end
2016-09-24 13:52:43 +02:00
end
2016-08-18 22:11:42 +03:00
end
end
require "extend/os/cask/artifact/moved"