2017-10-29 17:31:07 -03:00
|
|
|
require_relative "shared_examples/invalid_option"
|
|
|
|
|
2018-09-06 08:29:14 +02:00
|
|
|
describe Cask::Cmd::Upgrade, :cask do
|
2017-10-29 17:31:07 -03:00
|
|
|
it_behaves_like "a command that handles invalid options"
|
|
|
|
|
2017-11-27 01:29:08 +00:00
|
|
|
context "successful upgrade" do
|
2017-11-24 00:48:14 +00:00
|
|
|
let(:installed) {
|
|
|
|
[
|
|
|
|
"outdated/local-caffeine",
|
|
|
|
"outdated/local-transmission",
|
|
|
|
"outdated/auto-updates",
|
2017-11-28 00:29:45 +00:00
|
|
|
"outdated/version-latest",
|
2017-11-24 00:48:14 +00:00
|
|
|
]
|
|
|
|
}
|
2017-11-12 09:25:15 -03:00
|
|
|
|
2018-03-25 13:30:37 +01:00
|
|
|
before do
|
2018-09-06 08:29:14 +02:00
|
|
|
installed.each { |cask| Cask::Cmd::Install.run(cask) }
|
2017-11-12 09:25:15 -03:00
|
|
|
|
|
|
|
allow_any_instance_of(described_class).to receive(:verbose?).and_return(true)
|
|
|
|
end
|
2017-10-29 17:31:07 -03:00
|
|
|
|
2017-11-27 01:29:08 +00:00
|
|
|
describe 'without --greedy it ignores the Casks with "version latest" or "auto_updates true"' do
|
|
|
|
it "updates all the installed Casks when no token is provided" do
|
2018-09-06 08:29:14 +02:00
|
|
|
local_caffeine = Cask::CaskLoader.load("local-caffeine")
|
|
|
|
local_caffeine_path = Cask::Config.global.appdir.join("Caffeine.app")
|
|
|
|
local_transmission = Cask::CaskLoader.load("local-transmission")
|
|
|
|
local_transmission_path = Cask::Config.global.appdir.join("Transmission.app")
|
2017-11-27 01:29:08 +00:00
|
|
|
|
|
|
|
expect(local_caffeine).to be_installed
|
|
|
|
expect(local_caffeine_path).to be_a_directory
|
|
|
|
expect(local_caffeine.versions).to include("1.2.2")
|
|
|
|
|
|
|
|
expect(local_transmission).to be_installed
|
|
|
|
expect(local_transmission_path).to be_a_directory
|
|
|
|
expect(local_transmission.versions).to include("2.60")
|
|
|
|
|
|
|
|
described_class.run
|
|
|
|
|
|
|
|
expect(local_caffeine).to be_installed
|
|
|
|
expect(local_caffeine_path).to be_a_directory
|
|
|
|
expect(local_caffeine.versions).to include("1.2.3")
|
|
|
|
|
|
|
|
expect(local_transmission).to be_installed
|
|
|
|
expect(local_transmission_path).to be_a_directory
|
|
|
|
expect(local_transmission.versions).to include("2.61")
|
|
|
|
end
|
|
|
|
|
|
|
|
it "updates only the Casks specified in the command line" do
|
2018-09-06 08:29:14 +02:00
|
|
|
local_caffeine = Cask::CaskLoader.load("local-caffeine")
|
|
|
|
local_caffeine_path = Cask::Config.global.appdir.join("Caffeine.app")
|
|
|
|
local_transmission = Cask::CaskLoader.load("local-transmission")
|
|
|
|
local_transmission_path = Cask::Config.global.appdir.join("Transmission.app")
|
2017-11-27 01:29:08 +00:00
|
|
|
|
|
|
|
expect(local_caffeine).to be_installed
|
|
|
|
expect(local_caffeine_path).to be_a_directory
|
|
|
|
expect(local_caffeine.versions).to include("1.2.2")
|
|
|
|
|
|
|
|
expect(local_transmission).to be_installed
|
|
|
|
expect(local_transmission_path).to be_a_directory
|
|
|
|
expect(local_transmission.versions).to include("2.60")
|
|
|
|
|
|
|
|
described_class.run("local-caffeine")
|
|
|
|
|
|
|
|
expect(local_caffeine).to be_installed
|
|
|
|
expect(local_caffeine_path).to be_a_directory
|
|
|
|
expect(local_caffeine.versions).to include("1.2.3")
|
|
|
|
|
|
|
|
expect(local_transmission).to be_installed
|
|
|
|
expect(local_transmission_path).to be_a_directory
|
|
|
|
expect(local_transmission.versions).to include("2.60")
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'updates "auto_updates" and "latest" Casks when their tokens are provided in the command line' do
|
2018-09-06 08:29:14 +02:00
|
|
|
local_caffeine = Cask::CaskLoader.load("local-caffeine")
|
|
|
|
local_caffeine_path = Cask::Config.global.appdir.join("Caffeine.app")
|
|
|
|
auto_updates = Cask::CaskLoader.load("auto-updates")
|
|
|
|
auto_updates_path = Cask::Config.global.appdir.join("MyFancyApp.app")
|
2017-11-27 01:29:08 +00:00
|
|
|
|
|
|
|
expect(local_caffeine).to be_installed
|
|
|
|
expect(local_caffeine_path).to be_a_directory
|
|
|
|
expect(local_caffeine.versions).to include("1.2.2")
|
|
|
|
|
|
|
|
expect(auto_updates).to be_installed
|
|
|
|
expect(auto_updates_path).to be_a_directory
|
|
|
|
expect(auto_updates.versions).to include("2.57")
|
|
|
|
|
|
|
|
described_class.run("local-caffeine", "auto-updates")
|
|
|
|
|
|
|
|
expect(local_caffeine).to be_installed
|
|
|
|
expect(local_caffeine_path).to be_a_directory
|
|
|
|
expect(local_caffeine.versions).to include("1.2.3")
|
|
|
|
|
|
|
|
expect(auto_updates).to be_installed
|
|
|
|
expect(auto_updates_path).to be_a_directory
|
|
|
|
expect(auto_updates.versions).to include("2.61")
|
|
|
|
end
|
2017-11-12 09:25:15 -03:00
|
|
|
end
|
|
|
|
|
2017-11-27 01:29:08 +00:00
|
|
|
describe "with --greedy it checks additional Casks" do
|
2017-11-27 10:15:13 +00:00
|
|
|
it 'includes the Casks with "auto_updates true" or "version latest"' do
|
2018-09-06 08:29:14 +02:00
|
|
|
local_caffeine = Cask::CaskLoader.load("local-caffeine")
|
|
|
|
local_caffeine_path = Cask::Config.global.appdir.join("Caffeine.app")
|
|
|
|
auto_updates = Cask::CaskLoader.load("auto-updates")
|
|
|
|
auto_updates_path = Cask::Config.global.appdir.join("MyFancyApp.app")
|
|
|
|
local_transmission = Cask::CaskLoader.load("local-transmission")
|
|
|
|
local_transmission_path = Cask::Config.global.appdir.join("Transmission.app")
|
|
|
|
version_latest = Cask::CaskLoader.load("version-latest")
|
|
|
|
version_latest_path_1 = Cask::Config.global.appdir.join("Caffeine Mini.app")
|
|
|
|
version_latest_path_2 = Cask::Config.global.appdir.join("Caffeine Pro.app")
|
2017-11-07 22:27:04 -03:00
|
|
|
|
2017-11-27 01:29:08 +00:00
|
|
|
expect(local_caffeine).to be_installed
|
|
|
|
expect(local_caffeine_path).to be_a_directory
|
|
|
|
expect(local_caffeine.versions).to include("1.2.2")
|
2017-11-24 01:21:30 +00:00
|
|
|
|
2017-11-27 01:29:08 +00:00
|
|
|
expect(auto_updates).to be_installed
|
|
|
|
expect(auto_updates_path).to be_a_directory
|
|
|
|
expect(auto_updates.versions).to include("2.57")
|
2017-11-07 22:27:04 -03:00
|
|
|
|
2017-11-27 01:29:08 +00:00
|
|
|
expect(local_transmission).to be_installed
|
|
|
|
expect(local_transmission_path).to be_a_directory
|
|
|
|
expect(local_transmission.versions).to include("2.60")
|
2017-10-29 17:31:07 -03:00
|
|
|
|
2017-11-28 00:29:45 +00:00
|
|
|
expect(version_latest).to be_installed
|
|
|
|
expect(version_latest_path_1).to be_a_directory
|
|
|
|
expect(version_latest_path_2).to be_a_directory
|
|
|
|
expect(version_latest.versions).to include("latest")
|
|
|
|
|
2017-11-27 01:29:08 +00:00
|
|
|
described_class.run("--greedy")
|
2017-10-29 17:31:07 -03:00
|
|
|
|
2017-11-27 01:29:08 +00:00
|
|
|
expect(local_caffeine).to be_installed
|
|
|
|
expect(local_caffeine_path).to be_a_directory
|
|
|
|
expect(local_caffeine.versions).to include("1.2.3")
|
2017-11-24 01:21:30 +00:00
|
|
|
|
2017-11-27 01:29:08 +00:00
|
|
|
expect(auto_updates).to be_installed
|
|
|
|
expect(auto_updates_path).to be_a_directory
|
|
|
|
expect(auto_updates.versions).to include("2.61")
|
2017-11-07 22:27:04 -03:00
|
|
|
|
2017-11-27 01:29:08 +00:00
|
|
|
expect(local_transmission).to be_installed
|
|
|
|
expect(local_transmission_path).to be_a_directory
|
|
|
|
expect(local_transmission.versions).to include("2.61")
|
2017-11-28 00:29:45 +00:00
|
|
|
|
|
|
|
expect(version_latest).to be_installed
|
|
|
|
expect(version_latest_path_1).to be_a_directory
|
|
|
|
expect(version_latest_path_2).to be_a_directory
|
|
|
|
expect(version_latest.versions).to include("latest")
|
2017-11-27 01:29:08 +00:00
|
|
|
end
|
2017-10-29 17:31:07 -03:00
|
|
|
|
2017-11-27 01:29:08 +00:00
|
|
|
it 'does not include the Casks with "auto_updates true" when the version did not change' do
|
2018-09-06 08:29:14 +02:00
|
|
|
cask = Cask::CaskLoader.load("auto-updates")
|
2019-02-02 17:11:37 +01:00
|
|
|
cask_path = cask.config.appdir.join("MyFancyApp.app")
|
2017-10-29 17:31:07 -03:00
|
|
|
|
2017-11-27 01:29:08 +00:00
|
|
|
expect(cask).to be_installed
|
|
|
|
expect(cask_path).to be_a_directory
|
|
|
|
expect(cask.versions).to include("2.57")
|
2017-11-07 22:27:04 -03:00
|
|
|
|
2017-11-27 01:29:08 +00:00
|
|
|
described_class.run("auto-updates", "--greedy")
|
2017-10-29 17:31:07 -03:00
|
|
|
|
2017-11-27 01:29:08 +00:00
|
|
|
expect(cask).to be_installed
|
|
|
|
expect(cask_path).to be_a_directory
|
|
|
|
expect(cask.versions).to include("2.61")
|
2017-11-07 22:27:04 -03:00
|
|
|
|
2017-11-27 01:29:08 +00:00
|
|
|
described_class.run("auto-updates", "--greedy")
|
2017-11-24 01:21:30 +00:00
|
|
|
|
2017-11-27 01:29:08 +00:00
|
|
|
expect(cask).to be_installed
|
|
|
|
expect(cask_path).to be_a_directory
|
|
|
|
expect(cask.versions).to include("2.61")
|
|
|
|
end
|
2017-10-29 17:31:07 -03:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-11-27 01:29:08 +00:00
|
|
|
context "failed upgrade" do
|
|
|
|
let(:installed) {
|
|
|
|
[
|
|
|
|
"outdated/bad-checksum",
|
|
|
|
"outdated/will-fail-if-upgraded",
|
|
|
|
]
|
|
|
|
}
|
2017-10-29 17:31:07 -03:00
|
|
|
|
2018-03-25 13:30:37 +01:00
|
|
|
before do
|
2018-09-06 08:29:14 +02:00
|
|
|
installed.each { |cask| Cask::Cmd::Install.run(cask) }
|
2017-10-29 17:31:07 -03:00
|
|
|
|
2017-11-27 01:29:08 +00:00
|
|
|
allow_any_instance_of(described_class).to receive(:verbose?).and_return(true)
|
2017-10-29 17:31:07 -03:00
|
|
|
end
|
2017-11-12 09:25:15 -03:00
|
|
|
|
|
|
|
output_reverted = Regexp.new <<~EOS
|
|
|
|
Warning: Reverting upgrade for Cask .*
|
|
|
|
EOS
|
|
|
|
|
2017-11-24 00:48:14 +00:00
|
|
|
it "restores the old Cask if the upgrade failed" do
|
2018-09-06 08:29:14 +02:00
|
|
|
will_fail_if_upgraded = Cask::CaskLoader.load("will-fail-if-upgraded")
|
2019-02-02 17:11:37 +01:00
|
|
|
will_fail_if_upgraded_path = will_fail_if_upgraded.config.appdir.join("container")
|
2017-11-24 01:21:30 +00:00
|
|
|
|
|
|
|
expect(will_fail_if_upgraded).to be_installed
|
|
|
|
expect(will_fail_if_upgraded_path).to be_a_file
|
|
|
|
expect(will_fail_if_upgraded.versions).to include("1.2.2")
|
2017-11-12 09:25:15 -03:00
|
|
|
|
|
|
|
expect {
|
2017-11-24 00:48:14 +00:00
|
|
|
described_class.run("will-fail-if-upgraded")
|
2018-09-06 08:29:14 +02:00
|
|
|
}.to raise_error(Cask::CaskError).and output(output_reverted).to_stderr
|
2017-11-12 09:25:15 -03:00
|
|
|
|
2017-11-24 01:21:30 +00:00
|
|
|
expect(will_fail_if_upgraded).to be_installed
|
|
|
|
expect(will_fail_if_upgraded_path).to be_a_file
|
|
|
|
expect(will_fail_if_upgraded.versions).to include("1.2.2")
|
2018-03-25 13:30:37 +01:00
|
|
|
expect(will_fail_if_upgraded.staged_path).not_to exist
|
2017-11-12 09:25:15 -03:00
|
|
|
end
|
|
|
|
|
2017-11-27 01:29:08 +00:00
|
|
|
it "does not restore the old Cask if the upgrade failed pre-install" do
|
2018-09-06 08:29:14 +02:00
|
|
|
bad_checksum = Cask::CaskLoader.load("bad-checksum")
|
2019-02-02 17:11:37 +01:00
|
|
|
bad_checksum_path = bad_checksum.config.appdir.join("Caffeine.app")
|
2017-11-24 01:21:30 +00:00
|
|
|
|
|
|
|
expect(bad_checksum).to be_installed
|
|
|
|
expect(bad_checksum_path).to be_a_directory
|
|
|
|
expect(bad_checksum.versions).to include("1.2.2")
|
2017-11-12 09:25:15 -03:00
|
|
|
|
|
|
|
expect {
|
2017-11-24 00:48:14 +00:00
|
|
|
described_class.run("bad-checksum")
|
2018-09-06 08:29:14 +02:00
|
|
|
}.to raise_error(Cask::CaskSha256MismatchError).and(not_to_output(output_reverted).to_stderr)
|
2017-11-12 09:25:15 -03:00
|
|
|
|
2017-11-24 01:21:30 +00:00
|
|
|
expect(bad_checksum).to be_installed
|
|
|
|
expect(bad_checksum_path).to be_a_directory
|
|
|
|
expect(bad_checksum.versions).to include("1.2.2")
|
2018-03-25 13:30:37 +01:00
|
|
|
expect(bad_checksum.staged_path).not_to exist
|
2017-11-12 09:25:15 -03:00
|
|
|
end
|
|
|
|
end
|
2017-10-29 17:31:07 -03:00
|
|
|
end
|