299 lines
8.5 KiB
Ruby
Raw Normal View History

rubocop: Use `Sorbet/StrictSigil` as it's better than comments - Previously I thought that comments were fine to discourage people from wasting their time trying to bump things that used `undef` that Sorbet didn't support. But RuboCop is better at this since it'll complain if the comments are unnecessary. - Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501. - I've gone for a mixture of `rubocop:disable` for the files that can't be `typed: strict` (use of undef, required before everything else, etc) and `rubocop:todo` for everything else that should be tried to make strictly typed. There's no functional difference between the two as `rubocop:todo` is `rubocop:disable` with a different name. - And I entirely disabled the cop for the docs/ directory since `typed: strict` isn't going to gain us anything for some Markdown linting config files. - This means that now it's easier to track what needs to be done rather than relying on checklists of files in our big Sorbet issue: ```shell $ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l 268 ``` - And this is confirmed working for new files: ```shell $ git status On branch use-rubocop-for-sorbet-strict-sigils Untracked files: (use "git add <file>..." to include in what will be committed) Library/Homebrew/bad.rb Library/Homebrew/good.rb nothing added to commit but untracked files present (use "git add" to track) $ brew style Offenses: bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true. ^^^^^^^^^^^^^ 1340 files inspected, 1 offense detected ```
2024-08-12 10:30:59 +01:00
# typed: true # rubocop:todo Sorbet/StrictSigil
# frozen_string_literal: true
require "os/linux/ld"
2020-08-25 00:11:59 +02:00
# {Pathname} extension for dealing with ELF files.
# @see https://en.wikipedia.org/wiki/Executable_and_Linkable_Format#File_header
2017-12-01 16:29:50 -08:00
module ELFShim
2024-10-06 09:25:57 -07:00
extend T::Helpers
2017-12-01 16:29:50 -08:00
MAGIC_NUMBER_OFFSET = 0
2020-08-25 00:11:59 +02:00
private_constant :MAGIC_NUMBER_OFFSET
MAGIC_NUMBER_ASCII = "\x7fELF"
2020-08-25 00:11:59 +02:00
private_constant :MAGIC_NUMBER_ASCII
2017-12-01 16:29:50 -08:00
OS_ABI_OFFSET = 0x07
2020-08-25 00:11:59 +02:00
private_constant :OS_ABI_OFFSET
2017-12-01 16:29:50 -08:00
OS_ABI_SYSTEM_V = 0
2020-08-25 00:11:59 +02:00
private_constant :OS_ABI_SYSTEM_V
2017-12-01 16:29:50 -08:00
OS_ABI_LINUX = 3
2020-08-25 00:11:59 +02:00
private_constant :OS_ABI_LINUX
2017-12-01 16:29:50 -08:00
TYPE_OFFSET = 0x10
2020-08-25 00:11:59 +02:00
private_constant :TYPE_OFFSET
2017-12-01 16:29:50 -08:00
TYPE_EXECUTABLE = 2
2020-08-25 00:11:59 +02:00
private_constant :TYPE_EXECUTABLE
2017-12-01 16:29:50 -08:00
TYPE_SHARED = 3
2020-08-25 00:11:59 +02:00
private_constant :TYPE_SHARED
2017-12-01 16:29:50 -08:00
ARCHITECTURE_OFFSET = 0x12
2020-08-25 00:11:59 +02:00
private_constant :ARCHITECTURE_OFFSET
2017-12-01 16:29:50 -08:00
ARCHITECTURE_I386 = 0x3
2020-08-25 00:11:59 +02:00
private_constant :ARCHITECTURE_I386
2017-12-01 16:29:50 -08:00
ARCHITECTURE_POWERPC = 0x14
2020-08-25 00:11:59 +02:00
private_constant :ARCHITECTURE_POWERPC
ARCHITECTURE_POWERPC64 = 0x15
private_constant :ARCHITECTURE_POWERPC64
2017-12-01 16:29:50 -08:00
ARCHITECTURE_ARM = 0x28
2020-08-25 00:11:59 +02:00
private_constant :ARCHITECTURE_ARM
ARCHITECTURE_X86_64 = 0x3E
2020-08-25 00:11:59 +02:00
private_constant :ARCHITECTURE_X86_64
2017-12-01 16:29:50 -08:00
ARCHITECTURE_AARCH64 = 0xB7
2020-08-25 00:11:59 +02:00
private_constant :ARCHITECTURE_AARCH64
2017-12-01 16:29:50 -08:00
2024-10-06 09:25:57 -07:00
requires_ancestor { Pathname }
def initialize(*args)
@elf = T.let(nil, T.nilable(T::Boolean))
@arch = T.let(nil, T.nilable(Symbol))
@elf_type = T.let(nil, T.nilable(Symbol))
@rpath = T.let(nil, T.nilable(String))
@interpreter = T.let(nil, T.nilable(String))
@dynamic_elf = T.let(nil, T.nilable(T::Boolean))
@metadata = T.let(nil, T.nilable(Metadata))
@patchelf_patcher = nil
super
end
2017-12-01 16:29:50 -08:00
def read_uint8(offset)
2019-10-13 10:13:42 +01:00
read(1, offset).unpack1("C")
2017-12-01 16:29:50 -08:00
end
def read_uint16(offset)
2019-10-13 10:13:42 +01:00
read(2, offset).unpack1("v")
2017-12-01 16:29:50 -08:00
end
sig { returns(T::Boolean) }
2017-12-01 16:29:50 -08:00
def elf?
return @elf unless @elf.nil?
2023-04-18 15:06:50 -07:00
return @elf = false if read(MAGIC_NUMBER_ASCII.size, MAGIC_NUMBER_OFFSET) != MAGIC_NUMBER_ASCII
2017-12-01 16:29:50 -08:00
# Check that this ELF file is for Linux or System V.
# OS_ABI is often set to 0 (System V), regardless of the target platform.
@elf = [OS_ABI_LINUX, OS_ABI_SYSTEM_V].include? read_uint8(OS_ABI_OFFSET)
end
sig { returns(Symbol) }
2017-12-01 16:29:50 -08:00
def arch
return :dunno unless elf?
@arch ||= case read_uint16(ARCHITECTURE_OFFSET)
when ARCHITECTURE_I386 then :i386
when ARCHITECTURE_X86_64 then :x86_64
when ARCHITECTURE_POWERPC then :ppc32
when ARCHITECTURE_POWERPC64 then :ppc64
2017-12-01 16:29:50 -08:00
when ARCHITECTURE_ARM then :arm
when ARCHITECTURE_AARCH64 then :arm64
else :dunno
end
end
def arch_compatible?(wanted_arch)
return true unless elf?
# Treat ppc64le and ppc64 the same
wanted_arch = :ppc64 if wanted_arch == :ppc64le
wanted_arch == arch
end
sig { returns(Symbol) }
2017-12-01 16:29:50 -08:00
def elf_type
return :dunno unless elf?
@elf_type ||= case read_uint16(TYPE_OFFSET)
when TYPE_EXECUTABLE then :executable
when TYPE_SHARED then :dylib
else :dunno
end
end
def dylib?
elf_type == :dylib
end
def binary_executable?
elf_type == :executable
end
# The runtime search path, such as:
# "/lib:/usr/lib:/usr/local/lib"
sig { returns(T.nilable(String)) }
def rpath
@rpath ||= rpath_using_patchelf_rb
end
# An array of runtime search path entries, such as:
# ["/lib", "/usr/lib", "/usr/local/lib"]
def rpaths
Array(rpath&.split(":"))
end
sig { returns(T.nilable(String)) }
def interpreter
@interpreter ||= patchelf_patcher.interpreter
end
2020-08-05 20:32:37 +05:30
def patch!(interpreter: nil, rpath: nil)
return if interpreter.blank? && rpath.blank?
save_using_patchelf_rb interpreter, rpath
2020-08-05 20:32:37 +05:30
end
sig { returns(T::Boolean) }
2017-12-01 16:29:50 -08:00
def dynamic_elf?
@dynamic_elf ||= patchelf_patcher.elf.segment_by_type(:DYNAMIC).present?
2017-12-01 16:29:50 -08:00
end
2020-08-25 00:11:59 +02:00
# Helper class for reading metadata from an ELF file.
2017-12-01 16:29:50 -08:00
class Metadata
sig { returns(ELFShim) }
attr_reader :path
sig { returns(T.nilable(String)) }
attr_reader :dylib_id
sig { returns(T::Array[String]) }
attr_reader :dylibs
2017-12-01 16:29:50 -08:00
sig { params(path: ELFShim).void }
2017-12-01 16:29:50 -08:00
def initialize(path)
@path = T.let(path, ELFShim)
@dylibs = T.let([], T::Array[String])
@dylib_id = T.let(nil, T.nilable(String))
2017-12-01 16:29:50 -08:00
@dylib_id, needed = needed_libraries path
@dylibs = needed.map { |lib| find_full_lib_path(lib).to_s } if needed.present?
2017-12-01 16:29:50 -08:00
@metadata = T.let(nil, T.nilable(T::Hash[String, T.untyped]))
2017-12-01 16:29:50 -08:00
end
private
def needed_libraries(path)
return [nil, []] unless path.dynamic_elf?
needed_libraries_using_patchelf_rb path
2017-12-01 16:29:50 -08:00
end
def needed_libraries_using_patchelf_rb(path)
patcher = path.patchelf_patcher
[patcher.soname, patcher.needed]
end
def find_full_lib_path(basename)
local_paths = (path.patchelf_patcher.runpath || path.patchelf_patcher.rpath)&.split(":")
# Search for dependencies in the runpath/rpath first
local_paths&.each do |local_path|
local_path = OS::Linux::Elf.expand_elf_dst(local_path, "ORIGIN", path.parent)
candidate = Pathname(local_path)/basename
return candidate if candidate.exist? && candidate.elf?
end
# Check if DF_1_NODEFLIB is set
dt_flags_1 = path.patchelf_patcher.elf.segment_by_type(:dynamic)&.tag_by_type(:flags_1)
nodeflib_flag = if dt_flags_1.nil?
false
else
dt_flags_1.value & ELFTools::Constants::DF::DF_1_NODEFLIB != 0
end
linker_library_paths = OS::Linux::Ld.library_paths
linker_system_dirs = OS::Linux::Ld.system_dirs
# If DF_1_NODEFLIB is set, exclude any library paths that are subdirectories
# of the system dirs
if nodeflib_flag
linker_library_paths = linker_library_paths.reject do |lib_path|
linker_system_dirs.any? { |system_dir| Utils::Path.child_of? system_dir, lib_path }
end
end
# If not found, search recursively in the paths listed in ld.so.conf (skipping
# paths that are subdirectories of the system dirs if DF_1_NODEFLIB is set)
linker_library_paths.each do |linker_library_path|
candidate = Pathname(linker_library_path)/basename
return candidate if candidate.exist? && candidate.elf?
end
# If not found, search in the system dirs, unless DF_1_NODEFLIB is set
unless nodeflib_flag
linker_system_dirs.each do |linker_system_dir|
candidate = Pathname(linker_system_dir)/basename
return candidate if candidate.exist? && candidate.elf?
end
end
basename
end
2017-12-01 16:29:50 -08:00
end
2020-08-25 00:11:59 +02:00
private_constant :Metadata
2017-12-01 16:29:50 -08:00
2020-08-05 20:32:37 +05:30
def save_using_patchelf_rb(new_interpreter, new_rpath)
patcher = patchelf_patcher
patcher.interpreter = new_interpreter if new_interpreter.present?
patcher.rpath = new_rpath if new_rpath.present?
patcher.save(patchelf_compatible: true)
end
def rpath_using_patchelf_rb
patchelf_patcher.runpath || patchelf_patcher.rpath
end
def patchelf_patcher
2020-07-28 23:09:13 +05:30
require "patchelf"
2020-08-05 20:32:37 +05:30
@patchelf_patcher ||= ::PatchELF::Patcher.new to_s, on_error: :silent
end
sig { returns(Metadata) }
2017-12-01 16:29:50 -08:00
def metadata
@metadata ||= Metadata.new(self)
end
2020-08-25 00:11:59 +02:00
private :metadata
2017-12-01 16:29:50 -08:00
def dylib_id
metadata.dylib_id
end
def dynamically_linked_libraries(*)
metadata.dylibs
end
end
module OS
module Linux
# Helper functions for working with ELF objects.
#
# @api private
module Elf
sig { params(str: String, ref: String, repl: T.any(String, Pathname)).returns(String) }
def self.expand_elf_dst(str, ref, repl)
# ELF gABI rules for DSTs:
# - Longest possible sequence using the rules (greedy).
# - Must start with a $ (enforced by caller).
# - Must follow $ with one underscore or ASCII [A-Za-z] (caller
# follows these rules for REF) or '{' (start curly quoted name).
# - Must follow first two characters with zero or more [A-Za-z0-9_]
# (enforced by caller) or '}' (end curly quoted name).
# (from https://github.com/bminor/glibc/blob/41903cb6f460d62ba6dd2f4883116e2a624ee6f8/elf/dl-load.c#L182-L228)
# In addition to capturing a token, also attempt to capture opening/closing braces and check that they are not
# mismatched before expanding.
str.gsub(/\$({?)([a-zA-Z_][a-zA-Z0-9_]*)(}?)/) do |orig_str|
has_opening_brace = ::Regexp.last_match(1).present?
matched_text = ::Regexp.last_match(2)
has_closing_brace = ::Regexp.last_match(3).present?
if (matched_text == ref) && (has_opening_brace == has_closing_brace)
repl
else
orig_str
end
end
end
end
end
end