brew/Library/Homebrew/linkage_checker.rb

350 lines
11 KiB
Ruby
Raw Normal View History

2020-10-10 14:16:11 +02:00
# typed: true
# frozen_string_literal: true
2016-07-07 20:41:14 +08:00
require "keg"
require "formula"
require "linkage_cache_store"
require "fiddle"
2016-07-07 20:41:14 +08:00
2020-08-17 19:56:24 +02:00
# Check for broken/missing linkage in a formula's keg.
#
# @api private
2016-07-07 20:41:14 +08:00
class LinkageChecker
2020-10-20 12:03:48 +02:00
extend T::Sig
2020-07-07 11:29:33 +01:00
attr_reader :undeclared_deps, :keg, :formula, :store
def initialize(keg, formula = nil, cache_db:, rebuild_cache: false)
2016-07-07 20:41:14 +08:00
@keg = keg
@formula = formula || resolve_formula(keg)
@store = LinkageCacheStore.new(keg.to_s, cache_db)
@system_dylibs = Set.new
@broken_dylibs = Set.new
@unexpected_broken_dylibs = nil
2020-07-21 19:56:53 +00:00
@unexpected_present_dylibs = nil
@variable_dylibs = Set.new
@brewed_dylibs = Hash.new { |h, k| h[k] = Set.new }
@reverse_links = Hash.new { |h, k| h[k] = Set.new }
@broken_deps = Hash.new { |h, k| h[k] = [] }
@indirect_deps = []
@undeclared_deps = []
@unnecessary_deps = []
@unwanted_system_dylibs = []
@version_conflict_deps = []
@files_missing_rpaths = []
check_dylibs(rebuild_cache: rebuild_cache)
end
def display_normal_output
display_items "System libraries", @system_dylibs
display_items "Homebrew libraries", @brewed_dylibs
display_items "Indirect dependencies with linkage", @indirect_deps
display_items "Variable-referenced libraries", @variable_dylibs
display_items "Missing libraries", @broken_dylibs
display_items "Broken dependencies", @broken_deps
display_items "Undeclared dependencies with linkage", @undeclared_deps
display_items "Dependencies with no linkage", @unnecessary_deps
display_items "Unwanted system libraries", @unwanted_system_dylibs
display_items "Files with missing rpath", @files_missing_rpaths
end
alias generic_display_normal_output display_normal_output
private :generic_display_normal_output
def display_reverse_output
return if @reverse_links.empty?
2018-09-17 02:45:00 +02:00
2018-06-02 20:58:34 +05:30
sorted = @reverse_links.sort
sorted.each do |dylib, files|
puts dylib
files.each do |f|
2018-09-15 00:04:01 +02:00
unprefixed = f.to_s.delete_prefix "#{keg}/"
puts " #{unprefixed}"
end
puts if dylib != sorted.last.first
end
end
def display_test_output(puts_output: true, strict: false)
2020-07-10 21:20:46 +00:00
display_items "Missing libraries", broken_dylibs_with_expectations, puts_output: puts_output
2020-07-21 19:56:53 +00:00
display_items "Unused missing linkage information", unexpected_present_dylibs, puts_output: puts_output
display_items "Broken dependencies", @broken_deps, puts_output: puts_output
display_items "Unwanted system libraries", @unwanted_system_dylibs, puts_output: puts_output
display_items "Conflicting libraries", @version_conflict_deps, puts_output: puts_output
return unless strict
display_items "Undeclared dependencies with linkage", @undeclared_deps, puts_output: puts_output
display_items "Files with missing rpath", @files_missing_rpaths, puts_output: puts_output
end
alias generic_display_test_output display_test_output
private :generic_display_test_output
sig { params(strict: T::Boolean).returns(T::Boolean) }
def broken_library_linkage?(strict: false)
issues = [@broken_deps, @unwanted_system_dylibs, @version_conflict_deps]
issues += [@undeclared_deps, @files_missing_rpaths] if strict
2020-07-21 19:56:53 +00:00
[issues, unexpected_broken_dylibs, unexpected_present_dylibs].flatten.any?(&:present?)
2020-07-10 21:20:46 +00:00
end
alias generic_broken_library_linkage? broken_library_linkage?
private :generic_broken_library_linkage?
2020-07-10 21:20:46 +00:00
def unexpected_broken_dylibs
return @unexpected_broken_dylibs if @unexpected_broken_dylibs
@unexpected_broken_dylibs = @broken_dylibs.reject do |broken_lib|
@formula.class.allowed_missing_libraries.any? do |allowed_missing_lib|
case allowed_missing_lib
when Regexp
allowed_missing_lib.match? broken_lib
when String
broken_lib.include? allowed_missing_lib
end
end
end
2020-06-28 04:33:00 +00:00
end
2020-07-21 19:56:53 +00:00
def unexpected_present_dylibs
@unexpected_present_dylibs ||= @formula.class.allowed_missing_libraries.reject do |allowed_missing_lib|
2020-07-21 19:56:53 +00:00
@broken_dylibs.any? do |broken_lib|
case allowed_missing_lib
when Regexp
allowed_missing_lib.match? broken_lib
when String
broken_lib.include? allowed_missing_lib
end
end
end
end
2020-07-10 21:20:46 +00:00
def broken_dylibs_with_expectations
output = {}
@broken_dylibs.each do |broken_lib|
output[broken_lib] = if unexpected_broken_dylibs.include? broken_lib
["unexpected"]
else
["expected"]
end
2020-07-10 21:20:46 +00:00
end
output
end
private
def dylib_to_dep(dylib)
2020-11-16 22:18:56 +01:00
dylib =~ %r{#{Regexp.escape(HOMEBREW_PREFIX)}/(opt|Cellar)/([\w+-.@]+)/}o
2018-03-20 12:30:14 -05:00
Regexp.last_match(2)
end
def check_dylibs(rebuild_cache:)
keg_files_dylibs = nil
if rebuild_cache
store&.delete!
else
keg_files_dylibs = store&.fetch(:keg_files_dylibs)
end
keg_files_dylibs_was_empty = false
keg_files_dylibs ||= {}
if keg_files_dylibs.empty?
keg_files_dylibs_was_empty = true
@keg.find do |file|
next if file.symlink? || file.directory?
next if !file.dylib? && !file.binary_executable? && !file.mach_o_bundle?
2018-09-17 02:45:00 +02:00
# weakly loaded dylibs may not actually exist on disk, so skip them
# when checking for broken linkage
keg_files_dylibs[file] =
file.dynamically_linked_libraries(except: :LC_LOAD_WEAK_DYLIB)
end
end
checked_dylibs = Set.new
keg_files_dylibs.each do |file, dylibs|
file_has_any_rpath_dylibs = T.let(false, T::Boolean)
dylibs.each do |dylib|
2016-07-07 20:41:14 +08:00
@reverse_links[dylib] << file
# Files that link @rpath-prefixed dylibs must include at
# least one rpath in order to resolve it.
if !file_has_any_rpath_dylibs && (dylib.start_with? "@rpath/")
file_has_any_rpath_dylibs = true
pathname = Pathname(file)
@files_missing_rpaths << file if pathname.rpaths.empty?
end
next if checked_dylibs.include? dylib
2018-09-17 02:45:00 +02:00
checked_dylibs << dylib
2016-07-07 20:41:14 +08:00
if dylib.start_with? "@"
@variable_dylibs << dylib
next
end
begin
owner = Keg.for Pathname.new(dylib)
rescue NotAKegError
@system_dylibs << dylib
rescue Errno::ENOENT
next if harmless_broken_link?(dylib)
2018-09-17 02:45:00 +02:00
if (dep = dylib_to_dep(dylib))
@broken_deps[dep] |= [dylib]
elsif MacOS.version >= :big_sur && dylib_found_via_dlopen(dylib)
# If we cannot associate the dylib with a dependency, then it may be a system library.
# In macOS Big Sur and later, system libraries do not exist on-disk and instead exist in a cache.
# If dlopen finds the dylib, then the linkage is not broken.
@system_dylibs << dylib
else
@broken_dylibs << dylib
end
2016-07-07 20:41:14 +08:00
else
tap = Tab.for_keg(owner).tap
f = if tap.nil? || tap.core_tap?
owner.name
2016-07-07 20:41:14 +08:00
else
"#{tap}/#{owner.name}"
2016-07-07 20:41:14 +08:00
end
@brewed_dylibs[f] << dylib
2016-07-07 20:41:14 +08:00
end
end
end
2018-05-22 14:46:14 +01:00
if formula
@indirect_deps, @undeclared_deps, @unnecessary_deps,
@version_conflict_deps = check_formula_deps
2018-05-22 14:46:14 +01:00
end
return unless keg_files_dylibs_was_empty
store&.update!(keg_files_dylibs: keg_files_dylibs)
end
alias generic_check_dylibs check_dylibs
def dylib_found_via_dlopen(dylib)
Fiddle.dlopen(dylib).close
true
rescue Fiddle::DLError
false
end
def check_formula_deps
filter_out = proc do |dep|
next true if dep.build?
2018-09-17 02:45:00 +02:00
(dep.optional? || dep.recommended?) && formula.build.without?(dep)
end
declared_deps_full_names = formula.deps
.reject { |dep| filter_out.call(dep) }
.map(&:name)
declared_deps_names = declared_deps_full_names.map do |dep|
dep.split("/").last
end
recursive_deps = formula.runtime_formula_dependencies(undeclared: false)
.map(&:name)
indirect_deps = []
undeclared_deps = []
@brewed_dylibs.each_key do |full_name|
name = full_name.split("/").last
next if name == formula.name
2018-09-17 02:45:00 +02:00
if recursive_deps.include?(name)
indirect_deps << full_name unless declared_deps_names.include?(name)
else
undeclared_deps << full_name
end
end
sort_by_formula_full_name!(indirect_deps)
sort_by_formula_full_name!(undeclared_deps)
unnecessary_deps = declared_deps_full_names.reject do |full_name|
next true if Formula[full_name].bin.directory?
2018-09-17 02:45:00 +02:00
name = full_name.split("/").last
@brewed_dylibs.keys.map { |l| l.split("/").last }.include?(name)
end
2018-04-07 15:35:27 -05:00
missing_deps = @broken_deps.values.flatten.map { |d| dylib_to_dep(d) }
unnecessary_deps -= missing_deps
version_hash = {}
version_conflict_deps = Set.new
2020-02-19 11:18:40 +00:00
@brewed_dylibs.each_key do |l|
name = l.split("/").last
unversioned_name, = name.split("@")
version_hash[unversioned_name] ||= Set.new
version_hash[unversioned_name] << name
next if version_hash[unversioned_name].length < 2
2018-09-17 02:45:00 +02:00
version_conflict_deps += version_hash[unversioned_name]
end
[indirect_deps, undeclared_deps,
unnecessary_deps, version_conflict_deps.to_a]
end
def sort_by_formula_full_name!(arr)
arr.sort! do |a, b|
2020-12-01 17:04:59 +00:00
if a.include?("/") && b.exclude?("/")
1
2020-12-01 17:04:59 +00:00
elsif a.exclude?("/") && b.include?("/")
-1
else
a <=> b
2016-07-07 20:41:14 +08:00
end
end
2016-07-07 20:41:14 +08:00
end
# Whether or not dylib is a harmless broken link, meaning that it's
# okay to skip (and not report) as broken.
def harmless_broken_link?(dylib)
# libgcc_s_* is referenced by programs that use the Java Service Wrapper,
# and is harmless on x86(_64) machines
return true if [
"/usr/lib/libgcc_s_ppc64.1.dylib",
"/opt/local/lib/libgcc/libgcc_s.1.dylib",
].include?(dylib)
dylib.start_with?("/System/Library/Frameworks/")
end
2016-07-07 20:41:14 +08:00
# Display a list of things.
# Things may either be an array, or a hash of (label -> array).
def display_items(label, things, puts_output: true)
2016-07-07 20:41:14 +08:00
return if things.empty?
2018-09-17 02:45:00 +02:00
output = "#{label}:"
2016-07-07 20:41:14 +08:00
if things.is_a? Hash
things.keys.sort.each do |list_label|
things[list_label].sort.each do |item|
output += "\n #{item} (#{list_label})"
2016-07-07 20:41:14 +08:00
end
end
else
things.sort.each do |item|
2020-07-21 19:56:53 +00:00
output += if item.is_a? Regexp
"\n #{item.inspect}"
2020-07-21 19:56:53 +00:00
else
"\n #{item}"
end
2016-07-07 20:41:14 +08:00
end
end
puts output if puts_output
output
2016-07-07 20:41:14 +08:00
end
def resolve_formula(keg)
2016-07-15 17:45:21 +08:00
Formulary.from_keg(keg)
rescue FormulaUnavailableError
opoo "Formula unavailable: #{keg.name}"
end
2016-07-07 20:41:14 +08:00
end
require "extend/os/linkage_checker"