2018-10-26 19:41:14 +01:00
|
|
|
require "rubocops/components_redundancy"
|
2017-04-08 15:10:44 +05:30
|
|
|
|
2018-04-25 07:58:01 +10:00
|
|
|
describe RuboCop::Cop::FormulaAudit::ComponentsRedundancy do
|
2017-04-08 15:10:44 +05:30
|
|
|
subject(:cop) { described_class.new }
|
|
|
|
|
|
|
|
context "When auditing formula components common errors" do
|
|
|
|
it "When url outside stable block" do
|
2017-10-21 03:12:50 +02:00
|
|
|
expect_offense(<<~RUBY)
|
2017-04-08 15:10:44 +05:30
|
|
|
class Foo < Formula
|
2018-11-28 20:51:55 +01:00
|
|
|
url "https://brew.sh/foo-1.0.tgz"
|
|
|
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `url` should be put inside `stable` block
|
2017-04-08 15:10:44 +05:30
|
|
|
stable do
|
|
|
|
# stuff
|
|
|
|
end
|
2018-07-03 11:46:39 +10:00
|
|
|
|
|
|
|
devel do
|
|
|
|
# stuff
|
|
|
|
end
|
2017-04-08 15:10:44 +05:30
|
|
|
end
|
2017-10-21 03:12:50 +02:00
|
|
|
RUBY
|
2017-04-08 15:10:44 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it "When both `head` and `head do` are present" do
|
2017-10-21 03:12:50 +02:00
|
|
|
expect_offense(<<~RUBY)
|
2017-04-08 15:10:44 +05:30
|
|
|
class Foo < Formula
|
2018-11-28 20:51:55 +01:00
|
|
|
head "https://brew.sh/foo.git"
|
2017-04-08 15:10:44 +05:30
|
|
|
head do
|
2017-10-21 03:12:50 +02:00
|
|
|
^^^^^^^ `head` and `head do` should not be simultaneously present
|
2017-04-08 15:10:44 +05:30
|
|
|
# stuff
|
|
|
|
end
|
|
|
|
end
|
2017-10-21 03:12:50 +02:00
|
|
|
RUBY
|
2017-04-08 15:10:44 +05:30
|
|
|
end
|
|
|
|
|
|
|
|
it "When both `bottle :modifier` and `bottle do` are present" do
|
2017-10-21 03:12:50 +02:00
|
|
|
expect_offense(<<~RUBY)
|
2017-04-08 15:10:44 +05:30
|
|
|
class Foo < Formula
|
2018-11-28 20:51:55 +01:00
|
|
|
url "https://brew.sh/foo-1.0.tgz"
|
2017-04-08 15:10:44 +05:30
|
|
|
bottle do
|
2017-10-21 03:12:50 +02:00
|
|
|
^^^^^^^^^ `bottle :modifier` and `bottle do` should not be simultaneously present
|
2017-04-08 15:10:44 +05:30
|
|
|
# bottles go here
|
|
|
|
end
|
|
|
|
bottle :unneeded
|
|
|
|
end
|
2017-10-21 03:12:50 +02:00
|
|
|
RUBY
|
2017-04-08 15:10:44 +05:30
|
|
|
end
|
2018-07-03 11:46:39 +10:00
|
|
|
|
|
|
|
it "When `stable do` is present with a `head` method" do
|
|
|
|
expect_no_offenses(<<~RUBY)
|
|
|
|
class Foo < Formula
|
2018-11-28 20:51:55 +01:00
|
|
|
head "https://brew.sh/foo.git"
|
2018-07-03 11:46:39 +10:00
|
|
|
|
|
|
|
stable do
|
|
|
|
# stuff
|
|
|
|
end
|
|
|
|
end
|
|
|
|
RUBY
|
|
|
|
end
|
|
|
|
|
|
|
|
it "When `stable do` is present with a `head do` block" do
|
|
|
|
expect_no_offenses(<<~RUBY)
|
|
|
|
class Foo < Formula
|
|
|
|
stable do
|
|
|
|
# stuff
|
|
|
|
end
|
|
|
|
|
|
|
|
head do
|
|
|
|
# stuff
|
|
|
|
end
|
|
|
|
end
|
|
|
|
RUBY
|
|
|
|
end
|
|
|
|
|
|
|
|
it "When `stable do` is present with a `devel` block" do
|
|
|
|
expect_no_offenses(<<~RUBY)
|
|
|
|
class Foo < Formula
|
|
|
|
stable do
|
|
|
|
# stuff
|
|
|
|
end
|
|
|
|
|
|
|
|
devel do
|
|
|
|
# stuff
|
|
|
|
end
|
|
|
|
end
|
|
|
|
RUBY
|
|
|
|
end
|
2017-04-08 15:10:44 +05:30
|
|
|
end
|
|
|
|
end
|