Merge pull request #11782 from yahavi/undefined-delete-if

Error raised when no headers defined in curl download
This commit is contained in:
Carlo Cabrera 2021-07-27 22:05:12 +08:00 committed by GitHub
commit 008c4759c6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -391,7 +391,7 @@ class CurlDownloadStrategy < AbstractFileDownloadStrategy
resolved_url, _, url_time, _, is_redirection =
resolve_url_basename_time_file_size(url, timeout: end_time&.remaining!)
# Authorization is no longer valid after redirects
meta[:headers].delete_if { |header| header.first&.start_with?("Authorization") } if is_redirection
meta[:headers]&.delete_if { |header| header.first&.start_with?("Authorization") } if is_redirection
fresh = if cached_location.exist? && url_time
url_time <= cached_location.mtime