mirrors/brew
1
0
Fork 0
mirror of https://github.com/Homebrew/brew.git synced 2025-07-14 16:09:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

formula: disable! deprecates before disable date.

Browse Source 
This makes more sense to me; if we expect a formula will be disabled at
a given point in the future then we should deprecate it immediately.
This commit is contained in:
Mike McQuaid 2020-04-29 09:34:40 +01:00
parent d48d1e5e2c
commit 04a64bb724
No known key found for this signature in database
GPG Key ID: 48A898132FD8EE70
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Library/Homebrew/formula.rb
View File

@ -2637,7 +2637,9 @@ class Formula
@pour_bottle_check.instance_eval(&block) @pour_bottle_check.instance_eval(&block)
end end
# Deprecates a {Formula} so a warning is shown on each installation. # Deprecates a {Formula} (on a given date, if provided) so a warning is
# shown on each installation. If the date has not yet passed the formula
# will not be deprecated.
def deprecate!(date: nil) def deprecate!(date: nil)
return if date.present? && Date.parse(date) > Date.today return if date.present? && Date.parse(date) > Date.today
@ -2651,9 +2653,14 @@ class Formula
@deprecated == true @deprecated == true
end end
# Disables a {Formula} so it cannot be installed. # Disables a {Formula} (on a given date, if provided) so it cannot be
# installed. If the date has not yet passed the formula
# will be deprecated instead of disabled.
def disable!(date: nil) def disable!(date: nil)
return if date.present? && Date.parse(date) > Date.today if date.present? && Date.parse(date) > Date.today
@deprecated = true
return
end
@disabled = true @disabled = true
end end