Only "extend self" once on the Homebrew module

This commit is contained in:
Jack Nagel 2014-06-18 22:41:47 -05:00
parent 1cd31db1a8
commit 10a1952d2c
52 changed files with 52 additions and 58 deletions

View File

@ -1,7 +1,6 @@
require 'extend/pathname' require 'extend/pathname'
module Homebrew
module Homebrew extend self
def which_versions which_brews=nil def which_versions which_brews=nil
brew_links = Array.new brew_links = Array.new
version_map = Hash.new version_map = Hash.new

View File

@ -1,6 +1,6 @@
require "cmd/fetch" require "cmd/fetch"
module Homebrew extend self module Homebrew
def __cache def __cache
if ARGV.named.empty? if ARGV.named.empty?
puts HOMEBREW_CACHE puts HOMEBREW_CACHE

View File

@ -1,4 +1,4 @@
module Homebrew extend self module Homebrew
def __cellar def __cellar
if ARGV.named.empty? if ARGV.named.empty?
puts HOMEBREW_CELLAR puts HOMEBREW_CELLAR

View File

@ -1,7 +1,7 @@
require 'extend/ENV' require 'extend/ENV'
require 'hardware' require 'hardware'
module Homebrew extend self module Homebrew
def __env def __env
ENV.activate_extensions! ENV.activate_extensions!

View File

@ -1,4 +1,4 @@
module Homebrew extend self module Homebrew
def __prefix def __prefix
if ARGV.named.empty? if ARGV.named.empty?
puts HOMEBREW_PREFIX puts HOMEBREW_PREFIX

View File

@ -1,4 +1,4 @@
module Homebrew extend self module Homebrew
def __repository def __repository
puts HOMEBREW_REPOSITORY puts HOMEBREW_REPOSITORY
end end

View File

@ -3,7 +3,7 @@ require 'utils'
require 'extend/ENV' require 'extend/ENV'
require 'formula_cellar_checks' require 'formula_cellar_checks'
module Homebrew extend self module Homebrew
def audit def audit
formula_count = 0 formula_count = 0
problem_count = 0 problem_count = 0

View File

@ -32,7 +32,7 @@ BOTTLE_ERB = <<-EOS
end end
EOS EOS
module Homebrew extend self module Homebrew
def keg_contains string, keg def keg_contains string, keg
if not ARGV.homebrew_developer? if not ARGV.homebrew_developer?
return quiet_system 'fgrep', '--recursive', '--quiet', '--max-count=1', string, keg return quiet_system 'fgrep', '--recursive', '--quiet', '--max-count=1', string, keg

View File

@ -1,4 +1,4 @@
module Homebrew extend self module Homebrew
def cat def cat
# do not "fix" this to support multiple arguments, the output would be # do not "fix" this to support multiple arguments, the output would be
# unparsable, if the user wants to cat multiple formula they can call # unparsable, if the user wants to cat multiple formula they can call

View File

@ -2,8 +2,7 @@ require 'formula'
require 'keg' require 'keg'
require 'bottles' require 'bottles'
module Homebrew extend self module Homebrew
def cleanup def cleanup
# individual cleanup_ methods should also check for the existence of the # individual cleanup_ methods should also check for the existence of the
# appropriate directories before assuming they exist # appropriate directories before assuming they exist

View File

@ -1,4 +1,4 @@
module Homebrew extend self module Homebrew
def commands def commands
# Find commands in Homebrew/cmd # Find commands in Homebrew/cmd
cmds = (HOMEBREW_REPOSITORY/"Library/Homebrew/cmd"). cmds = (HOMEBREW_REPOSITORY/"Library/Homebrew/cmd").

View File

@ -1,6 +1,6 @@
require 'hardware' require 'hardware'
module Homebrew extend self module Homebrew
def config def config
dump_verbose_config dump_verbose_config
end end

View File

@ -3,7 +3,7 @@ require 'blacklist'
require 'digest' require 'digest'
require 'erb' require 'erb'
module Homebrew extend self module Homebrew
# Create a formula from a tarball URL # Create a formula from a tarball URL
def create def create

View File

@ -1,7 +1,7 @@
require 'formula' require 'formula'
require 'ostruct' require 'ostruct'
module Homebrew extend self module Homebrew
def deps def deps
mode = OpenStruct.new( mode = OpenStruct.new(
:installed? => ARGV.include?('--installed'), :installed? => ARGV.include?('--installed'),

View File

@ -1,6 +1,6 @@
require "formula" require "formula"
module Homebrew extend self module Homebrew
def diy def diy
%w[name version].each do |opt| %w[name version].each do |opt|
if ARGV.include? "--set-#{opt}" if ARGV.include? "--set-#{opt}"

View File

@ -1122,7 +1122,7 @@ end
end end
end # end class Checks end # end class Checks
module Homebrew extend self module Homebrew
def doctor def doctor
checks = Checks.new checks = Checks.new

View File

@ -1,6 +1,6 @@
require 'formula' require 'formula'
module Homebrew extend self module Homebrew
def edit def edit
unless (HOMEBREW_REPOSITORY/'.git').directory? unless (HOMEBREW_REPOSITORY/'.git').directory?
raise <<-EOS.undent raise <<-EOS.undent

View File

@ -1,6 +1,6 @@
require 'formula' require 'formula'
module Homebrew extend self module Homebrew
def fetch def fetch
raise FormulaUnspecifiedError if ARGV.named.empty? raise FormulaUnspecifiedError if ARGV.named.empty?

View File

@ -31,7 +31,7 @@ EOS
# NOTE Keep lines less than 80 characters! Wrapping is just not cricket. # NOTE Keep lines less than 80 characters! Wrapping is just not cricket.
# NOTE The reason the string is at the top is so 25 lines is easy to measure! # NOTE The reason the string is at the top is so 25 lines is easy to measure!
module Homebrew extend self module Homebrew
def help def help
puts HOMEBREW_HELP puts HOMEBREW_HELP
end end

View File

@ -1,4 +1,4 @@
module Homebrew extend self module Homebrew
def home def home
if ARGV.named.empty? if ARGV.named.empty?
exec_browser HOMEBREW_WWW exec_browser HOMEBREW_WWW

View File

@ -5,7 +5,7 @@ require 'caveats'
require 'blacklist' require 'blacklist'
require 'utils/json' require 'utils/json'
module Homebrew extend self module Homebrew
def info def info
# eventually we'll solidify an API, but we'll keep old versions # eventually we'll solidify an API, but we'll keep old versions
# awhile around for compatibility # awhile around for compatibility

View File

@ -5,7 +5,7 @@ require "cmd/tap"
require "formula_installer" require "formula_installer"
require "hardware" require "hardware"
module Homebrew extend self module Homebrew
def install def install
raise FormulaUnspecifiedError if ARGV.named.empty? raise FormulaUnspecifiedError if ARGV.named.empty?

View File

@ -13,7 +13,7 @@ class String
end end
end end
module Homebrew extend self module Homebrew
def irb def irb
if ARGV.include? "--help" if ARGV.include? "--help"
puts "'v8'.f # => instance of the Ack formula" puts "'v8'.f # => instance of the Ack formula"

View File

@ -2,7 +2,7 @@ require 'formula'
require 'tab' require 'tab'
require 'set' require 'set'
module Homebrew extend self module Homebrew
def leaves def leaves
installed = Formula.installed installed = Formula.installed
deps_of_installed = Set.new deps_of_installed = Set.new

View File

@ -1,7 +1,6 @@
require 'ostruct' require 'ostruct'
module Homebrew extend self module Homebrew
def link def link
raise KegUnspecifiedError if ARGV.named.empty? raise KegUnspecifiedError if ARGV.named.empty?

View File

@ -1,8 +1,7 @@
# Links any Applications (.app) found in installed prefixes to /Applications # Links any Applications (.app) found in installed prefixes to /Applications
require 'keg' require 'keg'
module Homebrew extend self module Homebrew
def linkapps def linkapps
target_dir = ARGV.include?("--local") ? File.expand_path("~/Applications") : "/Applications" target_dir = ARGV.include?("--local") ? File.expand_path("~/Applications") : "/Applications"

View File

@ -1,6 +1,6 @@
require "metafiles" require "metafiles"
module Homebrew extend self module Homebrew
def list def list
# Use of exec means we don't explicitly exit # Use of exec means we don't explicitly exit

View File

@ -1,4 +1,4 @@
module Homebrew extend self module Homebrew
def log def log
if ARGV.named.empty? if ARGV.named.empty?
cd HOMEBREW_REPOSITORY cd HOMEBREW_REPOSITORY

View File

@ -1,7 +1,7 @@
require 'formula' require 'formula'
require 'tab' require 'tab'
module Homebrew extend self module Homebrew
def missing_deps ff def missing_deps ff
missing = {} missing = {}
ff.each do |f| ff.each do |f|

View File

@ -1,6 +1,6 @@
require 'formula' require 'formula'
module Homebrew extend self module Homebrew
def options def options
if ARGV.include? '--all' if ARGV.include? '--all'
puts_options Formula.to_a puts_options Formula.to_a

View File

@ -1,7 +1,7 @@
require 'formula' require 'formula'
require 'keg' require 'keg'
module Homebrew extend self module Homebrew
def outdated def outdated
outdated_brews do |f, versions| outdated_brews do |f, versions|
if ($stdout.tty? || ARGV.verbose?) and not ARGV.flag? '--quiet' if ($stdout.tty? || ARGV.verbose?) and not ARGV.flag? '--quiet'

View File

@ -1,6 +1,6 @@
require 'formula' require 'formula'
module Homebrew extend self module Homebrew
def pin def pin
raise FormulaUnspecifiedError if ARGV.named.empty? raise FormulaUnspecifiedError if ARGV.named.empty?

View File

@ -1,6 +1,6 @@
require 'formula_installer' require 'formula_installer'
module Homebrew extend self module Homebrew
def postinstall def postinstall
ARGV.formulae.each {|f| f.post_install } ARGV.formulae.each {|f| f.post_install }
end end

View File

@ -1,7 +1,7 @@
require 'keg' require 'keg'
require 'cmd/tap' require 'cmd/tap'
module Homebrew extend self module Homebrew
def prune def prune
ObserverPathnameExtension.reset_counts! ObserverPathnameExtension.reset_counts!

View File

@ -1,6 +1,6 @@
require 'cmd/install' require 'cmd/install'
module Homebrew extend self module Homebrew
def reinstall def reinstall
ARGV.formulae.each { |f| reinstall_formula(f) } ARGV.formulae.each { |f| reinstall_formula(f) }
end end

View File

@ -3,7 +3,7 @@ require 'blacklist'
require 'utils' require 'utils'
require 'thread' require 'thread'
module Homebrew extend self module Homebrew
SEARCH_ERROR_QUEUE = Queue.new SEARCH_ERROR_QUEUE = Queue.new

View File

@ -1,7 +1,7 @@
require 'extend/ENV' require 'extend/ENV'
require 'formula' require 'formula'
module Homebrew extend self module Homebrew
def sh def sh
ENV.activate_extensions! ENV.activate_extensions!

View File

@ -1,5 +1,4 @@
module Homebrew extend self module Homebrew
def tap def tap
if ARGV.empty? if ARGV.empty?
each_tap do |user, repo| each_tap do |user, repo|

View File

@ -3,7 +3,7 @@ require 'hardware'
require 'keg' require 'keg'
require 'timeout' require 'timeout'
module Homebrew extend self module Homebrew
TEST_TIMEOUT_SECONDS = 5*60 TEST_TIMEOUT_SECONDS = 5*60
if defined?(Gem) if defined?(Gem)

View File

@ -1,4 +1,4 @@
module Homebrew extend self module Homebrew
def tests def tests
(HOMEBREW_LIBRARY/'Homebrew/test').cd do (HOMEBREW_LIBRARY/'Homebrew/test').cd do
ENV['TESTOPTS'] = '-v' if ARGV.verbose? ENV['TESTOPTS'] = '-v' if ARGV.verbose?

View File

@ -1,7 +1,7 @@
require 'keg' require 'keg'
require 'formula' require 'formula'
module Homebrew extend self module Homebrew
def uninstall def uninstall
raise KegUnspecifiedError if ARGV.named.empty? raise KegUnspecifiedError if ARGV.named.empty?

View File

@ -1,4 +1,4 @@
module Homebrew extend self module Homebrew
def unlink def unlink
raise KegUnspecifiedError if ARGV.named.empty? raise KegUnspecifiedError if ARGV.named.empty?

View File

@ -1,8 +1,7 @@
# Unlinks any Applications (.app) found in installed prefixes from /Applications # Unlinks any Applications (.app) found in installed prefixes from /Applications
require 'keg' require 'keg'
module Homebrew extend self module Homebrew
def unlinkapps def unlinkapps
target_dir = ARGV.include?("--local") ? File.expand_path("~/Applications") : "/Applications" target_dir = ARGV.include?("--local") ? File.expand_path("~/Applications") : "/Applications"

View File

@ -2,8 +2,6 @@ require "stringio"
require "formula" require "formula"
module Homebrew module Homebrew
extend self
module DATALoader module DATALoader
# Original code from http://stackoverflow.com/a/2157556/371237 # Original code from http://stackoverflow.com/a/2157556/371237
def self.load(path) def self.load(path)

View File

@ -1,6 +1,6 @@
require 'formula' require 'formula'
module Homebrew extend self module Homebrew
def unpin def unpin
raise FormulaUnspecifiedError if ARGV.named.empty? raise FormulaUnspecifiedError if ARGV.named.empty?

View File

@ -1,6 +1,6 @@
require 'cmd/tap' # for tap_args require 'cmd/tap' # for tap_args
module Homebrew extend self module Homebrew
def untap def untap
raise "Usage is `brew untap <tap-name>`" if ARGV.empty? raise "Usage is `brew untap <tap-name>`" if ARGV.empty?

View File

@ -1,7 +1,7 @@
require 'cmd/tap' require 'cmd/tap'
require 'cmd/untap' require 'cmd/untap'
module Homebrew extend self module Homebrew
def update def update
unless ARGV.named.empty? unless ARGV.named.empty?
abort <<-EOS.undent abort <<-EOS.undent

View File

@ -1,7 +1,7 @@
require 'cmd/install' require 'cmd/install'
require 'cmd/outdated' require 'cmd/outdated'
module Homebrew extend self module Homebrew
def upgrade def upgrade
Homebrew.perform_preinstall_checks Homebrew.perform_preinstall_checks

View File

@ -4,7 +4,7 @@ require 'formula'
# If you want the union, run the command twice and concatenate the results. # If you want the union, run the command twice and concatenate the results.
# The intersection is harder to achieve with shell tools. # The intersection is harder to achieve with shell tools.
module Homebrew extend self module Homebrew
def uses def uses
raise FormulaUnspecifiedError if ARGV.named.empty? raise FormulaUnspecifiedError if ARGV.named.empty?

View File

@ -1,7 +1,7 @@
require "formula" require "formula"
require "formula_versions" require "formula_versions"
module Homebrew extend self module Homebrew
def versions def versions
raise "Please `brew install git` first" unless which "git" raise "Please `brew install git` first" unless which "git"
raise "Please `brew update` first" unless (HOMEBREW_REPOSITORY/".git").directory? raise "Please `brew update` first" unless (HOMEBREW_REPOSITORY/".git").directory?

View File

@ -93,8 +93,9 @@ HOMEBREW_CURL_ARGS = '-f#LA'
require 'tap_constants' require 'tap_constants'
module Homebrew extend self module Homebrew
include FileUtils include FileUtils
extend self
attr_accessor :failed attr_accessor :failed
alias_method :failed?, :failed alias_method :failed?, :failed

View File

@ -65,6 +65,7 @@ end
module Homebrew module Homebrew
include FileUtils include FileUtils
extend self
module VersionAssertions module VersionAssertions
def version v def version v