From 1b15d03634a99c25a99df441831d163e73f3c6ac Mon Sep 17 00:00:00 2001 From: Max Eisner <4730112+max-ae@users.noreply.github.com> Date: Sun, 31 Jul 2022 21:08:42 +0200 Subject: [PATCH] remove always-true condition --- Library/Homebrew/rubocops/lines.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Library/Homebrew/rubocops/lines.rb b/Library/Homebrew/rubocops/lines.rb index 57343bc4bc..c51fbe8b74 100644 --- a/Library/Homebrew/rubocops/lines.rb +++ b/Library/Homebrew/rubocops/lines.rb @@ -452,8 +452,7 @@ module RuboCop replacement_args << "shell_parameter_format: #{shell_parameter_format}" unless shell_parameter_format.nil? offending_node(node) - replacement = "generate_completions_from_executable" - replacement += "(#{replacement_args.join(", ")})" unless replacement_args.blank? + replacement = "generate_completions_from_executable(#{replacement_args.join(", ")})" problem "Use `#{replacement}` instead of `#{@offensive_node.source}`." do |corrector| corrector.replace(@offensive_node.source_range, replacement)