mirrors/brew
1
0
Fork 0
mirror of https://github.com/Homebrew/brew.git synced 2025-07-14 16:09:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1756 from alyssais/nil_dependents

Browse Source 
keg: don't return nil dependencies
This commit is contained in:
Mike McQuaid 2016-12-31 17:34:17 +00:00 committed by GitHub
commit 1c9651f04f
3 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/cmd/uninstall.rb
View File

@ -102,8 +102,8 @@ module Homebrew
attr_reader :reqs, :deps attr_reader :reqs, :deps
def initialize(requireds, dependents) def initialize(requireds, dependents)
@reqs = requireds.compact @reqs = requireds
@deps = dependents.compact @deps = dependents
end end
protected protected

2
Library/Homebrew/keg.rb
View File

@ -136,7 +136,7 @@ class Keg
next unless f_kegs next unless f_kegs
f_kegs.sort_by(&:version).last f_kegs.sort_by(&:version).last
end end.compact
next unless required_kegs.any? next unless required_kegs.any?

13
Library/Homebrew/test/keg_test.rb
View File

@ -369,6 +369,19 @@ class InstalledDependantsTests < LinkTestCase
assert_equal [[@keg], ["bar 1.0"]], Keg.find_some_installed_dependents([@keg]) assert_equal [[@keg], ["bar 1.0"]], Keg.find_some_installed_dependents([@keg])
end end
def test_a_dependency_with_no_tap_in_tab
@tap_dep = setup_test_keg("baz", "1.0")
alter_tab(@keg) { |t| t.source["tap"] = nil }
dependencies nil
Formula["bar"].class.depends_on "foo"
Formula["bar"].class.depends_on "baz"
result = Keg.find_some_installed_dependents([@keg, @tap_dep])
assert_equal [[@tap_dep], ["bar"]], result
end
def test_no_dependencies_anywhere def test_no_dependencies_anywhere
dependencies nil dependencies nil
assert_empty @keg.installed_dependents assert_empty @keg.installed_dependents