mirrors/brew
1
0
Fork 0
mirror of https://github.com/Homebrew/brew.git synced 2025-07-14 16:09:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

Optimize CoreTap in .deleted_reason

Browse Source 
This limits the previous change to only the
core tap in `MissingFormula.deleted_reason`.

The reason for this is that the `git log` command
only becomes a performance issue when the number
of monthly commits is high which really only happens
with the core tap.
This commit is contained in:
apainintheneck 2022-11-11 23:54:27 -08:00
parent 5241439f43
commit 2bc54e56e4
1 changed files with 22 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
Library/Homebrew/missing_formula.rb
View File

@ -154,25 +154,36 @@ module Homebrew
end
end
# The core tap has thousands of monthly commits making the `git log`
# command below a performance issue when using `brew search` or
# `brew info` to look for a formula that doesn't exist. This first
# checks if the formula existed a month ago before continuing.
if tap.is_a? CoreTap
commit_command = "git log --before='1 month ago' --max-count=1 --format=%H"
month_old_commit = Utils.popen_read(commit_command).chomp
month_old_commit_hash = Utils.popen_read(commit_command).chomp
# Check if the formula has been deleted in the last month
# by comparing the diff between now and a month ago.
diff_command = "git diff --diff-filter=D --name-only " \
"#{month_old_commit} HEAD -- #{relative_path}"
"#{month_old_commit_hash} HEAD -- #{relative_path}"
if Utils.popen_read(diff_command).blank?
ofail "No previously deleted formula found." unless silent
return
end
end
log_command = "git log --since='1 month ago' --diff-filter=D " \
"--name-only --max-count=1 " \
"--format=%h\\\\n%B -- #{relative_path}"
short_hash, *commit_message, relative_path =
"--format=%H\\\\n%h\\\\n%B -- #{relative_path}"
hash, short_hash, *commit_message, relative_path =
Utils.popen_read(log_command).gsub("\\n", "\n").lines.map(&:chomp)
if hash.blank? || short_hash.blank? || relative_path.blank?
ofail "No previously deleted formula found." unless silent
return
end
commit_message = commit_message.reject(&:empty?).join("\n ")
commit_message.sub!(/ \(#(\d+)\)$/, " (#{tap.issues_url}/\\1)")