mirrors/brew
1
0
Fork 0
mirror of https://github.com/Homebrew/brew.git synced 2025-07-14 16:09:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

style: clarify GitHub .git error message

Browse Source
This commit is contained in:
Dustin Rodrigues 2020-08-05 01:00:36 -04:00
parent e76cea16b1
commit 5157c08327
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/rubocops/homepage.rb
View File

@ -64,7 +64,7 @@ module RuboCop
when %r{^https://github.com.*\.git} when %r{^https://github.com.*\.git}
offending_node(parameters(homepage_node).first) offending_node(parameters(homepage_node).first)
problem "GitHub URLs (`#{homepage}`) should not end with .git" problem "GitHub homepages (`#{homepage}`) should not end with .git"
# There's an auto-redirect here, but this mistake is incredibly common too. # There's an auto-redirect here, but this mistake is incredibly common too.
# Only applies to the homepage and subdomains for now, not the FTP URLs. # Only applies to the homepage and subdomains for now, not the FTP URLs.

2
Library/Homebrew/test/rubocops/homepage_spec.rb
View File

@ -104,7 +104,7 @@ describe RuboCop::Cop::FormulaAudit::Homepage do
column: 2, column: 2,
source: source }] source: source }]
elsif homepage.match?("https://github.com/foo/bar.git") elsif homepage.match?("https://github.com/foo/bar.git")
expected_offenses = [{ message: "GitHub URLs (`#{homepage}`) should not end with .git", expected_offenses = [{ message: "GitHub homepages (`#{homepage}`) should not end with .git",
severity: :convention, severity: :convention,
line: 2, line: 2,
column: 11, column: 11,