mirrors/brew
1
0
Fork 0
mirror of https://github.com/Homebrew/brew.git synced 2025-07-14 16:09:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use URI.encode_www_form instead of CGI.escape.

Browse Source
This commit is contained in:
Markus Reiter 2018-08-02 15:41:44 +02:00
parent 7f4ea02047
commit 64bb92d95d
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Library/Homebrew/download_strategy.rb
View File

@ -1,4 +1,3 @@
require "cgi"
require "json" require "json"
require "rexml/document" require "rexml/document"
require "time" require "time"
@ -268,7 +267,7 @@ class CurlDownloadStrategy < AbstractFileDownloadStrategy
args = [] args = []
if meta.key?(:cookies) if meta.key?(:cookies)
escape_cookie = ->(k, v) { "#{CGI.escape(k.to_s)}=#{CGI.escape(v.to_s)}" } escape_cookie = ->(cookie) { URI.encode_www_form([cookie]) }
args += ["-b", meta.fetch(:cookies).map(&escape_cookie).join(";")] args += ["-b", meta.fetch(:cookies).map(&escape_cookie).join(";")]
end end
@ -343,7 +342,7 @@ end
class CurlPostDownloadStrategy < CurlDownloadStrategy class CurlPostDownloadStrategy < CurlDownloadStrategy
def _fetch def _fetch
base_url, data = if meta.key?(:data) base_url, data = if meta.key?(:data)
escape_data = ->(k, v) { ["-d", "#{CGI.escape(k.to_s)}=#{CGI.escape(v.to_s)}"] } escape_data = ->(d) { ["-d", URI.encode_www_form([d])] }
[@url, meta[:data].flat_map(&escape_data)] [@url, meta[:data].flat_map(&escape_data)]
else else
@url.split("?", 2) @url.split("?", 2)