mirrors/brew
1
0
Fork 0
mirror of https://github.com/Homebrew/brew.git synced 2025-07-14 16:09:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

Check that a single uninstall_* and zap stanzas is defined

Browse Source
This commit is contained in:
L. E. Segovia 2017-10-27 16:53:22 -03:00
parent 7caca57073
commit 809e820388
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
Library/Homebrew/cask/lib/hbc/audit.rb
View File

@ -31,6 +31,7 @@ module Hbc
check_generic_artifacts check_generic_artifacts
check_token_conflicts check_token_conflicts
check_download check_download
check_single_uninstall_zap
self self
rescue StandardError => e rescue StandardError => e
odebug "#{e.message}\n#{e.backtrace.join("\n")}" odebug "#{e.message}\n#{e.backtrace.join("\n")}"
@ -48,6 +49,22 @@ module Hbc
private private
def check_single_uninstall_zap
odebug "Auditing single uninstall_* and zap stanzas"
uninstalls = cask.artifacts.find_all { |k| k.is_a?(Hbc::Artifact::Uninstall) }
add_warning "there should be a single uninstall stanza" unless uninstalls.size <= 1
uninstalls_preflight = cask.artifacts.find_all { |k| k.is_a?(Hbc::Artifact::PreflightBlock) && k.directives.keys.include?("uninstall_preflight") }
add_warning "there should be a single uninstall_preflight stanza" unless uninstalls_preflight.size <= 1
uninstalls_postflight = cask.artifacts.find_all { |k| k.is_a?(Hbc::Artifact::PostflightBlock) && k.directives.keys.include?("uninstall_postflight") }
add_warning "there should be a single uninstall_postflight stanza" unless uninstalls_postflight.size <= 1
zaps = cask.artifacts.find_all { |k| k.is_a?(Hbc::Artifact::Zap) }
add_warning "there should be a single zap stanza" unless zaps.size <= 1
end
def check_required_stanzas def check_required_stanzas
odebug "Auditing required stanzas" odebug "Auditing required stanzas"
[:version, :sha256, :url, :homepage].each do |sym| [:version, :sha256, :url, :homepage].each do |sym|