mirrors/brew
1
0
Fork 0
mirror of https://github.com/Homebrew/brew.git synced 2025-07-14 16:09:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

rubocops/urls: stricter binary URL requirements.

Browse Source 
Don't rely on x86_64 detection but instead whitelist the few projects
that fun afoul of these regex.
This commit is contained in:
Mike McQuaid 2020-04-02 09:32:52 +01:00
parent 2b3d7304e4
commit 9da6c9b521
No known key found for this signature in database
GPG Key ID: 48A898132FD8EE70
1 changed files with 23 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
Library/Homebrew/rubocops/urls.rb
View File

@ -7,8 +7,21 @@ module RuboCop
module FormulaAudit module FormulaAudit
# This cop audits URLs and mirrors in Formulae. # This cop audits URLs and mirrors in Formulae.
class Urls < FormulaCop class Urls < FormulaCop
# These are parts of URLs that look like binaries but actually aren't.
NOT_A_BINARY_URL_PREFIX_WHITELIST = %w[
https://github.com/obihann/archey-osx/archive/
https://downloads.sourceforge.net/project/astyle/astyle/
https://downloads.sourceforge.net/project/bittwist/
https://downloads.sourceforge.net/project/launch4j/
https://osxbook.com/book/bonus/chapter8/core/download/gcore
https://github.com/ChrisJohnsen/tmux-MacOSX-pasteboard/archive/
https://raw.githubusercontent.com/liyanage/macosx-shell-scripts/
https://github.com/sindresorhus/macos-wallpaper/archive/
].freeze
# These are formulae that, sadly, require an upstream binary to bootstrap. # These are formulae that, sadly, require an upstream binary to bootstrap.
BINARY_FORMULA_URLS_WHITELIST = %w[ BINARY_BOOTSTRAP_FORMULA_URLS_WHITELIST = %w[
clozure-cl
crystal crystal
fpc fpc
ghc ghc
@ -22,6 +35,10 @@ module RuboCop
haskell-stack haskell-stack
ldc ldc
mlton mlton
openjdk
openjdk@11
pypy
sbcl
rust rust
].freeze ].freeze
@ -234,9 +251,11 @@ module RuboCop
return if formula_tap != "homebrew-core" return if formula_tap != "homebrew-core"
# Check for binary URLs # Check for binary URLs
audit_urls(urls, /(darwin|macos|osx)/i) do |_, url| audit_urls(urls, /(darwin|macos|osx)/i) do |match, url|
next if url !~ /x86_64/i && url !~ /amd64/i next if @formula_name.include?(match.to_s.downcase)
next if BINARY_FORMULA_URLS_WHITELIST.include?(@formula_name) next if url.match?(/.(patch|diff)(\?full_index=1)?$/)
next if NOT_A_BINARY_URL_PREFIX_WHITELIST.any? { |prefix| url.start_with?(prefix) }
next if BINARY_BOOTSTRAP_FORMULA_URLS_WHITELIST.include?(@formula_name)
problem "#{url} looks like a binary package, not a source archive; " \ problem "#{url} looks like a binary package, not a source archive; " \
"homebrew/core is source-only." "homebrew/core is source-only."