mirror of
https://github.com/Homebrew/brew.git
synced 2025-07-14 16:09:03 +08:00
Make comment more explicit
This commit is contained in:
parent
883c1e9907
commit
9fff688bbe
@ -119,14 +119,14 @@ module Homebrew
|
|||||||
url_sha256 = Digest::SHA256.hexdigest(bottle.url)
|
url_sha256 = Digest::SHA256.hexdigest(bottle.url)
|
||||||
subject = "#{url_sha256}--#{bottle.filename}"
|
subject = "#{url_sha256}--#{bottle.filename}"
|
||||||
|
|
||||||
# We don't pass in a signing worfklow for backfill signatures because
|
# We don't pass in a signing workflow for backfill signatures because
|
||||||
# some backfilled bottle signatures were signed from a branch, and others
|
# some backfilled bottle signatures were signed from the 'backfill'
|
||||||
# from main, so the signing workflow is slightly different which causes
|
# branch, and others from 'main', so the signing workflow is slightly
|
||||||
# some bottles to incorrectly fail when checking their attestation.
|
# different which causes some bottles to incorrectly fail when checking
|
||||||
# This shouldn't meaningfully affect security because if somehow someone
|
# their attestation. This shouldn't meaningfully affect security
|
||||||
# could generate false backfill attestations from a different workflow
|
# because if somehow someone could generate false backfill attestations
|
||||||
# we will still catch it because the attestation would have been
|
# from a different workflow we will still catch it because the
|
||||||
# generated after our cutoff date.
|
# attestation would have been generated after our cutoff date.
|
||||||
backfill_attestation = check_attestation bottle, BACKFILL_REPO, nil, subject
|
backfill_attestation = check_attestation bottle, BACKFILL_REPO, nil, subject
|
||||||
timestamp = backfill_attestation.dig("verificationResult", "verifiedTimestamps",
|
timestamp = backfill_attestation.dig("verificationResult", "verifiedTimestamps",
|
||||||
0, "timestamp")
|
0, "timestamp")
|
||||||
|
Loading…
x
Reference in New Issue
Block a user