mirrors/brew
1
0
Fork 0
mirror of https://github.com/Homebrew/brew.git synced 2025-07-14 16:09:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

rubocop: Drop "d" from Naming/MethodParameterName allowlist

Browse Source
This commit is contained in:
Issy Long 2023-03-08 00:27:19 +00:00
parent e273c25be0
commit a3211f4d7f
No known key found for this signature in database
GPG Key ID: 8247C390DADC67D4
3 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/.rubocop.yml
View File

@ -183,7 +183,6 @@ Naming/MethodName:
- '\A(fetch_)?HEAD\?\Z' - '\A(fetch_)?HEAD\?\Z'
# allow those that are standard # allow those that are standard
# TODO: try to remove some of these
Naming/MethodParameterName: Naming/MethodParameterName:
inherit_mode: inherit_mode:
merge: merge:
@ -194,7 +193,6 @@ Naming/MethodParameterName:
"b", "b",
"c1", "c1",
"c2", "c2",
"d",
"e", "e",
"f", "f",
"ff", "ff",

4
Library/Homebrew/cleaner.rb
View File

@ -117,8 +117,8 @@ class Cleaner
# #
# lib may have a large directory tree (see Erlang for instance), and # lib may have a large directory tree (see Erlang for instance), and
# clean_dir applies cleaning rules to the entire tree # clean_dir applies cleaning rules to the entire tree
def clean_dir(d) def clean_dir(directory)
d.find do |path| directory.find do |path|
path.extend(ObserverPathnameExtension) path.extend(ObserverPathnameExtension)
Find.prune if @f.skip_clean? path Find.prune if @f.skip_clean? path

12
Library/Homebrew/cmd/deps.rb
View File

@ -196,17 +196,17 @@ module Homebrew
str str
end end
def self.deps_for_dependent(d, args:, recursive: false) def self.deps_for_dependent(dependency, args:, recursive: false)
includes, ignores = args_includes_ignores(args) includes, ignores = args_includes_ignores(args)
deps = d.runtime_dependencies if @use_runtime_dependencies deps = dependency.runtime_dependencies if @use_runtime_dependencies
if recursive if recursive
deps ||= recursive_includes(Dependency, d, includes, ignores) deps ||= recursive_includes(Dependency, dependency, includes, ignores)
reqs = recursive_includes(Requirement, d, includes, ignores) reqs = recursive_includes(Requirement, dependency, includes, ignores)
else else
deps ||= reject_ignores(d.deps, ignores, includes) deps ||= reject_ignores(dependency.deps, ignores, includes)
reqs = reject_ignores(d.requirements, ignores, includes) reqs = reject_ignores(dependency.requirements, ignores, includes)
end end
deps + reqs.to_a deps + reqs.to_a