From a85ad91b43e33f9fcef1ec77a0e98dd574ebcd03 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Wed, 17 Feb 2021 17:53:10 +0000 Subject: [PATCH] dev-cmd/sponsors: tweak code. - add named constants - change an unless to if --- Library/Homebrew/dev-cmd/sponsors.rb | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/dev-cmd/sponsors.rb b/Library/Homebrew/dev-cmd/sponsors.rb index 934ba0744e..bf2b9e504f 100644 --- a/Library/Homebrew/dev-cmd/sponsors.rb +++ b/Library/Homebrew/dev-cmd/sponsors.rb @@ -9,6 +9,9 @@ module Homebrew module_function + NAMED_TIER_AMOUNT = 100 + URL_TIER_AMOUNT = 1000 + sig { returns(CLI::Parser) } def sponsors_args Homebrew::CLI::Parser.new do @@ -39,13 +42,13 @@ module Homebrew logo_sponsors = [] GitHub.sponsors_by_tier("Homebrew").each do |tier| - if tier["tier"] >= 100 + if tier["tier"] >= NAMED_TIER_AMOUNT named_sponsors += tier["sponsors"].map do |s| "[#{sponsor_name(s)}](#{sponsor_url(s)})" end end - next unless tier["tier"] >= 1000 + next if tier["tier"] < URL_TIER_AMOUNT logo_sponsors += tier["sponsors"].map do |s| "[![#{sponsor_name(s)}](#{sponsor_logo(s)})](#{sponsor_url(s)})"