mirrors/brew
1
0
Fork 0
mirror of https://github.com/Homebrew/brew.git synced 2025-07-14 16:09:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

utils/analytics: improve accuracy of GitHub Packages download counts

Browse Source 
`millions_match.captures.first` will typically be a decimal (since it's
matched using `\d+\.\d+`), except we lose accuracy in the `#to_i`
conversion.

Before:
```
❯ brew info --analytics --github-packages-downloads sqlite
==> Analytics
==> install (30 days)
[snip]
==> GitHub Packages Downloads
1,009,898 (30 days)
```

After:

```
❯ brew info --analytics --github-packages-downloads sqlite
==> Analytics
==> install (30 days)
[snip]
==> GitHub Packages Downloads
1,199,898 (30 days)
```

In this case `1.19M` was being rounded down to `1M`.
This commit is contained in:
Carlo Cabrera 2024-08-04 05:33:46 +08:00
parent 822c84784c
commit ab4f14b359
No known key found for this signature in database
GPG Key ID: C74D447FC549A1D0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/utils/analytics.rb
View File

@ -307,7 +307,7 @@ module Utils
last_thirty_days_downloads = last_thirty_days_match.captures.first.tr(",", "") last_thirty_days_downloads = last_thirty_days_match.captures.first.tr(",", "")
thirty_day_download_count += if (millions_match = last_thirty_days_downloads.match(/(\d+\.\d+)M/).presence) thirty_day_download_count += if (millions_match = last_thirty_days_downloads.match(/(\d+\.\d+)M/).presence)
millions_match.captures.first.to_i * 1_000_000 millions_match.captures.first.to_f * 1_000_000
else else
last_thirty_days_downloads.to_i last_thirty_days_downloads.to_i
end end