From add10c64f12d65e7d1950633c991c1c78ca59b27 Mon Sep 17 00:00:00 2001 From: Issy Long Date: Mon, 4 Nov 2019 19:17:44 +0000 Subject: [PATCH] Linux Maintainer Guide: Reflect recent changes to tap commands - We recently changed the name of the Linux commands tap from Linuxbrew/homebrew-developer to Homebrew/homebrew-linux-dev in our continual efforts to move away from the Linuxbrew name. Related to this, we changed the comment produced by `brew build-bottle-pr` to simply "Linux". - We also [changed `brew find-formulae-to-bottle`](https://github.com/Homebrew/homebrew-linux-dev/pull/130) so that it will build a bottle for a formula even if it has a macOS requirement. There were cases like `go` that build perfectly fine on Linux. --- docs/Homebrew-linuxbrew-core-Maintainer-Guide.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/Homebrew-linuxbrew-core-Maintainer-Guide.md b/docs/Homebrew-linuxbrew-core-Maintainer-Guide.md index 6afe59ae39..3dd666a0a2 100644 --- a/docs/Homebrew-linuxbrew-core-Maintainer-Guide.md +++ b/docs/Homebrew-linuxbrew-core-Maintainer-Guide.md @@ -219,7 +219,7 @@ running `git push your-fork master` After merging changes, we must rebuild bottles for all the PRs that had conflicts. -To do this, tap `Linuxbrew/homebrew-developer` and run the following +To do this, tap `Homebrew/homebrew-linux-dev` and run the following command where the merge commit is `HEAD`: ```sh @@ -235,7 +235,6 @@ against the formulae: And it skips formulae if any of the following are true: - it doesn't need a bottle - it already has a bottle -- the formula depends on macOS to build - the formula's tap is Homebrew/homebrew-core (the upstream macOS repo) - there is already an open PR for the formula's bottle - the current branch is not master @@ -246,7 +245,7 @@ run `brew find-formulae-to-bottle --verbose` separate to the `for` loop above. The `build-bottle-pr` script creates a branch called `bottle-`, adds `# Build a bottle -for Linuxbrew` to the top of the formula, pushes the branch to GitHub +for Linux` to the top of the formula, pushes the branch to GitHub at the specified remote (default: `origin`), and opens a pull request using `hub pull-request`.