formula_creator: keep std_configure_args

Match `homebrew-core` preferences where we usually keep
`std_configure_args` even if some args are unrecognized and
where we pass any additional args before `std_configure_args`.
This commit is contained in:
Michael Cho 2023-12-28 15:55:22 -05:00
parent e794b99ea5
commit b62c77e8da
No known key found for this signature in database
GPG Key ID: 55E85E28A7CD1E85

View File

@ -167,9 +167,9 @@ module Homebrew
system "cmake", "--build", "build" system "cmake", "--build", "build"
system "cmake", "--install", "build" system "cmake", "--install", "build"
<% elsif @mode == :autotools %> <% elsif @mode == :autotools %>
# Remove unrecognized options if warned by configure # Remove unrecognized options if they cause configure to fail
# https://rubydoc.brew.sh/Formula.html#std_configure_args-instance_method # https://rubydoc.brew.sh/Formula.html#std_configure_args-instance_method
system "./configure", *std_configure_args, "--disable-silent-rules" system "./configure", "--disable-silent-rules", *std_configure_args
system "make", "install" # if this fails, try separate make/make install steps system "make", "install" # if this fails, try separate make/make install steps
<% elsif @mode == :crystal %> <% elsif @mode == :crystal %>
system "shards", "build", "--release" system "shards", "build", "--release"
@ -214,9 +214,9 @@ module Homebrew
<% elsif @mode == :rust %> <% elsif @mode == :rust %>
system "cargo", "install", *std_cargo_args system "cargo", "install", *std_cargo_args
<% else %> <% else %>
# Remove unrecognized options if warned by configure # Remove unrecognized options if they cause configure to fail
# https://rubydoc.brew.sh/Formula.html#std_configure_args-instance_method # https://rubydoc.brew.sh/Formula.html#std_configure_args-instance_method
system "./configure", *std_configure_args, "--disable-silent-rules" system "./configure", "--disable-silent-rules", *std_configure_args
# system "cmake", "-S", ".", "-B", "build", *std_cmake_args # system "cmake", "-S", ".", "-B", "build", *std_cmake_args
<% end %> <% end %>
end end