style: use Homebrew shellcheck if installed

This commit is contained in:
Rylan Polster 2021-01-01 03:26:08 -05:00
parent 65df4efd1a
commit bcac46bccb

View File

@ -162,12 +162,13 @@ module Homebrew
end end
def run_shellcheck(files, output_type) def run_shellcheck(files, output_type)
shellcheck = which("shellcheck") shellcheck = Formula["shellcheck"].opt_bin/"shellcheck" if Formula["shellcheck"].any_version_installed?
shellcheck ||= which("shellcheck")
shellcheck ||= which("shellcheck", ENV["HOMEBREW_PATH"]) shellcheck ||= which("shellcheck", ENV["HOMEBREW_PATH"])
shellcheck ||= begin shellcheck ||= begin
ohai "Installing `shellcheck` for shell style checks..." ohai "Installing `shellcheck` for shell style checks..."
safe_system HOMEBREW_BREW_FILE, "install", "shellcheck" safe_system HOMEBREW_BREW_FILE, "install", "shellcheck"
which("shellcheck") || which("shellcheck", ENV["HOMEBREW_PATH"]) Formula["shellcheck"].opt_bin/"shellcheck"
end end
if files.empty? if files.empty?