Tap#issues_url added

Closes Homebrew/homebrew#47454.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
This commit is contained in:
Baptiste Fontaine 2015-12-28 13:23:22 +01:00
parent 4b2eb86bbf
commit c15c9dbaf3
3 changed files with 28 additions and 2 deletions

View File

@ -235,8 +235,10 @@ class BuildError < RuntimeError
puts "#{formula} was moved to homebrew-boneyard because it has unfixable issues." puts "#{formula} was moved to homebrew-boneyard because it has unfixable issues."
puts "Please do not file any issues about this. Sorry!" puts "Please do not file any issues about this. Sorry!"
else else
if issues_url = formula.tap.issues_url
puts "If reporting this issue please do so at (not Homebrew/homebrew):" puts "If reporting this issue please do so at (not Homebrew/homebrew):"
puts " https://github.com/#{formula.tap}/issues" puts " #{issues_url}"
end
end end
end end
else else

View File

@ -82,6 +82,14 @@ class Tap
(path/".git").exist? (path/".git").exist?
end end
# The issues URL of this {Tap}.
# e.g. `https://github.com/user/homebrew-repo/issues`
def issues_url
if official? || !custom_remote?
"https://github.com/#{user}/homebrew-#{repo}/issues"
end
end
def to_s def to_s
name name
end end

View File

@ -67,6 +67,22 @@ class TapTest < Homebrew::TestCase
refute_predicate @tap, :core_formula_repository? refute_predicate @tap, :core_formula_repository?
end end
def test_issues_url
t = Tap.new("someone", "foo")
path = Tap::TAP_DIRECTORY/"someone/homebrew-foo"
path.mkpath
FileUtils.cd path do
shutup { system "git", "init" }
system "git", "remote", "add", "origin",
"https://github.com/someone/homebrew-foo"
end
assert_equal "https://github.com/someone/homebrew-foo/issues", t.issues_url
assert_equal "https://github.com/Homebrew/homebrew-foo/issues", @tap.issues_url
(Tap::TAP_DIRECTORY/"someone/homebrew-no-git").mkpath
assert_nil Tap.new("someone", "no-git").issues_url
end
def test_files def test_files
setup_tap_files setup_tap_files