mirrors/brew
1
0
Fork 0
mirror of https://github.com/Homebrew/brew.git synced 2025-07-14 16:09:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

Audit invalid versions

Browse Source 
We have a bunch of versions we've been meaning to adjust to not use
invalid GitHub Packages characters for a while. Let's audit for them
and plan for deprecating their use in future.
This commit is contained in:
Mike McQuaid 2023-09-01 19:41:53 +01:00
parent e93d56008d
commit de4207f6d0
No known key found for this signature in database
GPG Key ID: 3338A31AFDB1D829
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Library/Homebrew/github_packages.rb
View File

@ -20,6 +20,11 @@ class GitHubPackages
URL_REGEX = %r{(?:#{Regexp.escape(URL_PREFIX)}|#{Regexp.escape(DOCKER_PREFIX)})([\w-]+)/([\w-]+)}.freeze URL_REGEX = %r{(?:#{Regexp.escape(URL_PREFIX)}|#{Regexp.escape(DOCKER_PREFIX)})([\w-]+)/([\w-]+)}.freeze
# Valid OCI tag characters
# https://github.com/opencontainers/distribution-spec/blob/main/spec.md#workflow-categories
VALID_OCI_TAG_REGEX = /^[a-zA-Z0-9_][a-zA-Z0-9._-]{0,127}$/.freeze
INVALID_OCI_TAG_CHARS_REGEX = /[^a-zA-Z0-9._-]/.freeze
GZIP_BUFFER_SIZE = 64 * 1024 GZIP_BUFFER_SIZE = 64 * 1024
private_constant :GZIP_BUFFER_SIZE private_constant :GZIP_BUFFER_SIZE
@ -117,10 +122,11 @@ class GitHubPackages
end end
def self.image_version_rebuild(version_rebuild) def self.image_version_rebuild(version_rebuild)
# invalid docker tag characters return version_rebuild if version_rebuild.match?(VALID_OCI_TAG_REGEX)
# TODO: consider changing the actual versions here and make an audit to
# avoid these weird characters being used # odeprecated "GitHub Packages versions that do not match #{VALID_OCI_TAG_REGEX.source}",
version_rebuild.gsub(/[+#~]/, ".") # "declaring a new `version` without these characters"
version_rebuild.gsub(INVALID_OCI_TAG_CHARS_REGEX, ".")
end end
private private

2
Library/Homebrew/resource_auditor.rb
View File

@ -46,6 +46,8 @@ module Homebrew
def audit_version def audit_version
if version.nil? if version.nil?
problem "missing version" problem "missing version"
elsif owner.is_a?(Formula) && !version.to_s.match?(GitHubPackages::VALID_OCI_TAG_REGEX)
problem "version #{version} does not match #{GitHubPackages::VALID_OCI_TAG_REGEX.source}"
elsif !version.detected_from_url? elsif !version.detected_from_url?
version_text = version version_text = version
version_url = Version.detect(url, **specs) version_url = Version.detect(url, **specs)