"A few small nits" from code review

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
This commit is contained in:
Issy Long 2023-04-30 19:06:07 +01:00 committed by GitHub
parent 40f697e96e
commit e739a5c076
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -843,8 +843,9 @@ module Homebrew
end end
def check_for_unnecessary_core_tap def check_for_unnecessary_core_tap
return if ENV["HOMEBREW_DEVELOPER"] return if Homebrew::EnvConfig.developer?
return if ENV["HOMEBREW_NO_INSTALL_FROM_API"] return if Homebrew::EnvConfig.no_install_from_api?
return if Homebrew::Settings.read("devcmdrun") == "true"
return unless CoreTap.instance.installed? return unless CoreTap.instance.installed?
<<~EOS <<~EOS
@ -856,9 +857,11 @@ module Homebrew
end end
def check_for_unnecessary_cask_tap def check_for_unnecessary_cask_tap
return if ENV["HOMEBREW_DEVELOPER"] return if Homebrew::EnvConfig.developer?
return if ENV["HOMEBREW_NO_INSTALL_FROM_API"] return if Homebrew::EnvConfig.no_install_from_api?
return unless (cask_tap = Tap.fetch("homebrew", "cask")).installed? return if Homebrew::Settings.read("devcmdrun") == "true"
cask_tap = Tap.fetch("homebrew", "cask")
return unless cask_tap.installed?
<<~EOS <<~EOS
You have an unnecessary local Cask tap. You have an unnecessary local Cask tap.