10270 Commits

Author SHA1 Message Date
Baptiste Fontaine
bfa19b3385 audit: Escape interpolated string in regexp
This avoids issues with names containing special characters like e.g. [

Fixes #1431
2016-11-03 18:17:11 +01:00
Mike McQuaid
09f438aecc Merge pull request #1429 from mandarg/fix-few-typos
Correct a few typos
2016-11-03 09:00:20 -04:00
Mike McQuaid
018669084e Merge pull request #1427 from MikeMcQuaid/rubocop-exclude-more-taps
rubocop: exclude more tap dirs from hash rockets.
2016-11-03 08:55:45 -04:00
Mandar Gokhale
0e15ffff62 Correct a few typos
...and update man pages where applicable
2016-11-03 12:09:44 +00:00
Mike McQuaid
2a865f085e Merge pull request #1424 from MikeMcQuaid/audit-more-test-system
audit: check more unscoped test calls.
2016-11-02 21:50:54 -04:00
Mike McQuaid
f796fe794d rubocop: exclude more tap dirs from hash rockets.
This is useful for e.g. homebrew/bundle that doesn't live in just
`cmd`.
2016-11-02 21:49:05 -04:00
Steven Peters
72f889fef0 audit: restore check that was lost in #927
This audit check ensures that certain build dependencies
are explicitly marked either as `:build` or `:run`.
It seems to have been lost in #927.
It was also adjusted in #1290.
2016-11-02 16:52:09 -07:00
Mike McQuaid
f35a86ff70 audit: stricter test system calls check.
Ensure that the name is suffixed with whitespace or quotes.
2016-11-02 15:57:19 -04:00
Mike McQuaid
7aa26f7817 audit: check more unscoped test calls.
Also check `def test`, `shell_output`, `pipe_output` and method calls
using parentheses.
2016-11-02 13:23:38 -04:00
Mike McQuaid
89fd34b24e Merge pull request #1368 from MikeMcQuaid/build-options-file
build: write options to file.
2016-11-02 12:01:06 -04:00
Mike McQuaid
b3ef8bd044 Merge pull request #1369 from MikeMcQuaid/boneyard-reason
boneyard-formula-pr: add reason argument.
2016-11-02 12:00:33 -04:00
Mike McQuaid
dc47fb3364 Merge pull request #1370 from MikeMcQuaid/better-github-scopes
Improve GitHub API scopes output.
2016-11-02 12:00:27 -04:00
Mike McQuaid
134b650151 Merge pull request #1411 from MikeMcQuaid/audit-check-version-no-decrease
audit: check the stable version does not decrease.
2016-11-02 12:00:05 -04:00
ilovezfs
2c43649ffc superenv: prune -Wl,-z,defs when refurbishing
`-Wl,-z,defs` should be pruned out entirely since `-z defs` is not
understood by macOS's `ld`, and the analogue `-undefined error` is
already the default.
2016-11-02 01:21:15 -07:00
Josh Hagins
e57d312ad1 keg_relocate: don't forget the hard links 2016-11-01 12:58:38 -04:00
Josh Hagins
d60020f1a9 keg_relocate: fix ordering of replacements 2016-11-01 12:07:14 -04:00
Mike McQuaid
3396d479d2 build: write options to file.
These can be useful for later inspection or upload by `gist-logs` if
there's a failed install and it's unclear from logs alone what options
were used.
2016-10-30 16:14:51 -04:00
Mike McQuaid
9f382bfd53 boneyard-formula-pr: add reason argument.
Used to provide a user-facing reason why this formula was boneyarded.
2016-10-30 15:40:11 -04:00
Mike McQuaid
3c7446f3ff Improve GitHub API scopes output.
Improve the GitHub API scope and token related messaging by
autopopulating the scopes we need on the new scopes page and, in the
case of a lacking a scope we need, output what scope was required.

Also, DRY up the personal access token code.
2016-10-30 15:38:19 -04:00
Baptiste Fontaine
127461d879 audit: don't check new formulae revision/versions. 2016-10-30 13:51:23 -04:00
Mike McQuaid
ef58225749 audit: check the version does not decrease.
This will prevent brew upgrade from working correctly.
2016-10-30 13:51:21 -04:00
Mike McQuaid
8d5df2ea87 Merge pull request #1402 from MikeMcQuaid/audit-system-test
audit: check test system calls are fully scoped.
2016-10-30 13:30:03 -04:00
Mike McQuaid
20c8c5958e Merge pull request #1367 from MikeMcQuaid/audit-check-master-branch
audit: check for master branch tar/zipballs.
2016-10-30 13:29:47 -04:00
ilovezfs
90e5de9115 Merge pull request #1395 from ilovezfs/superenv-mark-timingsafe_bcmp-weak-on-10.11
superenv: treat timingsafe_bcmp as weak on 10.11
2016-10-30 10:21:18 -07:00
Mike McQuaid
a093c62b16 Revert "audit: check the version does not decrease." 2016-10-30 07:32:20 -04:00
Markus Reiter
5e44184b35 Merge pull request #1400 from reitermarkus/move-bundle-path
Move `test/vendor/bundle` to `vendor/bundle`.
2016-10-30 01:41:10 +02:00
Mike McQuaid
0bd0fec6a6 audit: check test system calls are fully scoped.
This doesn't matter for everything but it does for the binaries that
are installed. Have a limited name/alias check when not installed and
a better one that iterates bin/sbin if installed.
2016-10-29 17:53:05 -04:00
Mike McQuaid
337810bf3e audit: check for master branch tar/zipballs.
These have unstable checksums and aren't the tagged, stable releases
we require.
2016-10-29 17:52:13 -04:00
Mike McQuaid
9ab38dd751 Merge pull request #1366 from MikeMcQuaid/audit-check-version-decrease
audit: check the version does not decrease.
2016-10-29 17:50:41 -04:00
Markus Reiter
f863d61374 Move vendor/bundle up one level to HOMEBREW_LIBRARY_PATH. 2016-10-29 18:28:07 +02:00
ilovezfs
8e874fa333 Merge pull request #1398 from MikeMcQuaid/update-test-new-tag-fix
update-test: fix --to-tag failure on new tag.
2016-10-29 09:05:31 -07:00
Josh Hagins
2605521ca9 Merge pull request #1361 from jawshooah/cask/refactor-auditor
hbc/auditor: refactor and fix bug
2016-10-29 11:40:39 -04:00
Mike McQuaid
59933f5cd9 update-test: fix --to-tag failure on new tag.
Without this updating to a tag will always have the same start commit
and end commit as there's been no updates to `master` since the tag was
created.
2016-10-29 09:09:00 -04:00
ilovezfs
e26750e112 superenv: treat timingsafe_bcmp as weak on 10.11
Xcode 8.1 added timingsafe_bcmp to string.h and libsystem_c.tbd,
and 10.12.1 added it to libsystem_c.dylib, but it is not present in
libsystem_c.dylib on 10.11.6 (15G1108).

It may appear in libsystem_c.dylib in a later 10.11 release or it may
be marked weak on 10.11 in a later Xcode release.

Fixes Homebrew/homebrew-core#6344.
2016-10-29 03:26:52 -07:00
dersvenhesse
70cc7790f6 Updated latest versions since XCode 8.1 release 2016-10-28 23:34:12 +02:00
dersvenhesse
4701eff45f XCode 8.1 is stable 2016-10-27 23:35:52 +02:00
William Woodruff
72b81844ed
Redirect stderr output from git (shim) invocations to /dev/null.
These invocations occur before we can actually automatically install git via
bottle, and as such their output isn't relevant.
2016-10-26 16:33:35 -04:00
Mike McQuaid
84d1661b9a Merge pull request #1365 from MikeMcQuaid/audit-stable-url-beta
audit: check for alpha/beta/rc usage in URLs.
2016-10-25 08:17:40 -04:00
Josh Hagins
030c3a5016 Merge pull request #1375 from zmwangx/fix-bottle-nonexistent-pyc-bug
bottle: fix nonexistent pyc bug
2016-10-25 04:33:26 -04:00
ilovezfs
a4f654fd3f Merge pull request #1376 from jawshooah/fix-relocate-regression
formula_installer: fix regression in #1253
2016-10-25 01:30:01 -07:00
buo
6a406763f3 Open incomplete download in append mode
Open the incomplete download in append mode instead of write mode.
Opening in write mode truncates the existing file, so curl keeps
restarting downloads instead of resuming the incomplete downloads.
2016-10-25 16:46:59 +09:00
Josh Hagins
652c5bc865 formula_installer: fix regression in #1253
Apparently `cellar :any_skip_relocation` doesn't actually mean we
can skip relocation, at least for text files.
2016-10-25 03:41:37 -04:00
Zhiming Wang
dd527bfcdc
bottle: fix nonexistent pyc bug
We were deleting pyc files *after* replace_locations_with_placeholders
and recording changed_files, meaning that some of the recorded files
were to be deleted. The correct order is the opposite.

A sample failed session: https://bot.brew.sh/job/Homebrew%20Core/10080/version=el_capitan/testReport/junit/brew-test-bot/el_capitan/bottle_buku/.
2016-10-25 01:44:40 -04:00
Josh Hagins
fab2cffe5d keg_relocate: wrap relocation locations in struct 2016-10-24 16:21:08 -04:00
Josh Hagins
adc4b1f0c7 keg_relocate: brew style fixes 2016-10-24 16:21:08 -04:00
Josh Hagins
9c519bbdbc keg_relocate: refactor relocate_text_files
Replace relocate_text_files with three methods that clarify intent:
replace_locations_with_placeholders, replace_placeholders_with_locations
and replace_text_in_files, the first two calling the third.
2016-10-24 16:21:08 -04:00
Josh Hagins
5b64fa6fb1 metafiles: convert Metafiles class to module 2016-10-24 16:21:08 -04:00
Josh Hagins
9628a613cf metafiles: use Set.new instead of Array#to_set 2016-10-24 16:21:08 -04:00
Josh Hagins
ce33f593b4 metafiles: convert EXTENSIONS and BASENAMES from Array to Set 2016-10-24 16:21:08 -04:00
Josh Hagins
c46155aba4 keg_relocate: cache files rewritten during brew bottle
`brew bottle` replaces instances of the Homebrew prefix, cellar, and
repository with placeholders in all text files. Cache these files in
INSTALL_RECEIPT.json so that we don't have to check every single text
file for placeholders on install.
2016-10-24 16:21:08 -04:00