Jack Nagel
49a97c280a
Ask the filename object for the prefix
2014-07-18 15:15:12 -05:00
Jack Nagel
1cc3747094
Move bottle URL construction to the bottle object
2014-07-18 15:15:11 -05:00
Jack Nagel
a87d2108ea
Move bottle filename construction to a class
2014-07-18 15:14:57 -05:00
Jack Nagel
28f0e5c4fd
Don't raise when converting the tag to a version fails
2014-07-16 21:11:48 -05:00
Jack Nagel
ab41071d2b
Separate tag matching and checksum lookup
2014-07-16 21:11:48 -05:00
Jack Nagel
005f41c02a
Use [] on the instance rather than the wrapped hash
2014-07-16 18:54:19 -05:00
Jack Nagel
8044c4524b
Rename variable
2014-07-16 18:54:19 -05:00
Jack Nagel
dc3bcf22a3
Mark private methods as private
2014-07-16 18:54:19 -05:00
Jack Nagel
3c366a56d7
Add key? to BottleCollector
2014-07-16 18:54:19 -05:00
Jack Nagel
33eed80ccc
Rename fetch_bottle_for to fetch_checksum_for
2014-07-16 14:52:18 -05:00
Jack Nagel
68326805ae
Implement []= on BottleCollector
2014-07-15 21:55:14 -05:00
Jack Nagel
8a777e65c4
Ensure that all required keys are passed to bottle_filename
2014-07-15 17:05:15 -05:00
Jack Nagel
a3dad588a8
Remove default tag value from bottle_filename
...
We always call this method with an explicit tag.
2014-07-15 17:05:15 -05:00
Jack Nagel
08891e77b6
Remove default value from bottle_url options parameter
...
To construct a URL, we need options to pass to bottle_filename, so this
method should error out if none are given.
2014-07-13 19:29:36 -05:00
Jack Nagel
272cb4db26
Remove default value from bottle_suffix parameter
...
We always call this method with an argument, so we can simplify it.
2014-07-13 19:29:36 -05:00
Jack Nagel
644904736e
Inline method so we don't merge and unpack options twice
2014-07-13 19:29:36 -05:00
Jack Nagel
0323226256
Inline method that just wraps a constant
2014-07-13 18:41:14 -05:00
Jack Nagel
2bbc98694a
Simplify early return condition
...
Improvements to formula/bottle integration means we can be less
defensive here.
2014-07-12 23:13:32 -05:00
Jack Nagel
2932bc5347
Remove unused parameter
2014-04-01 16:03:08 -05:00
Jack Nagel
7b6fa8b7bb
Inline install_bottle? logic into the installer
2014-03-10 14:56:02 -05:00
Jack Nagel
32ab18c189
Wrap cellar compatibility check in a method
2014-03-10 14:56:02 -05:00
Jack Nagel
4b80d30bab
Remove used options check from install_bottle?
...
This is now handled by requiring that options are always passed to the
installer explicitly.
2014-03-10 14:56:02 -05:00
Jack Nagel
7da459874f
Make bottle implementation more generic
2014-03-10 14:56:02 -05:00
Jack Nagel
a911dd5066
Make build_from_source an explicit installer mode
2014-03-10 14:56:02 -05:00
Jack Nagel
44dc21ca5d
Prepare bottle tooling for formula revisions
2014-03-05 20:45:44 -06:00
Jack Nagel
7e8c693218
Consolidate bottle defaults and remove a method
2014-03-05 10:24:33 -06:00
Jack Nagel
b45cadd19a
bottles: fix options hashes
...
Defaults can't be specified in the parameter list, as they will be
overwritten by whatever is passed in. Instead the defaults must be
merged with the argument in the method body.
2013-12-08 16:41:35 -06:00
Misty De Meo
492ce9cc5e
bottle_filename: remove unused revision default
2013-12-05 23:08:04 -08:00
Misty De Meo
2c175a9d7d
Bottles: fix bottle_filename revision
...
Fixes Homebrew/homebrew#24981 .
2013-12-05 23:06:50 -08:00
Misty De Meo
e2af1cbeeb
Use BottleCollector in Bottle SoftwareSpec
2013-12-05 18:24:51 -08:00
Misty De Meo
079d0556ad
Add BottleCollector
...
The BottleCollector collects bottle tags and sha1s, and allows tags
to be fetched using more advanced logic than just fetching identical
tags.
Closes Homebrew/homebrew#23434 .
2013-12-05 18:24:45 -08:00
Jack Nagel
4d8e023b7f
Revert "Disable bottles when HOMEBREW_CELLAR.parent != HOMEBREW_PREFIX"
...
This reverts commit fdf20dc43971b728520d518f3b6ef0bcb16aeb21.
Closes Homebrew/homebrew#24831 .
Closes Homebrew/homebrew#24780 .
2013-12-01 17:06:56 -06:00
Jack Nagel
2b8e0c8f79
Disable bottles when HOMEBREW_CELLAR.parent != HOMEBREW_PREFIX
2013-11-30 16:44:14 -06:00
Jack Nagel
5a9356a204
Revert "disable :any bottles due to Homebrew/homebrew#24780"
...
This reverts commit 31bab6e52b7ed8c63421b9c647d0592af2ee2635.
2013-11-30 16:35:58 -06:00
Adam Vandenberg
9d72738c54
disable :any bottles due to Homebrew/homebrew#24780
2013-11-30 10:47:46 -08:00
Mike McQuaid
b427314c90
bottles: support mavericks.
...
Closes Homebrew/homebrew#23447 .
2013-10-23 00:09:35 +01:00
Misty De Meo
2ac9afcc77
Bottles: add Leopard/PPC tags
2013-10-21 18:06:46 -07:00
Misty De Meo
28c9330abb
Update Leopard/Tiger bottle tags
...
* PPC bottles are in the os_cpu format, e.g. :tiger_g3
* Intel bottles are the bare cat, as usual
* 64-bit bottles have _64 appended to them, e.g. :tiger_g5_64 or :leopard_64
2013-10-21 13:52:49 -07:00
Jack Nagel
805472946b
Rename MacOS to OS::Mac
2013-10-18 12:56:51 -05:00
Jack Nagel
1fb9f85c5f
Simplify setup for local bottle installation
...
Closes Homebrew/homebrew#22833 .
2013-09-26 10:04:45 -05:00
Mike McQuaid
5d0f868f06
Move bottle.rb logic from test-bot to brew bottle.
2013-09-22 16:16:50 +01:00
Jack Nagel
2eefba005f
Give this condition a more revealing name
2013-09-21 19:27:24 -05:00
Mike McQuaid
a7e1dbae63
Bottles: use options hash for install_bottle?
2013-09-18 12:36:43 +01:00
Mike McQuaid
98eac4226b
Allow forcing bottle installation.
2013-09-01 12:59:01 +01:00
Mike McQuaid
cfdd23b3ef
bottles: use dedicated version class.
2013-08-03 22:27:42 -07:00
Mike McQuaid
4f2725cde3
Move getting formula names from bottles to method.
2013-07-18 09:56:55 -07:00
Mike McQuaid
6c242ad4bb
bottles: only try f.bottle.revision if it exists.
2013-07-04 11:32:50 +01:00
Mike McQuaid
49acf70813
bottles: remove legacy tab handling.
...
References Homebrew/homebrew#20716 .
2013-06-27 10:09:37 +01:00
Adam Vandenberg
ad291d7f06
Remove unused guard
...
Closes Homebrew/homebrew#20716 .
2013-06-26 20:32:13 -07:00
Mike McQuaid
bf1db738d7
bottles: add arguments cleanup TODO.
2013-06-22 11:13:59 +01:00
