Markus Reiter
355df64d93
Use SystemCommand for curl.
2018-07-29 01:23:33 +02:00
commitay
7542c4edb7
utils/github: remove full stop from the "skipping" comment
2018-07-25 15:38:14 +10:00
Mike McQuaid
e2968c7889
Various cleanup and fixes.
...
Rename some variables and use existing regexes and a single variable.
2018-05-21 15:36:26 +01:00
Gautham Goli
26e77dd75c
new-formula: Don't fail CI instead comment on PR about audit violations
2018-04-30 10:59:20 +05:30
Gautham Goli
1e0f9fb835
bump-formula-pr: Replace hub with GH API calls to fork and open Pull request
2018-03-31 19:44:55 +05:30
Mike McQuaid
83cca40fc9
RuboCop 0.53.0 manual fixes.
2018-03-08 14:10:02 +00:00
Mike McQuaid
1f48e17f1b
rubocop: fix brew style warnings.
2018-01-17 10:42:43 +00:00
Thomas Andrew
0e991095f1
Fix issue where keychain github credentials wouldn't work
2017-10-26 18:54:48 +01:00
ilovezfs
1937625d86
github: require formula name to be in issue title
2017-10-24 03:07:33 -07:00
Markus Reiter
9bee9ca575
Use “squiggly” heredocs.
2017-10-18 14:39:09 +02:00
Mike McQuaid
cf5fdeef1d
Rubocop: manual rule fixes.
2017-09-24 21:23:59 +01:00
Dominyk Tiller
0ea4da4ef6
github: limit PR search to Homebrew
...
Not sure whether this is the way you want to handle this problem but
it's really darn irritating so here's a PR that handles it one way.
Fixes: https://github.com/Homebrew/brew/pull/3086#issuecomment-324519156
2017-08-31 03:59:33 +01:00
Markus Reiter
56ef168e70
Move fix from #3070 inside GitHub module.
2017-08-20 16:31:46 +02:00
Ben Muschol
ca05c7f010
Change var name
2017-08-17 14:38:50 -04:00
Ben Muschol
5f8d212ccc
Unify vocabulary in github module, remove unnecessary logic
...
Fix duplication bug
2017-08-14 14:45:24 -04:00
Ben Muschol
68cdb550f7
Spec for issues search
2017-08-14 12:06:12 -04:00
Ben Muschol
603bdd01a8
Implement PR feedback
2017-08-14 11:08:56 -04:00
Ben Muschol
d052f503f9
fix typo
2017-08-13 16:41:18 -04:00
Ben Muschol
91b139aca2
Fix syntax error
2017-08-13 16:15:26 -04:00
Ben Muschol
acf46fce5f
Rename path_to -> url_to since it returns a url
2017-08-13 15:03:52 -04:00
Ben Muschol
e93ec12b32
Remove duplicate url generation logic in Github module
2017-08-13 15:03:44 -04:00
Markus Reiter
ae4bafdb36
Simplify CurlDownloadStrategy.
2017-08-08 18:10:13 +02:00
ilovezfs
986887b413
Revert "Refactor SVN and cURL download strategies."
2017-08-07 14:31:56 -07:00
Markus Reiter
dc5a2c1764
Simplify CurlDownloadStrategy.
2017-08-07 21:31:17 +02:00
Jason Karns
c2899b6559
Tap learns to form its own full_name
...
full_name is formed from `{user}/homebrew-{repo}` and is always
lowercase.
2017-06-19 09:42:59 -04:00
Markus Reiter
5828eefd01
Remove to_s from some Pathnames.
2017-05-08 13:37:28 +02:00
Markus Reiter
133e5ddf6a
Remove unnecessary block.
2017-04-25 12:29:01 +02:00
Markus Reiter
2bda194bd9
Add GitHub::search_code method.
2017-04-25 12:29:01 +02:00
Mike McQuaid
d0bbadde22
github: don't print when searching PRs.
2017-03-23 08:39:28 +00:00
William Woodruff
d07b9ed7f2
Replace Utils::JSON with corelib JSON calls.
2016-11-20 20:06:25 -05:00
Mike McQuaid
3c7446f3ff
Improve GitHub API scopes output.
...
Improve the GitHub API scope and token related messaging by
autopopulating the scopes we need on the new scopes page and, in the
case of a lacking a scope we need, output what scope was required.
Also, DRY up the personal access token code.
2016-10-30 15:38:19 -04:00
Markus Reiter
884b268506
Use Formatter for all URLs.
2016-10-01 20:00:49 +02:00
Markus Reiter
75e8b59aad
Add Formatter module.
2016-10-01 20:00:49 +02:00
Markus Reiter
6d8ee395fa
Refactor Tty.
2016-10-01 20:00:49 +02:00
Markus Reiter
25d5f74f3e
Fix Style/ModuleFunction.
2016-09-23 17:36:27 +02:00
Mike McQuaid
3f9cce0a03
Use new "macOS" naming where appropriate.
...
Not quite a mass replacement as I've used OS X and Mac OS X where
describing specific older versions and added compatibility methods
for things in the DSL.
2016-09-18 19:57:19 +01:00
Mike McQuaid
3982950e61
rubocop --auto-correct all hash-rocket usage.
2016-09-17 16:14:13 +01:00
Mike McQuaid
6cfb841524
utils/github: fix Rubocop warnings.
2016-09-11 19:13:00 +01:00
Xu Cheng
a8566c9848
various: eliminate the usage of any? ( #638 )
...
`any?` is not the opposite of `empty?`. Besides the case that
`[false, nil].any?` will return false, `any?`(O(n)) has much worse
performance than `empty?`(O(1)).
2016-08-05 22:01:32 +08:00
Martin Afanasjew
87540ada6a
utils/github: fix reverted order of credentials
...
We always return the token/password first and, if applicable, the user
name is the second element in the returned array.
Closes #581 .
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
2016-07-27 21:27:25 +02:00
Martin Afanasjew
bdc1991d77
utils/github: fix broken pipe error
...
Closes #573 .
2016-07-27 21:27:25 +02:00
Mike McQuaid
23306ab434
github: produce better curl error messages. ( #441 )
...
* global: add RUBY_TWO global variable.
* test-bot: use RUBY_TWO global variable.
* github: produce better curl error messages.
If we don't know why curl has failed then ensure that the error messages
that it produced are included as part of the user output.
2016-07-12 19:46:29 +01:00
Andrew Janke
f4b3dadb64
gist-logs: close temp file before passing to curl ( #418 )
...
Ensures that the data gets written to disk so curl can see it, avoiding
intermittent JSON parsing errors in gist creation.
2016-07-03 17:21:13 -04:00
Mike McQuaid
8e0e1642ad
Use curl for the GitHub API ( #295 )
...
* Move GitHub API module to utils/github.rb.
* Move curl method to utils/curl.rb.
* global: use long curl arguments and an array.
This makes the code more self-documenting.
* utils/curl: support reading curl's output.
* utils/github: use curl instead of open-uri.
It has far better proxy support.
* pull: set Homebrew user agent.
* gist-logs: remove trailing whitespace.
* gist-logs: use first instead of [0].
Easier to read.
* gist-logs: use curl-based GitHub.open method.
2016-06-03 13:05:18 +01:00
