Markus Reiter
480e264d9a
Lint Ruby docs.
2024-05-01 11:35:21 +02:00
Michael Cho
2d884981c2
cleaner: add types
...
Signed-off-by: Michael Cho <michael@michaelcho.dev>
2024-03-11 11:46:23 -04:00
Michael Cho
74f310577f
cleaner: remove RECORD and modify INSTALLER
...
According to [Python specification][1], we should remove `RECORD` file
to prevent changes to installed formula files via other tools, e.g. pip.
This also improves chances of generating an `all` bottle as it avoids
diff due to checksums of HOMEBREW_PREFIX present files. Also modify
`INSTALLER` file to indicate that brew is managing the Python package.
[1]: https://packaging.python.org/en/latest/specifications/recording-installed-packages/#intentionally-preventing-changes-to-installed-packages
Signed-off-by: Michael Cho <michael@michaelcho.dev>
2024-03-10 10:22:55 -04:00
Michael Cho
4b5bcd39fd
cleaner: remove pip direct_url.json
...
Signed-off-by: Michael Cho <michael@michaelcho.dev>
2024-03-07 20:44:20 -05:00
Akihiro Suda
009318dcaf
cleaner: remove *.tbd
...
For https://github.com/Homebrew/brew/pull/16355#issuecomment-1860642797
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2023-12-19 19:05:28 +09:00
Issy Long
e9d994622e
rubocop: Drop "f" from Naming/MethodParameterName
allowlist
...
- This either stands for "file" but more often than not "formula".
2023-03-11 00:17:27 +00:00
Issy Long
a3211f4d7f
rubocop: Drop "d" from Naming/MethodParameterName
allowlist
2023-03-08 14:42:57 +00:00
Tim Visher
8852208758
feedback
2022-04-28 10:40:16 -04:00
Tim Visher
59649a288c
Use more next
2022-04-28 10:40:16 -04:00
Tim Visher
48db5eff25
lint
2022-04-28 10:40:16 -04:00
Tim Visher
fbb3ccbfd6
Keep info/#{f.name}/dir
files in cleaner
...
Still cleans `info/dir` and `info/<arch>/dir` files.
Fixes https://github.com/Homebrew/homebrew-core/issues/100190
2022-04-28 10:40:16 -04:00
Adrian Ho
0ec4357ea1
cleaner: recursively delete info dir
s
...
Arch-specific build tool formulae (https://github.com/Homebrew/homebrew-core/pull/79874 ) install their info files in `#{info}/<arch>` to avoid conflicts with the main tool formulae.
However, the info cleaner only removes `#{info}/dir`, so each tool's bottle includes `#{info}/<arch>/dir`, which causes install-time conflicts.
This PR fixes that by deleting all `dir`s under `#{info}`.
Before:
```
==> Cleaning
[...]
==> Fixing /usr/local/Cellar/i686-elf-binutils/2.36.1_1/lib/i686-elf/bfd-plugins/libdep.so permissions from 755 to 444
==> Finishing up
```
After:
```
==> Cleaning
[...]
==> Fixing /usr/local/Cellar/i686-elf-binutils/2.36.1_1/lib/i686-elf/bfd-plugins/libdep.so permissions from 755 to 444
rm /usr/local/Cellar/i686-elf-binutils/2.36.1_1/share/info/i686-elf/dir
==> Finishing up
```
2021-06-25 13:30:24 +08:00
Bo Anderson
8004deccd2
cleaner: globally rewrite Perl shebangs by default
2021-05-10 05:50:08 +01:00
Markus Reiter
1b732ec7b2
Fix RuboCop offenses.
2020-11-16 02:05:29 +01:00
Rylan Polster
50890ebd51
fix Lint/DuplicateBranch style
2020-11-16 02:02:52 +01:00
EricFromCanada
3768b7a6e9
apidoc: update comment wording, punctuation, formatting
2020-11-06 00:21:02 -05:00
Markus Reiter
24ae318a3d
Move type annotations into files.
2020-10-10 14:59:39 +02:00
Mike McQuaid
3a91c37e66
Fix RuboCop checks.
2020-08-19 17:12:32 +01:00
Markus Reiter
490e503b1b
Replace Homebrew.args
with Context
.
2020-08-06 16:13:14 +02:00
Markus Reiter
add10377b8
Pass debug?
and verbose?
to Cleaner
.
2020-08-06 16:12:52 +02:00
Mike McQuaid
bc27e38f18
Remove ARGV.debug?
...
Replace with `Homebrew.args.debug?`.
Part of #5730 .
2020-05-23 14:38:58 +01:00
Gautham Goli
acde828a45
ARGV: Replace ARGV.verbose? with Homebrew.args.verbose?
2020-02-02 14:00:04 +01:00
EricFromCanada
9bfd597991
Format debug messages with odebug
2019-12-02 11:33:19 -05:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files.
2019-04-20 13:27:36 +09:00
Marc Seeger
8457fa5af5
Fix 2nd typo in cleaner.rb
2019-04-08 10:33:49 -07:00
Marc Seeger
4f8489faa1
Fix typo in cleaner.rb
...
Seems like auto-correct was a bit too eager to fix things :) ?
2019-04-08 10:24:56 -07:00
Mike McQuaid
d64429a736
rubocop: enable Style/IfUnlessModifier.
2019-02-21 12:55:49 +00:00
Bryce Glover
72a95edcfb
[cleaner.rb] clean_dirs: Remove symbolic links if they point to static libra-
...
ries.
Reopens Homebrew/homebrew-core#35269 .
Closes Homebrew/homebrew-core#35269 .
2019-01-30 19:22:10 -05:00
EricFromCanada
20167e5f1b
Adjust comments to tidy API docs output.
2018-10-18 21:42:43 -04:00
Markus Reiter
a5b11a6a5c
Fix Style/GuardClause.
2016-09-23 15:30:07 +02:00
Dominyk Tiller
202f793d8a
cleaner: kill unnecessary perl elements
...
We shouldn't be packaging either `perllocal.pod` or `.packlist` files. Both
are only really useful outside of package management. They get automatically
generated whenever you install a Perl module.
Debian, Arch, MacPorts & others remove them and we should have been as well
really; keeping them causes completely unnecessary conflicts between formulae.
2016-07-31 03:44:29 +01:00
Mike McQuaid
cdf4f42ab9
cleaner: fix generic executable handling. ( #498 )
...
Don't unset things that are already set as executable for the generic path.
OS X overrides this behaviour and detects if it's an MachO executable but
there's no cross-OS generic equivalent so just fall back to whatever the build
system has set.
2016-07-12 19:47:27 +01:00
Mike McQuaid
fe29cc2920
cleaner: port to generic OS. ( #447 )
2016-07-04 16:10:24 +01:00
Baptiste Fontaine
8ba0fb9fcf
unnecessary calls to .select simplified
...
These are minor perf optimizations.
Closes Homebrew/homebrew#43028 .
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2015-08-18 00:18:22 +02:00
Xu Cheng
d62095710f
More core files style updates
2015-08-03 20:38:20 +08:00
BrewTestBot
13d544e11e
Core files style updates.
...
Closes Homebrew/homebrew#42354 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-08-03 13:22:35 +01:00
Adam Vandenberg
95d16ef1ba
don't clean libexec
2014-09-26 18:22:19 -07:00
Adam Vandenberg
8b5397fa28
improve comment
2014-07-20 12:17:06 -07:00
Adam Vandenberg
929fd44082
use ObserverPathnameExtension to remove these files
2014-07-20 12:17:06 -07:00
Adam Vandenberg
557f887f24
add clarifying comments
2014-07-20 12:17:06 -07:00
Adam Vandenberg
b0138e447d
fix comment
2014-07-19 23:28:39 -07:00
Adam Vandenberg
a78b906389
inline this method
2014-05-12 21:22:13 -07:00
Adam Vandenberg
f5cc07dfea
add more documentation
2014-02-25 20:24:34 -08:00
Adam Vandenberg
0bdce89d65
fix incorrect comment
2014-02-25 20:24:34 -08:00
Adam Vandenberg
3a4a529453
remove charset.alias directly
2014-02-25 20:24:34 -08:00
Adam Vandenberg
9559e162b2
Cleaner: do work in clean instead of constructor
2014-02-23 15:53:25 -08:00
Adam Vandenberg
bb5a2b587e
Always keep info files
...
Closes Homebrew/homebrew#26659 .
2014-02-23 08:30:50 -08:00
Jack Nagel
3cec3e36e9
cleaner: use ObserverPathnameExtension
2013-12-22 13:43:51 -06:00
Jack Nagel
095d83d10b
cleaner: reorganize clean_dir to avoid repeated conditional
2013-12-22 13:43:50 -06:00
Jack Nagel
d19934dcb7
cleaner: clean up broken and orphaned symlinks
2013-12-21 23:28:04 -06:00