96 Commits

Author SHA1 Message Date
Zach Whaley
14f46625a3 caveats: Differentiate zsh completion files and function files
When installing a file to zsh/site-functions directory, it is assumed this is a zsh completion file,
and the zsh completion caveat is printed after installation.

But not all files in the zsh/site-functions directory are completion files.
Some are files for functions that can be loaded on demand with zsh's autoload command.

- Edit Keg.completion_installed to search specifically for files in the zsh/site-functions
  directory starting with an underscore only (By convention, zsh completion files start with an underscore)
- Add Keg.zsh_functions_installed to search for non-completion files in the zsh/site-functions
- Add Caveats.zsh_function_caveats to print a caveat if non-completion files have been installed
  to zsh/site-functions
2016-12-08 07:23:26 -06:00
Zach Whaley
1995f65308 Add a method for installing fish function files
Fish shell allows third-party software vendors to put their own function files in a directory for their software.
For brew installed Fish shell, this is /usr/local/share/fish/vendor_functions.d
2016-12-04 13:21:42 -06:00
Markus Reiter
a5b11a6a5c Fix Style/GuardClause. 2016-09-23 15:30:07 +02:00
Mike McQuaid
6693915399 rubocop --auto-correct all remaining files.
But remove some manual `.freeze`s on constants that shouldn't be
constants.
2016-09-17 16:14:13 +01:00
Dominyk Tiller
2394d6f2d8
caveats: highlight PKG_CONFIG_PATH if exists
We keep getting issues every now & again about people being confused that
keg_only includes hiding the `pkg-config` files. Perhaps seems reasonable to
start pointing out those exist when they do & a hint on how to access them.

Hidden behind a which check to avoid redundant messages, although `pkg-config`
is an incredibly popular formula. Ran some time tests, no appreciable difference
from the status quo.

If accepted:
Closes https://github.com/Homebrew/homebrew-core/issues/4669.
2016-09-11 04:49:09 +01:00
Martin Afanasjew
8600b9edf1 Update Homebrew/homebrew references in comments
Replace `homebrew` with `brew`, `homebrew-core`, or `legacy-homebrew`
depending on context.
2016-05-02 21:19:09 +02:00
ilovezfs
f54f27d621 Skip tmux warning if reattached to user namespace
The exit status of pbpaste is a proxy for whether the user has set up
reattach-to-user-namespace. It should be 0 if it is set up, 1 otherwise.

This is the same hack as Homebrew/homebrew-services#48.
2016-04-30 16:33:16 -05:00
Mike McQuaid
26118d6225 caveats: recommend brew services for plists.
It simplifies the number of commands and it's now an officially
supported command again.
2016-04-22 09:48:34 +01:00
Xu Cheng
7c9dff1f1e plist_caveats: ensure it ending with newline
Closes Homebrew/homebrew#49374.

Signed-off-by: Xu Cheng <xucheng@me.com>
2016-02-21 12:15:31 +08:00
Alex Dunn
9b030d382c caveats: indent Emacs Lisp directory
This matches similar caveats messages.
2015-12-07 18:45:40 -08:00
Alex Dunn
168a2687f8 stricter audit for Emacs Lisp installs
Require that the subdirectory in site-lisp match the formula name
exactly.  This lets us provide better information in the caveats and
will make it easier for helper methods to write to the correct
location (as in in Homebrew/homebrew-emacs#13).
2015-11-01 17:34:28 -08:00
Xu Cheng
5b321ffb5a caveats: show information based on build options
Fixes Homebrew/homebrew#44729.
Fixes Homebrew/homebrew#40863.
Closes Homebrew/homebrew#44779.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-10-10 01:33:58 +08:00
Daniel Lee Harple
666ffe5a63 caveats: wrap elisp caveats
Closes Homebrew/homebrew#43517.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-09-04 16:03:48 +08:00
Alex Dunn
55d685f759 caveats.rb: don't print elisp_caveats for keg-only
Since they won't have been installed into `#{HOMEBREW_PREFIX}/share/emacs/site-lisp/`

Closes Homebrew/homebrew#42839.
2015-08-12 09:38:10 -07:00
Xu Cheng
b121e5fd7b more core file style updated by rubocop 2015-08-06 17:23:56 +08:00
BrewTestBot
13d544e11e Core files style updates.
Closes Homebrew/homebrew#42354.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-08-03 13:22:35 +01:00
Alex Dunn
81eedecc5a Automatic caveats for emacs lisp files
- The name of the subdirectory under site-lisp may not be exactly the
  same as the name of the package

- `(normal-top-level-add-subdirs-to-load-path)` adds every subdirectory
  of `default-directory` to the load-path, so users don't have to update
  their load-path for every package they install.

Closes Homebrew/homebrew#42309.
2015-08-01 14:48:54 -07:00
Xu Cheng
cc91273f8b caveats: fix extra empty line 2015-07-25 15:07:10 +08:00
Dominyk Tiller
81e4f810c1 caveats: use two spaces instead of 4 2015-07-23 15:17:31 +01:00
Misty De Meo
6d5632cd8f Formula: always print keg_only_text
Fixes Homebrew/homebrew#40724.

Closes Homebrew/homebrew#40725.

Signed-off-by: Misty De Meo <mistydemeo@gmail.com>
2015-06-15 08:21:08 -07:00
Johannes Wienke
de43ac7503 Add support for fish shell completions
* Library/Homebrew/caveats.rb: add caveats comparable to other shells
* Library/Homebrew/formula.rb: define completion directory along the
  conventions explained in the fish documentation for
  $fish_complete_path
* Library/Homebrew/keg.rb: add fish shell to check function for
  installed completions

Closes Homebrew/homebrew#39828.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-06-02 10:09:10 +01:00
Xu Cheng
e5f5145773 caveats: use Formula#full_name 2015-05-29 17:01:53 +08:00
Xu Cheng
fff4b83a52 (un)linkapps: allow unlink/link specific formulae.
Closes Homebrew/homebrew#35080.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-12-19 16:35:45 +00:00
Mike McQuaid
40080a4d3e caveats: don't need plist keg to_path, fix 10.8. 2014-11-27 11:00:58 +00:00
Mike McQuaid
b89bacb9c9 caveats: handle non-Homebrew plists.
Mentioned in Homebrew/homebrew#34484.
2014-11-27 10:48:24 +00:00
Xu Cheng
c5f549e33c caveats: if the last character isn't a newline, add one
Closes Homebrew/homebrew#33962.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-11-07 09:07:54 +00:00
Dominyk Tiller
c6bc9b7e9f caveats: yosemite adjustments
Closes Homebrew/homebrew#33815
2014-11-03 19:29:49 +00:00
Tim D. Smith
1593b24b0f caveats: recommend adding python site-packages with site.addsitedir
Closes Homebrew/homebrew#33364. Fixes Homebrew/homebrew#30844.
2014-11-02 10:33:40 -08:00
Mike McQuaid
202a8bd29e caveats: check if plist is a symlink.
Avoid problems like Homebrew/homebrew#32367.
2014-09-19 11:20:16 +01:00
Xu Cheng
329e357d9a plist_caveats: simplify the block and add a comment
Closes Homebrew/homebrew#30630.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-08-31 19:18:11 +01:00
Xu Cheng
ddf22735db plist_caveats: remove launchctl list as it requires sudo for root services 2014-08-31 19:18:11 +01:00
Jack Nagel
a3958c6d8b Use formula opt shortcuts 2014-06-30 20:31:14 -05:00
Samuel John
93d9f610bb python caveats: use > instead of >>
The `homebrew.pth` should be a file with a single line in it.
Also (at least on zsh) if the file does not exist, `>>` will
result in an error. The `>` works in both, bash and zsh and
creates the file with the `echo`ed contet.

Closes Homebrew/homebrew#28201.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-04-06 10:35:59 -05:00
Jack Nagel
ce1f598e98 Avoid realpath where it is not necessary
Symlinks in opt and LinkedKegs point directly at a keg in the cellar, so
only resolving one symlink should suffice, and make it clear what path
we are actually interested in.
2014-04-05 12:17:19 -05:00
Mike McQuaid
d8ef8d4f82 caveats: recommend Python .pth file instead.
This is better than PYTHONPATH as it doesn't mess with incompatible
versions of Python.

Closes Homebrew/homebrew#27138.
2014-03-12 13:29:19 +00:00
Mike McQuaid
8b969e981c caveats: tweak app bundle message. 2014-02-02 10:11:48 +00:00
Mike McQuaid
63fcca2fc4 caveats: tweak python site-packages wording.
References Homebrew/homebrew#25789.
2014-01-21 09:02:06 -08:00
Mike McQuaid
f4cd66a88f caveats: print .app caveats if installed to keg. 2014-01-19 14:19:07 -08:00
Mike McQuaid
744a8944b0 caveats: show python caveats if modules installed. 2014-01-04 13:19:20 +00:00
Mike McQuaid
4ea815f7b0 caveats: tweak reload wording. 2013-06-23 14:31:43 +01:00
Jack Nagel
1d265e5a0a Check respond_to? instead of inline rescue 2013-06-09 15:31:40 -05:00
Mike McQuaid
61c7a99cc8 Print formula plist_manual caveat unless loaded. 2013-02-06 22:27:57 -08:00
Mike McQuaid
89e3efae00 Only print launchctl tmux warning conditionally. 2013-01-29 14:37:03 -08:00
Mike McQuaid
5fd9c56803 Add tmux warning for launchctl caveats.
References Homebrew/homebrew#13951.
2013-01-26 14:06:48 +00:00
Jack Nagel
870f095c69 Restore keg-only caveats
Fixes Homebrew/homebrew#16989.
2013-01-14 14:57:42 -06:00
Mike McQuaid
755a2fbe52 Add caveats class and use in brew info.
Probably a better approach than reverted e721c7.

Fixes Homebrew/homebrew#16604.
2013-01-02 09:28:15 +00:00