Douglas Eichelberger
caf8259ae6
Code review changes
2023-12-27 15:29:33 -08:00
Douglas Eichelberger
3abbf4447e
Some minor regexp match perf improvements
2023-12-27 13:16:36 -08:00
Issy Long
2814d2285a
Make str variable names longer
...
- Three characters is the RuboCop limit for parameter names, but more
descriptive is good.
- Requested in
https://github.com/Homebrew/brew/pull/14922#pullrequestreview-1330848594 ,
but the automerge was too quick for me to get to it.
2023-03-08 15:30:25 +00:00
Issy Long
89fb8c78e8
rubocop: Drop "s" from Naming/MethodParameterName allowlist
...
- Most usages of this were in the `pretty_duration` method, where "s"
is better described as "seconds" since we're calculating a duration.
- I also took the executive decision to do the same to "m" which refers
to "minutes".
2023-03-08 14:42:53 +00:00
Sean Molenaar
f7dda488ac
rubocop: check for closed issues in comments
2023-02-08 09:30:07 +01:00
Markus Reiter
5be4c9b5e0
Upgrade typed sigils.
2020-11-25 17:04:19 +01:00
Markus Reiter
dc11f02e16
Move auditor classes into separate files.
2020-11-18 11:22:27 +01:00
