Douglas Eichelberger
aab04229d1
Code review fixes
2024-02-11 20:27:39 -08:00
Douglas Eichelberger
c83e0170a9
Fix cask_help rbi
2024-02-11 20:27:38 -08:00
Douglas Eichelberger
b010e397d6
Add extend/node.rbi, remove unused methods
2024-02-11 20:27:38 -08:00
Douglas Eichelberger
b2dc842238
wip
2024-02-11 20:27:38 -08:00
Bevan Kay
bbebd3deec
Update shared_filelist_glob.rb
...
Co-authored-by: Kevin <apainintheneck@gmail.com>
2024-02-08 07:03:51 +00:00
Bevan Kay
60914a3f4f
rubocops/cask: fix style
2024-02-05 08:58:03 +01:00
Bevan Kay
2b60576165
rubocops/cask: add a cop for specific numbered shared file list files
2024-02-04 14:13:06 +01:00
Douglas Eichelberger
3a27cac7df
Merge pull request #16510 from dduugg/inverse-include-exclude-cop
...
Vendor remaining Rails cops, remove ActiveSupport
2024-01-30 11:59:10 -08:00
Razvan Azamfirei
9aabe1ba91
rubocop: preserve comments when ordering uninstall methods
2024-01-28 07:08:48 -05:00
Razvan Azamfirei
db72295c20
rubocop: order uninstall methods
2024-01-28 07:08:47 -05:00
Douglas Eichelberger
ae249ec282
Vendor InverseMethods cop
2024-01-26 15:03:59 -08:00
Douglas Eichelberger
0caaa1fa36
Vendor SafeNavigationWithBlank cop
2024-01-26 15:03:59 -08:00
Douglas Eichelberger
665bda0fbd
Vendor Presence cop
2024-01-26 15:03:59 -08:00
Douglas Eichelberger
f99d39faf9
Vendor CompactBlank cop
2024-01-26 15:03:59 -08:00
Douglas Eichelberger
9d081a67cc
Replace Rails/NegateInclude with Inverse/Invertible cops
2024-01-26 12:27:50 -08:00
Douglas Eichelberger
8c832e0905
Remove some fixed FIXMEs
2024-01-26 12:00:13 -08:00
Issy Long
a6b8a795b4
Merge pull request #16365 from issyl0/rubocop-cask-zap-arrays-alphabetical
...
Add a new RuboCop for alphabetizing `zap trash` array elements
2024-01-24 21:34:18 +00:00
Issy Long
693a27d48b
Treat zap and uninstall the same
...
- Since `zap` can have more than just `trash`.
2024-01-21 19:48:30 +00:00
Issy Long
d5f9eef1b5
Empty line after guard clause, gah
2024-01-21 12:47:33 +00:00
Issy Long
458844af44
Move multi-line comments with the code they're 'attached' to
...
Co-authored-by: Bevan J. Kay <email@bevankay.me>
2024-01-21 12:42:22 +00:00
Issy Long
eec7a96fbe
Use Ruby 3.1's intersect\? method
2024-01-20 00:38:34 +00:00
Issy Long
e9bcb64000
Double quotes not single
2024-01-20 00:35:40 +00:00
Bevan J. Kay
779f1bba7d
Move comments in tandem with the lines they belong to
2024-01-20 00:03:34 +00:00
Douglas Eichelberger
8e9d294df2
Add File.atomic_write to extend/
2024-01-19 13:36:16 -08:00
Issy Long
c63723bd7d
Merge pull request #16501 from issyl0/rubocop-new-rules-style-redundant-freeze
...
Fix RuboCop `Style/RedundantFreeze` offenses
2024-01-19 15:05:08 +00:00
Issy Long
f682147598
Fix RuboCop Style/RedundantFreeze offenses
2024-01-18 22:20:01 +00:00
Issy Long
0e27dc2564
Fix RuboCop Style/ArrayIntersect offenses
2024-01-18 14:11:43 +00:00
Issy Long
dae9b0cd53
very wip and bad comment handling
2024-01-18 12:53:23 +00:00
Issy Long
338e30ff9b
There are more arrays that contain non-alphabetizeable commands
2024-01-14 20:55:51 +00:00
Issy Long
6a1cb62b42
Appease RuboCop
2024-01-14 20:55:22 +00:00
Michael Cho
b4657e1eef
rubocops/components_redundancy: stable/head block removal
...
When a `stable do` or `head do` block only contains `url`, `sha256`,
`mirror`, and/or `version`, then the block should be removed.
2024-01-12 19:07:10 -05:00
Patrick Linnane
3fdba532a2
various: fix miscellaneous typos
...
Signed-off-by: Patrick Linnane <patrick@linnane.io>
2024-01-12 10:56:49 -08:00
Issy Long
9070f6d829
Check uninstall too, avoiding arrays containing commands
2024-01-02 23:31:13 +00:00
Michael Cho
2f3f017a6e
rubocops/uses_from_macos: audit when depends_on :linux
2023-12-30 18:30:05 -05:00
Douglas Eichelberger
caf8259ae6
Code review changes
2023-12-27 15:29:33 -08:00
Douglas Eichelberger
3abbf4447e
Some minor regexp match perf improvements
2023-12-27 13:16:36 -08:00
Issy Long
fb124f92ed
Ignore non-zap trash methods
2023-12-22 00:41:56 +00:00
Issy Long
b9f13fc35d
Better detection and replacement of non-alphabetized arrays
...
- Use `sort_by` to sort the array, rather than comparing each element
to the next.
- This doesn't error with complaints about clobbering at all when run on
`homebrew/cask`, hurray. And it also handles interpolations correctly,
rather than ignoring them.
Co-authored-by: Bevan Kay <email@bevankay.me>
2023-12-22 00:26:38 +00:00
Issy Long
f4754baa00
Ignore zap trash stanzas with interpolation
...
- Interpolating the version into a path is a common pattern, but the interpolations
trip up the alphabetization autocorrect quite spectacularly, so let's
ignore them (for now?).
2023-12-22 00:19:03 +00:00
Mike McQuaid
a21b2dc833
rubocops/cask/on_system_conditionals: allow blocks.
...
Without this, there's an infinite loop on `brew style --fix` if you have
a `if Hardware::CPU.arm?` in a `postflight` block where it will change
back and forward between `if` and `on_os` syntax forever.
2023-12-21 10:00:46 +00:00
Issy Long
73b3ace77c
Apparently N is alphabetically before c; downcase the comparison
2023-12-21 01:25:18 +00:00
Mike McQuaid
4d93a50ad6
Merge pull request #16364 from cho-m/pybuild-rubocopy
...
rubocops/lines: consistency with single non-runtime Python
2023-12-20 11:57:17 +00:00
Rylan Polster
841a0623c6
Don't have a comment saying to remove this cop
2023-12-19 20:47:20 -05:00
Issy Long
8cf58e36e6
Add a new RuboCop for alphabetizing zap trash array elements
...
- Part of issue 16323.
- Previously this was being done manually by Cask maintainers.
- While we're here, enforce that the `zap trash` path is not in `[]` if
it only contains a single element.
- This is buggy on actual Casks, hence the draft PR.
2023-12-19 23:42:08 +00:00
Michael Cho
61b512c72c
rubocops/lines: consistency with single non-runtime Python
2023-12-19 15:20:45 -05:00
Rylan Polster
8d8cd23414
Add rubocop to enforce deprecate! over discontinued
2023-12-17 16:49:53 -05:00
Rylan Polster
53c1e6ecdb
Add deprecate! and disable! to cask stanza order
2023-12-16 20:01:47 -05:00
Bo Anderson
5692c8ecbf
Fix style violations under newer RuboCop
2023-12-14 05:47:12 +00:00
Bo Anderson
b42256d286
Deprecate, disable & delete code for Homebrew 4.2.0
2023-12-07 23:42:13 +00:00
Rylan Polster
f98b8f948c
Add rubocop to remove MacOS references
2023-11-22 21:19:01 -05:00
