83 Commits

Author SHA1 Message Date
Douglas Eichelberger
eb7c3e52a0 Require SystemInclude only where needed 2024-01-31 11:42:01 -08:00
Carlo Cabrera
0867534f3e
unpack_strategy/zip: avoid loading formulae unnecessarily
If we already have `unzip` in `PATH`, let's skip trying to load the
`unzip` formula.
2023-05-31 00:06:55 +08:00
Michael Wagner
78c07fd0e1
Fix Missing Download Strategy And Dependency 2023-05-17 16:30:00 -05:00
Douglas Eichelberger
24cf6076e8 brew style --fix 2023-04-24 20:42:39 -07:00
Douglas Eichelberger
f38a672938 brew style --fix 2023-03-21 17:37:48 -07:00
Douglas Eichelberger
82dc57dfea Enable UnpackStrategy types 2023-03-21 17:37:46 -07:00
Markus Reiter
c6a5d79ef9
Remove explicit error for empty BOM retry. 2023-03-21 00:39:26 +01:00
Markus Reiter
1e0e12cc43
Retry if DMG BOM is empty. 2023-03-13 18:32:56 +01:00
Markus Reiter
4f04e9e599
Add signatures for extraction functions. 2023-02-22 22:15:53 +01:00
Mike McQuaid
d292dbdc2b
Revert "Fix permissions before moving extracted files." 2023-02-20 17:20:57 +00:00
Markus Reiter
7c5b6fd10d
Add signatures for extraction methods. 2023-02-19 19:29:21 +01:00
Mike McQuaid
6a25229567
brew style --fix 2023-01-02 19:18:51 +00:00
apainintheneck
65bce0ed3c Move unpack_strategy/zip check to extend/os 2022-11-23 20:39:59 -08:00
Issy Long
b7d997e80d
sorbet: Bump some files from typed: false to typed: true
- This was done with `brew typecheck --update --suggest-typed` which
  (as of the previous commit) uses Spoom, yet another gem. I thought I'd
  see how well it works. There are no Sorbet errors after these changes!
2022-10-11 01:09:03 +01:00
Bo Anderson
02164a35db
Use ORIGINAL_PATHS over envs; reject nil PATH 2022-06-17 19:47:57 +01:00
Bo Anderson
aa4ad964eb
unpack_strategy/zip: allow unzip formula to be used 2022-03-02 13:34:26 +00:00
Alexander Bayandin
e74f996b02
unpack_strategy/tar: fix zst subextraction 2021-10-01 10:45:49 +01:00
Alexander Bayandin
fe9a039774
unpack_strategy: add zstd 2021-09-20 14:12:30 +01:00
Bo Anderson
7ee76b85d5
unpack_strategy/zip: ensure consistent timezone management 2021-04-27 20:29:18 +01:00
Mike McQuaid
b57fe84f81
Use long/readable tar flags.
Also, use `--no-same-permissions` instead of `-o` (which does nothing
without `-p` being passed and run as `root`) for the more explicit
description of the behaviour we want.
2021-04-16 14:05:06 +01:00
Michael Cho
1a398f9aaf cask install: increase APFS test sleep to avoid slow eject fail 2021-04-03 10:21:50 -07:00
Michael Cho
cf8d96e0b2 cask install: fix APFS DMG eject to use physical disk 2021-03-29 19:59:20 -07:00
Bo Anderson
323ff660fa rubocop: use consistent array/hash indentation 2021-02-11 13:27:42 +00:00
EricFromCanada
571179ff0e pass second argument to ohai when applicable 2021-01-26 15:36:43 -05:00
Seeker
fbafaff4fe rubocop: require braces for Sorbet sig 2021-01-18 16:52:45 -08:00
Markus Reiter
794b128969 Work around BOM find bug. 2020-11-26 14:13:01 +01:00
Markus Reiter
db980464f6 Try retrying BOM find command. 2020-11-25 22:36:29 +01:00
Markus Reiter
daea3c090e Add debug output of find command when creating BOM. 2020-11-25 19:37:36 +01:00
Markus Reiter
b9fc7e100b Add more BOM debug information. 2020-11-24 22:12:17 +01:00
Markus Reiter
c324155295 Add debug information for empty BOM error. 2020-11-24 18:26:15 +01:00
Markus Reiter
f3c81760cb Unify Lzma and Xz. 2020-11-17 12:20:08 +01:00
Markus Reiter
da9289eff0 Add more type signatures. 2020-11-13 12:26:36 +01:00
Markus Reiter
ab33bc638d Add type signatures for UnpackStrategy::Zip. 2020-10-20 09:50:21 +02:00
Markus Reiter
61b79318ed Move include Kernel into .rbi files again and split up existing .rbi files. 2020-10-10 19:10:58 +02:00
Markus Reiter
24ae318a3d Move type annotations into files. 2020-10-10 14:59:39 +02:00
miccal
54e4be2f64 unpack_strategy/dmg: remove deprecated IDME attach flag 2020-09-19 21:20:25 +08:00
Markus Reiter
0e7f18a51e Document UnpackStrategy. 2020-08-26 03:13:58 +02:00
L. E. Segovia
e3f8939cff
zip: overwrite existing files
Fixes homebrew/homebrew-cask#69879
2019-10-15 12:33:42 +00:00
Markus Reiter
cc234d1948 Fix Dmg detection. 2019-10-14 10:44:52 +02:00
Markus Reiter
67d51ef0e1 Fix Dmg being detected as Tar. 2019-10-13 17:19:02 +02:00
Markus Reiter
9a1e3fbab4 Fix #system_dir_symlink? not working when target doesn't exist. 2019-10-09 11:15:48 +02:00
L. E. Segovia
8ec48b0c72
Fix symlink validation in Mojave 2019-10-06 23:27:24 +00:00
Christian Moritz
3bb0f8c665 fix copying top level symlinks to folders in directory unpack_strategy 2019-05-17 00:54:34 +02:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Mike McQuaid
d1ea6f38d3
Fix mutable constants violations. 2019-04-19 21:46:20 +09:00
EricFromCanada
fa6404e0f5 grammar fixes 2019-04-13 21:29:32 -04:00
L. E. Segovia
e09d4336a9
Unzip Casks w/ extended attributes with ditto
Fixes Homebrew/homebrew-cask#61386
2019-04-08 22:54:33 +00:00
Mike McQuaid
20e4262fb9
unpack_strategy: prioritise extension instead.
Instead of only looking at the extension when invoked as part of
Homebrew's formulae' download strategies instead prioritise the
extension if it actually exists. When it does not, fall back to the
magic detection logic which is likely to be more reliable.

Fixes https://github.com/Homebrew/brew/issues/5895
2019-04-03 10:32:29 +01:00
JuPlutonic
e0bf31764e Deletion of files added in PR. -o addition is only one needed argument in unpack_strategy/tar.rb.
update gnu_tar.rb

removed tab

update unpacking_strategy/tar.rb

to resolve conversations
But OFFENCE found, W: 31: 36: Unused method argument - basename (brew style)
Now I start to using rubocop inside Sublime_text3 where I see all right linting messages.

Rollback install.rb changes.

Conversation resolved, extra_args: "--owner=0", "--group=0" and "--no-same-owner" in extend/os/linux/gnu_tar.rb.

Conversation: file extend/os/linux/gnu_tar.rb moved to extend/os/linux/unpack_strategy/tar.rb. Module UnpackStrategy is parent for the GnuTar module.

Conversation: new file extent/unpack_strategy/tar.rb to require logic, unpack_strategy/tar.rb newline bef. require-line, require-line changed.

Deletion of files added in PR. -o addition is only one needed argument in unpack_strategy/tar.rb.
2019-03-01 14:22:39 +00:00
Mike McQuaid
d64429a736
rubocop: enable Style/IfUnlessModifier. 2019-02-21 12:55:49 +00:00