mirrors/brew
1
0
Fork 0
mirror of https://github.com/Homebrew/brew.git synced 2025-07-14 16:09:03 +08:00
Code Issues Packages Projects Releases Wiki Activity
38,364 Commits 11 Branches 451 Tags
Commit Graph

30713 Commits

Author SHA1 Message Date
Mike McQuaid
176095a826
utils/bottles: tweak syntax. 2024-01-30 17:15:13 +00:00
Douglas Eichelberger
e00d066d87 Replace Time refinement with Timer Util 2024-01-29 18:50:12 -08:00
Arian Faurtosh
9088cf9be0 Fixes openjdk_dep_name_if_applicable when not using CurlGitHubPackagesDownloadStrategy 
When installing a formula, `FormulaInstaller` calls `#pour`, which in turn calls:

6f20c0300a/Library/Homebrew/formula_installer.rb (L1260)

This `tab` is expected to have `#runtime_dependencies`, and it typically will because most packages come from http://ghcr.io

6f20c0300a/Library/Homebrew/utils/bottles.rb (L111)

Any `DownloadStrategy` that does not match `CurlGitHubPackagesDownloadStrategy` will lead here:
6f20c0300a/Library/Homebrew/software_spec.rb (L463)

Causing this branch to be executed for creating the `tab`:
6f20c0300a/Library/Homebrew/utils/bottles.rb (L119)

This causes a slight issue because `openjdk_dep_name_if_applicable` calls `keg.runtime_dependencies` when it's still `nil`.

6f20c0300a/Library/Homebrew/keg_relocate.rb (L134-L140)

And if it's blank, it won't do the regex replacement on `@@HOMEBREW_JAVA@@`, resulting in the following error when running `Kafka`:

```console
$ tail -f /opt/homebrew/var/log/kafka/kafka_output.log
/opt/homebrew/Cellar/kafka/3.6.0/libexec/bin/kafka-run-class.sh: line 346: /opt/homebrew/@@HOMEBREW_JAVA@@/bin/java: No such file or directory
/opt/homebrew/Cellar/kafka/3.6.0/libexec/bin/kafka-run-class.sh: line 346: exec: /opt/homebrew/@@HOMEBREW_JAVA@@/bin/java: cannot execute: No such file or directory
```

As mentioned by: https://github.com/orgs/Homebrew/discussions/2530#discussioncomment-2002374

> Installing Java-dependent formulae from bottle mirrors doesn't work properly at the moment. The issue is that brew needs the manifest in order to correctly replace @@HOMEBREW_JAVA@@ but brew only knows how to fetch manifests from ghcr.io.
> Pull requests to fix this welcome.

This should fix this issue, by getting the `runtime_dependencies` directly from the formula for those cases that it can't get it from https://ghcr.io or tabfile

```ruby
f_runtime_deps = formula.runtime_dependencies(read_from_tab: false)
tab.runtime_dependencies = Tab.runtime_deps_hash(formula, f_runtime_deps)
```
 2024-01-29 15:57:55 -08:00
Mike McQuaid
2cb8efc51d
Merge pull request #16377 from razvanazamfirei/rubocop-uninstall-methods-order 
rubocop: order uninstall/zap methods
 2024-01-29 16:32:24 +00:00
Mike McQuaid
cfac516ee0
Merge pull request #16538 from dduugg/TopLevelMethodDefinition 
Enable Style/TopLevelMethodDefinition
 2024-01-28 16:06:34 +00:00
Razvan Azamfirei
82cdf27eb8
fixture/cask: fix style violations 2024-01-28 10:19:39 -05:00
Razvan Azamfirei
9aabe1ba91
rubocop: preserve comments when ordering uninstall methods 2024-01-28 07:08:48 -05:00
Razvan Azamfirei
7c540dd3c5
rubocop: add uninstall methods order tests 
Co-authored-by: Bevan Kay <email@bevankay.me>
 2024-01-28 07:08:47 -05:00
Razvan Azamfirei
db72295c20
rubocop: order uninstall methods 2024-01-28 07:08:47 -05:00
Douglas Eichelberger
bec27d44c6 Remove stray ActiveSupport references 2024-01-26 15:38:13 -08:00
Douglas Eichelberger
4b59101549 Resolve type errors 2024-01-26 15:04:00 -08:00
Douglas Eichelberger
8db86f712f brew typecheck --update-all 2024-01-26 15:04:00 -08:00
Douglas Eichelberger
8f52b6f02b Remove .rbi files for removed dependencies 2024-01-26 15:03:59 -08:00
Douglas Eichelberger
2e90749f9f brew vendor-gems: commit updates. 2024-01-26 15:03:59 -08:00
Douglas Eichelberger
ae249ec282 Vendor InverseMethods cop 2024-01-26 15:03:59 -08:00
Douglas Eichelberger
0caaa1fa36 Vendor SafeNavigationWithBlank cop 2024-01-26 15:03:59 -08:00
Douglas Eichelberger
665bda0fbd Vendor Presence cop 2024-01-26 15:03:59 -08:00
Douglas Eichelberger
f99d39faf9 Vendor CompactBlank cop 2024-01-26 15:03:59 -08:00
Douglas Eichelberger
6472aca1a6 Prefer endless methods 2024-01-26 15:03:59 -08:00
Douglas Eichelberger
686264f1b0 Remove inline disables 2024-01-26 15:03:59 -08:00
Douglas Eichelberger
9d081a67cc Replace Rails/NegateInclude with Inverse/Invertible cops 2024-01-26 12:27:50 -08:00
Douglas Eichelberger
b6fef7b893 Add Taps exclusion 2024-01-26 12:25:47 -08:00
Douglas Eichelberger
8c832e0905 Remove some fixed FIXMEs 2024-01-26 12:00:13 -08:00
Douglas Eichelberger
36f64d6b30 Enable Style/TopLevelMethodDefinition 2024-01-26 11:37:11 -08:00
BrewTestBot
82e76a27ba
brew vendor-gems: commit updates. 2024-01-26 16:28:59 +00:00
dependabot[bot]
ea7e37e510
build(deps): bump sorbet-runtime and sorbet-static-and-runtime 
Bumps [sorbet-runtime](https://github.com/sorbet/sorbet) and [sorbet-static-and-runtime](https://github.com/sorbet/sorbet). These dependencies needed to be updated together.

Updates `sorbet-runtime` from 0.5.11218 to 0.5.11219
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

Updates `sorbet-static-and-runtime` from 0.5.11218 to 0.5.11219
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: sorbet-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: sorbet-static-and-runtime
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-01-26 16:25:58 +00:00
Mike McQuaid
3d03ed2710
Merge pull request #16515 from issyl0/bump-point-out-if-formulae-are-synced 
dev-cmd/bump: Point out if formulae should be kept in sync with others
 2024-01-26 14:04:20 +00:00
Mike McQuaid
8c2dcbac3d
Merge pull request #16530 from trail-of-forks/joesweeney/provenance-on-publish 
Add option to retain tmpdir on pr-pull
 2024-01-26 14:02:12 +00:00
BrewTestBot
96d8eda248
Update RBI files for tapioca. 
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
 2024-01-26 03:22:49 +00:00
BrewTestBot
f367d08d1f
brew vendor-gems: commit updates. 2024-01-26 03:16:59 +00:00
dependabot[bot]
912646e75f
build(deps-dev): bump tapioca in /Library/Homebrew 
Bumps [tapioca](https://github.com/Shopify/tapioca) from 0.11.17 to 0.12.0.
- [Release notes](https://github.com/Shopify/tapioca/releases)
- [Commits](https://github.com/Shopify/tapioca/compare/v0.11.17...v0.12.0)

---
updated-dependencies:
- dependency-name: tapioca
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-01-26 03:14:00 +00:00
Issy Long
bf44e74a01
Fix Sorbet - don't need the T.musts anymore 2024-01-25 23:11:37 +00:00
Joseph Sweeney
b261dc7798 Fix style 2024-01-25 11:50:19 -05:00
Joe Sweeney
a61cb1a4d0
Set GitHub workflow output correctly 
Co-authored-by: Bo Anderson <mail@boanderson.me>
 2024-01-25 11:45:20 -05:00
Joseph Sweeney
0b0d9a6066 Add option to retain tmpdir on pr-pull 
This option will be used to generate build provenance in the
`publish-commit-bottles.yml` workflow in `Homebrew/homebrew-core`. It
adds a single flag that controls whether or not the temporary directory
where bottles are downloaded is retained.
 2024-01-25 10:35:59 -05:00
Issy Long
a6b8a795b4
Merge pull request #16365 from issyl0/rubocop-cask-zap-arrays-alphabetical 
Add a new RuboCop for alphabetizing `zap trash` array elements
 2024-01-24 21:34:18 +00:00
Michael Cho
6bc6aae0ca
cmd/upgrade: rename arg to installed_formula/cask 
This avoids running `brew outdated` in shell completions, which is
noticeably slow.
 2024-01-24 12:45:49 -05:00
Patrick Linnane
4528f8b7d8
Merge pull request #16526 from Homebrew/dependabot/bundler/Library/Homebrew/sorbet-runtime-and-sorbet-static-and-runtime-0.5.11218 
build(deps): bump sorbet-runtime and sorbet-static-and-runtime in /Library/Homebrew
 2024-01-24 08:48:39 -08:00
BrewTestBot
1274a9f0ae
Update RBI files for rubocop. 
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
 2024-01-24 16:34:00 +00:00
BrewTestBot
5dda400faf
brew vendor-gems: commit updates. 2024-01-24 16:27:23 +00:00
BrewTestBot
5549b91643
brew vendor-gems: commit updates. 2024-01-24 16:24:36 +00:00
dependabot[bot]
a0d4a94821
build(deps-dev): bump rubocop from 1.60.1 to 1.60.2 in /Library/Homebrew 
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.60.1 to 1.60.2.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop/compare/v1.60.1...v1.60.2)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-01-24 16:23:19 +00:00
dependabot[bot]
965bd19192
build(deps): bump sorbet-runtime and sorbet-static-and-runtime 
Bumps [sorbet-runtime](https://github.com/sorbet/sorbet) and [sorbet-static-and-runtime](https://github.com/sorbet/sorbet). These dependencies needed to be updated together.

Updates `sorbet-runtime` from 0.5.11216 to 0.5.11218
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

Updates `sorbet-static-and-runtime` from 0.5.11216 to 0.5.11218
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: sorbet-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: sorbet-static-and-runtime
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-01-24 16:20:21 +00:00
Issy Long
1b5fa172bb
Split audit_synced_versions_formulae checks into reusable methods 
- This way we can use them in the audit and in `bump`.
 2024-01-24 14:01:01 +00:00
Issy Long
00b47d1fec
Teach brew style about docs/.rubocop.yml 
- Yes, we have yet another `.rubocop.yml` but in-line exclusions in
  `<span class="display:none;">` in the Markdown seemed more ugly.
- This needed tweaks to `brew style` to make it read the new config
  file when we're scanning docs.
 2024-01-24 00:01:45 +00:00
Issy Long
e2251ad4be
brew vendor-gems for rubocop-md 2024-01-24 00:01:38 +00:00
Issy Long
7c25ea6e3a
Configure RuboCop to use rubocop-md 2024-01-24 00:01:37 +00:00
Issy Long
9786955abe
Add rubocop-md gem to the Gemfile in the style group 
- This could be useful for linting code in our docs.
 2024-01-24 00:01:36 +00:00
BrewTestBot
c8f328b36c
brew vendor-gems: commit updates. 2024-01-23 16:51:43 +00:00
dependabot[bot]
00ff71d00e
build(deps): bump sorbet-runtime and sorbet-static-and-runtime 
Bumps [sorbet-runtime](https://github.com/sorbet/sorbet) and [sorbet-static-and-runtime](https://github.com/sorbet/sorbet). These dependencies needed to be updated together.

Updates `sorbet-runtime` from 0.5.11214 to 0.5.11216
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

Updates `sorbet-static-and-runtime` from 0.5.11214 to 0.5.11216
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: sorbet-runtime
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: sorbet-static-and-runtime
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-01-23 16:47:49 +00:00