Markus Reiter
4b432c7ea4
Explicitly mark non-private APIs.
2024-04-22 21:16:49 +02:00
William Woodruff
0f0dee42b4
ensure_executable!: add opt_bin path to search
...
Signed-off-by: William Woodruff <william@yossarian.net>
2024-04-18 11:11:26 -07:00
Mike McQuaid
f086138043
Fix GitHub Actions annotation format.
...
Co-authored-by: Bo Anderson <mail@boanderson.me>
2024-03-14 14:09:11 +00:00
Mike McQuaid
dcaa69a2dc
Add GitHub Actions warning/error annotations for deprecations/disables.
...
This should make these messages, particular warnings, more obvious to
GitHub Actions users.
There's an argument perhaps we should do this more broadly for all
warning/error messages but: this feels like a good start.
2024-03-14 09:49:12 +00:00
Mike McQuaid
ea2892f8ee
brew.rb: handle missing args.
2024-03-07 16:20:20 +00:00
Issy Long
f4218a6316
Fix RuboCop Performance/MapCompact offenses
...
- Rename an iterator variable since it would make the line too long.
2024-02-25 22:59:59 +00:00
Bo Anderson
b42256d286
Deprecate, disable & delete code for Homebrew 4.2.0
2023-12-07 23:42:13 +00:00
Bo Anderson
7187b8b5d6
extend/kernel: fix odisabled kwargs handling
2023-10-28 17:48:31 +01:00
Markus Reiter
16aa6372a3
Make odebug output to stderr.
2023-10-10 03:42:22 +02:00
Eric Knibbe
931f762598
docs+rubydoc: various grammar/wording fixes
2023-09-11 02:26:37 -04:00
Eric Knibbe
31a5df4bf2
extend/kernel: convert TTY-destined input to string
2023-08-02 09:22:15 -04:00
Mike McQuaid
7da934f7e2
Deprecate/disable/delete code.
...
The next release after this is merged will be 4.1.0.
Co-authored-by: Markus Reiter <me@reitermark.us>
2023-07-06 16:56:20 +01:00
Douglas Eichelberger
24cf6076e8
brew style --fix
2023-04-24 20:42:39 -07:00
Dustin Rodrigues
b776fb32de
change includecount to include_count for readability
2023-03-20 07:23:17 -04:00
Dustin Rodrigues
e5fba88035
use includecount argument in pluralize
2023-03-19 23:35:47 -04:00
Douglas Eichelberger
cc5b013cb9
Remove compatibility layer
2023-03-14 14:49:34 -07:00
Douglas Eichelberger
a1748605ab
Minor Kernel cleanup
2023-03-14 10:27:16 -07:00
Douglas Eichelberger
f4c9a96c70
Enable types in dev-cmd
2023-03-14 08:32:03 -07:00
Issy Long
e9d994622e
rubocop: Drop "f" from Naming/MethodParameterName allowlist
...
- This either stands for "file" but more often than not "formula".
2023-03-11 00:17:27 +00:00
Issy Long
89fb8c78e8
rubocop: Drop "s" from Naming/MethodParameterName allowlist
...
- Most usages of this were in the `pretty_duration` method, where "s"
is better described as "seconds" since we're calculating a duration.
- I also took the executive decision to do the same to "m" which refers
to "minutes".
2023-03-08 14:42:53 +00:00
Douglas Eichelberger
7aab1c2a38
Remove ActiveSupport String inflections
2023-03-07 10:16:52 -08:00
Douglas Eichelberger
0d200944c8
Move nostdout to lone calling class
2023-03-03 08:30:15 -08:00
Douglas Eichelberger
d98b7845d3
Enable typing in misc files
2023-03-03 08:29:26 -08:00
Mike McQuaid
7c15dce285
Merge pull request #14798 from MikeMcQuaid/deprecate_shell
...
Deprecate `preferred_shell` and `shell_profile`.
2023-02-28 15:18:00 +00:00
Mike McQuaid
32463227ac
Deprecate preferred_shell and shell_profile.
...
I know that we're outside our normal deprecation cycle but: these are
totally broken with the API and it doesn't make sense to support them
only for non-core formulae.
2023-02-28 15:02:06 +00:00
Issy Long
267d72a9d0
More comments and TODOs
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-02-28 12:50:05 +00:00
Issy Long
316df75da9
utils: Add a comment to module Kernel to appease RuboCop
...
- This `Homebrew/utils.rb` file contains one `@api public` method so it's now
included in `Style/Documentation`.
- This method not having a comment was causing the style specs to fail because
this file isn't usually failing RuboCop.
- And the test description was confusing so I improved it.
2023-02-28 00:18:52 +00:00
Douglas Eichelberger
2b4d4a3707
Isolate Kernel extensions
2023-02-27 11:22:10 -08:00
Douglas Eichelberger
ff48ce24c4
Copy utils.rb into extend/kernel.rb
2023-02-27 11:19:11 -08:00
