Mike McQuaid
f2d064b8ae
Merge pull request #15264 from vitorgalvao/patch-1
...
Cask audit: check binary signature and notarisation
2023-04-21 07:52:11 +01:00
hyuraku
a41a7c94d8
remove cask/cmd
2023-04-19 21:30:42 +09:00
Mike McQuaid
0b4c0350c2
Merge pull request #15201 from hyuraku/remove_cask/cmd/audit
...
remove `cask/cmd/audit`
2023-04-19 10:01:06 +01:00
Vítor Galvão
4437b95397
Cask audit: check binary signature and notarisation
2023-04-18 19:26:14 +01:00
Douglas Eichelberger
6879dcad13
Remove stringio require too
2023-04-17 19:06:30 -07:00
Douglas Eichelberger
e2fed0202a
Remove yaml require for 5% speedup
2023-04-17 15:12:37 -07:00
apainintheneck
1322b9cb79
cask: remove os_versions
...
This was originally used by the API but was replaced months
ago by SimulateSystem. Essentially, it's only current use
was in the #to_h method but is not used internally at all
when creating cask instances from the API JSON.
2023-04-16 13:52:24 -07:00
Markus Reiter
ad3d207172
Merge pull request #15219 from vitorgalvao/patch-1
...
audit.rb: Check for signature with sptcl
2023-04-15 12:40:28 +02:00
Markus Reiter
b2b2689dbf
Merge pull request #15232 from EricFromCanada/cask-artifacts
...
cask/artifact: fix up some definitions
2023-04-15 12:39:24 +02:00
EricFromCanada
b9dab243b5
cask/artifact: fix up some definitions
...
And expand the list of artifacts that target: works with.
2023-04-14 15:47:33 -04:00
Vítor Galvão
654859c25f
audit.rb: Check for signature with sptcl
2023-04-14 18:47:35 +01:00
Markus Reiter
95e3b43647
Fix repo audit for discontinued casks.
2023-04-14 19:02:07 +02:00
Markus Reiter
19939ac276
Fix codesign audit paths.
2023-04-12 19:57:42 +02:00
hyuraku
4999639140
- remove cask/cmd/audit
...
- repair cmd/audit
2023-04-11 23:06:01 +09:00
hyuraku
ec0d492c09
move cask/cmd/reinstall to cask/reinstall
2023-04-10 22:07:06 +09:00
Markus Reiter
c516870094
Merge pull request #15168 from reitermarkus/api-ruby-source-path
...
Add source paths to API.
2023-04-08 09:26:27 +02:00
Mike McQuaid
63d8de3600
brew style --fix
2023-04-07 19:10:22 +01:00
Issy Long
dcc44f164d
Merge pull request #15105 from issyl0/cask-audit-only-failures-default
...
audit: Make `--display-failures-only` the default for Casks
2023-04-07 14:43:51 +01:00
Issy Long
8319c8f9b9
Make audit_casks
return [path, { errors:, warnings:}]
for CI
...
- This was failing but only in CI because the annotations require
"errors" and "warnings" hash elements. Since formulae have this
despite formulae not having warnings (probably for compatibility with
casks), I decided to reinstate `errors` and `warnings` hash for Casks
_right at the end_ and we can clean this up another time (famous last
words).
2023-04-07 14:31:12 +01:00
Markus Reiter
844db75361
Add source paths to API.
2023-04-07 15:20:01 +02:00
Issy Long
a1d4a46f06
Update Library/Homebrew/cask/audit.rb
...
Co-authored-by: Markus Reiter <me@reitermark.us>
2023-04-06 10:13:02 +01:00
Issy Long
93de196a34
Update Library/Homebrew/cask/audit.rb
2023-04-06 09:49:20 +01:00
Mike McQuaid
461fc3ec81
Merge pull request #15160 from razvanazamfirei/greedy
...
Add HOMEBREW_GREEDY option
2023-04-06 08:43:20 +01:00
Issy Long
d636d2de37
Apply suggestions from review comments
...
- Rename `strictish` to `strict_only` in `add_error` method.
- Return just `errors`, a Set, not `{ errors: errors }`, a Hash,
from `Auditor.audit`.
2023-04-06 00:10:28 +01:00
Razvan Azamfirei
28490626fd
style fixes
2023-04-05 09:44:32 -04:00
Razvan Azamfirei
183fad82a6
add greedy option
2023-04-05 09:28:15 -04:00
Issy Long
7cfa544aec
cask/utils: Make more noise when encountering undefined methods
...
- https://github.com/Homebrew/homebrew-cask/actions/runs/4608585102/jobs/8144571098
introduced syntax errors for the `mattermost` cask (`autoupdates`
instead of `auto_updates`), but CI didn't fail so we didn't notice
until it shipped to users and broke `brew update`.
2023-04-04 17:08:54 +01:00
Razvan Azamfirei
dfa7a60038
Feat
2023-03-31 21:23:09 -04:00
Issy Long
e9f233e333
Remove unused output_warnings?
Cask audit method
2023-04-01 02:02:23 +01:00
Issy Long
df8e97fef6
Consolidate add_{warning,error}
methods into one
...
- Specify `strictish: true` in `add_error` to specify that it's not a
super big critical error.
- These will be shown only if `brew audit --strict` is requested.
2023-04-01 01:56:47 +01:00
Issy Long
2b8127d518
Turn cask warnings into errors when --strict
is passed (or implied)
...
- Ignore them and don't show them otherwise.
- Part three of issue 15074:
> As a result, I propose that all current cask audit warnings are never
> displayed as warnings but the underlying audit checks turned into
> errors displayed only with --strict (or one of the other relevant
> flags).
2023-04-01 01:56:46 +01:00
Issy Long
a4e8f9e22b
audit: Make --display-failures-only
the default for Casks
...
- Cask warnings are really noisy and numerous. Let's only show them if
the user passes `--strict` or something implying `--strict`, like
`--new-cask`.
- Additionally remove `display_passes` since we would like silence if
nothing is wrong with the cask, the same as with formula audits.
2023-04-01 01:56:45 +01:00
Markus Reiter
bdd6523ce8
Deprecate appcast
.
2023-03-30 03:29:06 +02:00
Mike McQuaid
cf6614b50e
Merge pull request #15061 from reitermarkus/keyboard-layout
...
Add `keyboard_layout` stanza.
2023-03-27 14:54:46 +01:00
Bevan Kay
68584ac7a7
dsl: pass #{arch} to flight blocks
2023-03-27 11:28:59 +11:00
Markus Reiter
3da305fa80
Add keyboard_layout
stanza.
2023-03-26 08:14:24 +02:00
Markus Reiter
5e52d415a9
Allow fetching for different arch.
2023-03-25 11:56:09 +01:00
apainintheneck
6ccf21c2c9
Merge branch 'master' into add-service-block-to-formula-api
2023-03-22 20:06:32 -07:00
apainintheneck
801ee5e474
Address feedback
...
- style nits
- better comments for tests that are not idempotent
- moved appdir placeholder constant to global.rb
2023-03-22 19:43:49 -07:00
apainintheneck
38146893c3
api_hashable: Make API path subs generic
...
This turns the ability to replace common paths with placeholders
into a mixin that can be used with both Casks and Formulae.
The idea here is to make formula hash generation more consistent.
2023-03-21 23:20:42 -07:00
Mike McQuaid
8bf8393b89
Merge pull request #15021 from MikeMcQuaid/influxdb_cardinality
...
analytics: improve InfluxDB cardinality
2023-03-20 15:54:17 +00:00
Mike McQuaid
4d8445e29d
analytics: improve InfluxDB cardinality
...
- roll InfluxDB token (we need to report to a new bucket to fix implicit schema)
- adjust various parameters
- separate default tags and fields
- send more fields and fewer tags (tags should have low cardinality)
- use `--data-binary` to match InfluxDB documentation
- document second precision for greater InfluxDB performance
- pass through tap name, formula/cask name, options separately
- pass `devcmdrun` as a tag
- avoid sending very high-cardinality `OS_VERSION` values
2023-03-20 15:26:47 +00:00
Mike McQuaid
bd8341d422
Merge pull request #15020 from dtrodrigues/pluralize-includecount
...
Add include_count parameter to pluralize util
2023-03-20 13:53:31 +00:00
Mike McQuaid
1e4abe2cc9
Merge pull request #15018 from dduugg/rm-hash-refinement
...
Use ActiveSupport Hash#assert_valid_keys instead of refinement
2023-03-20 13:48:47 +00:00
Dustin Rodrigues
b776fb32de
change includecount to include_count for readability
2023-03-20 07:23:17 -04:00
Dustin Rodrigues
e5fba88035
use includecount argument in pluralize
2023-03-19 23:35:47 -04:00
Douglas Eichelberger
92b99b3132
Remove misleading upstream.rbi, enable types in on_system
2023-03-19 19:41:46 -07:00
Douglas Eichelberger
4dcd5ac47f
Remove HashValidator
2023-03-19 17:37:58 -07:00
Douglas Eichelberger
516c61057b
Use ActiveSupport Hash#assert_valid_keys instend of refinement
2023-03-19 17:37:58 -07:00
Mike McQuaid
c5fa3d221c
Merge pull request #15009 from apainintheneck/remove-old-prefix-placeholder
...
cask: remove old prefix placeholder
2023-03-19 17:29:00 -04:00