Issy Long
d636d2de37
Apply suggestions from review comments
...
- Rename `strictish` to `strict_only` in `add_error` method.
- Return just `errors`, a Set, not `{ errors: errors }`, a Hash,
from `Auditor.audit`.
2023-04-06 00:10:28 +01:00
Issy Long
e9f233e333
Remove unused output_warnings? Cask audit method
2023-04-01 02:02:23 +01:00
Issy Long
2b8127d518
Turn cask warnings into errors when --strict is passed (or implied)
...
- Ignore them and don't show them otherwise.
- Part three of issue 15074:
> As a result, I propose that all current cask audit warnings are never
> displayed as warnings but the underlying audit checks turned into
> errors displayed only with --strict (or one of the other relevant
> flags).
2023-04-01 01:56:46 +01:00
Issy Long
a4e8f9e22b
audit: Make --display-failures-only the default for Casks
...
- Cask warnings are really noisy and numerous. Let's only show them if
the user passes `--strict` or something implying `--strict`, like
`--new-cask`.
- Additionally remove `display_passes` since we would like silence if
nothing is wrong with the cask, the same as with formula audits.
2023-04-01 01:56:45 +01:00
Markus Reiter
bdd6523ce8
Deprecate appcast.
2023-03-30 03:29:06 +02:00
Bevan Kay
0589ac427d
Update Library/Homebrew/cask/auditor.rb
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-02-28 23:00:43 +11:00
Bevan Kay
d1b09a90da
cask/auditor: only audit 10 languages by default on casks with many languages
2023-02-28 18:54:27 +11:00
Markus Reiter
b821a00bc5
Pass only and except to cask audits.
2023-02-08 08:38:32 +01:00
Sean Molenaar
ff54095b8a
Cask: automatically add cask audits
...
This reverts commit 16618374653dc5461dd971e8ed1992188cc3803d.
2022-09-13 11:19:33 +02:00
Mike McQuaid
1661837465
Revert "Cask: automatically add cask audits"
2022-09-06 11:46:40 +01:00
Sean Molenaar
86f011cefb
Cask: automatically add cask audits
2022-08-29 11:28:20 +02:00
Sean Molenaar
e90371f8ab
cask: add audit for incorrect signing
2022-08-11 09:11:29 +02:00
Rylan Polster
b4a36bef64
audit: fix --display-failures-only failure messaging
2021-03-22 22:20:04 -04:00
Rylan Polster
2b8d19e0bd
audit: limit non-failure cask output
2021-03-22 22:16:54 -04:00
Mike McQuaid
d8a5e467e8
audit: quieten down and make casks audit consistent with formulae.
...
The current casks audit is very noisy in the no-op case (i.e. no errors)
https://github.com/Homebrew/brew/pull/10234/checks?check_run_id=1655630568#step:15:7
This means when there are errors and you're querying all casks it's
pretty hard to quickly identify the problems.
This commit silences the `passing`, `warning` and header/summary output
when you're querying all casks (rather than a specific cask or tap).
This is more consistent with `brew audit` for formulae which is silent
unless there are audit failures.
2021-01-07 13:31:14 +00:00
Markus Reiter
24ae318a3d
Move type annotations into files.
2020-10-10 14:59:39 +02:00
Markus Reiter
5f005f67cf
Refactor global Cask::Config.
2020-10-01 00:57:10 +02:00
Markus Reiter
16c17433d5
Fix passing options through Auditor.
2020-09-04 05:19:33 +02:00
Markus Reiter
e5b56e485f
Move cask audit implications into Audit.
2020-09-04 04:47:31 +02:00
Markus Reiter
55206bdc56
Document Auditor.
2020-08-26 03:13:59 +02:00
Markus Reiter
b48bc316e0
Use CLI::Parser for cask commands.
2020-08-13 05:15:15 +02:00
Markus Reiter
8a32954940
Move cask/all to just cask.
2020-08-09 01:34:07 +02:00
Markus Reiter
5cf7ffd93e
Make Cask::Auditor return a Hash with warnings and errors.
2020-07-28 09:50:15 +02:00
Markus Reiter
8d148b1fbc
Remove special-casing of MacOS::languages.
2020-07-22 01:09:14 +02:00
Markus Reiter
ee09df8db3
Move Download from Auditor into Audit.
2020-07-22 01:09:14 +02:00
Sean Molenaar
3567892802
Add notibility checks for casks
2020-05-26 14:21:25 +02:00
Mike McQuaid
ef95b59ed4
Remove HomebrewArgvExtension
...
Fixes #5730
2020-05-23 19:39:11 +01:00
Julian Mayer
a061a8d9f7
add optional checking whether appcast contains the version stanza to "brew cask audit"
2019-05-07 17:06:54 +02:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files.
2019-04-20 13:27:36 +09:00
Markus Reiter
e472c35880
Remove unneeded cleanup.
2019-01-13 20:29:52 +01:00
Markus Reiter
3435202f91
Fix missing require.
2019-01-13 20:26:46 +01:00
Mike McQuaid
737b84b54b
brew style --fix fixes.
2018-11-02 17:29:23 +00:00
Markus Reiter
16618d0fc7
Use ActiveSupport’s #pluralize and #to_sentence.
2018-10-07 23:10:56 +02:00
Markus Reiter
a84a1c63db
Rename Hbc module to Cask.
2018-09-06 09:30:52 +02:00
Mike McQuaid
90b3a13909
cask: move cask/lib/hbc/* to cask/*.
...
Fix the load path, requires and some filenames accordingly.
2018-09-04 09:56:57 +01:00
