2804 Commits

Author SHA1 Message Date
apainintheneck
d216b3355d cmd/prof: improve error messages
- Provide an error message when the command is unknown.
- Suggest running the command again with `--` if there
  is an invalid option which might have been meant for
  a subcommand.
2023-02-16 18:51:08 -08:00
Issy Long
43a88cbd97
dev-cmd/contributions: Appease RuboCop 2023-02-15 14:04:05 +00:00
Issy Long
44edad85bc
dev-cmd/contributions: Add a grand total row to the CSV
```
$ brew contributions issyl0 --csv
The user issyl0 has made 1203 contributions in all time.
user,repo,commits,coauthorships,signoffs,total
issyl0,brew,333,13,0,346
issyl0,core,473,24,326,823
issyl0,cask,4,0,0,4
issyl0,aliases,0,0,0,0
issyl0,autoupdate,1,0,0,1
issyl0,bundle,14,2,0,16
issyl0,command-not-found,1,0,0,1
issyl0,test-bot,3,0,0,3
issyl0,services,9,0,0,9
issyl0,cask-drivers,0,0,0,0
issyl0,cask-fonts,0,0,0,0
issyl0,cask-versions,0,0,0,0
issyl0,*,*,*,*,1203
```
2023-02-15 14:00:05 +00:00
Issy Long
9aad9d011b
dev-cmd/contributions: Add a per-repo total column to the CSV
```
$ brew contributions issyl0 --csv
The user issyl0 has made 1202 contributions in all time.
user,repo,commits,coauthorships,signoffs,total
issyl0,brew,332,13,0,345
issyl0,core,473,24,326,823
issyl0,cask,4,0,0,4
issyl0,aliases,0,0,0,0
issyl0,autoupdate,1,0,0,1
issyl0,bundle,14,2,0,16
issyl0,command-not-found,1,0,0,1
issyl0,test-bot,3,0,0,3
issyl0,services,9,0,0,9
issyl0,cask-drivers,0,0,0,0
issyl0,cask-fonts,0,0,0,0
issyl0,cask-versions,0,0,0,0
```
2023-02-15 13:58:49 +00:00
Issy Long
2719c345ab
dev-cmd/contributions: CSV output of queried repos; shorter sentence
- This gives users of this command a `--csv` option to pass to... you guessed
  it, generate a CSV that's `pbcopy`able elsewhere, for more granular
  breakdowns of where a person contributed.
- Inspiration was taken from the mockup in
  https://github.com/Homebrew/brew/issues/13642#issuecomment-1254535251
  but without the extra dependency of the TerminalTable gem.
- Always print a condensed "total contributions" sentence.

Output:

```
$ brew contributions issyl0
The user issyl0 has made 1201 contributions in all time.

$ brew contributions issyl0 --csv
user,repo,commits,coauthorships,signoffs
issyl0,brew,331,13,0
issyl0,core,473,24,326
issyl0,cask,4,0,0
issyl0,aliases,0,0,0
issyl0,autoupdate,1,0,0
issyl0,bundle,14,2,0
issyl0,command-not-found,1,0,0
issyl0,test-bot,3,0,0
issyl0,services,9,0,0
issyl0,cask-drivers,0,0,0
issyl0,cask-fonts,0,0,0
issyl0,cask-versions,0,0,0
```
2023-02-15 12:47:10 +00:00
Sanjito Kurniawan
2daae5e84d
edit: add HOMEBREW_NO_INSTALL_FROM_API warning. 2023-02-14 12:04:10 +00:00
Issy Long
990170927a
Merge pull request #14597 from issyl0/contributions-add-signoffs
dev-cmd/contributions: Count commit signoffs, too
2023-02-14 11:37:08 +00:00
Issy Long
abe23fb249
dev-cmd/contributions: Add up different contribution types for a total
❯ brew contributions mikemcquaid
mikemcquaid directly authored 23766 commits, co-authored 241 commits, and signed-off 6730 commits across all Homebrew repos in all time. Total: 30737.
2023-02-14 10:51:13 +00:00
Mike McQuaid
f4f22bc937
Merge pull request #14601 from apainintheneck/stop-double-warning-in-edit
cmd/edit: stop double warning
2023-02-12 12:01:06 +00:00
Markus Reiter
8c8065746b
Fix duration calculation. 2023-02-12 01:40:19 +01:00
Issy Long
14f9a2424d
dev-cmd/contributions: Count commit signoffs, too
- `BrewTestBot` adds `Signed-off-by` for who approved PRs (1cf53b4281/Library/Homebrew/dev-cmd/pr-pull.rb (L91-L93)).
- Let's count these too, at least until we can get PR approvals from the GitHub API.
2023-02-11 12:01:12 +00:00
apainintheneck
a7dbd738dd cmd/edit: stop double warning
When you don't have EDITOR or HOMEBREW_EDITOR
configured `brew edit` printed a double warning.

This silences the first of those.
2023-02-11 00:16:11 -08:00
EricFromCanada
dfc9906184
internal messaging fixes 2023-02-10 23:17:16 -05:00
Mike McQuaid
30b2a546e5
Revert "move dev-cmd/bottle methods to extend/os" 2023-02-10 17:01:22 +00:00
Carlo Cabrera
2a3b4e4cfd
dev-cmd/cat: accept multiple formula/cask arguments
"cat" is short for "concatenate" (and not "dump to stdout"), so it seems
a little silly for `brew cat` to not be able to concatenate
formulae/casks.

Let's fix that.
2023-02-10 22:07:10 +08:00
Markus Reiter
c735c63122
Ignore livecheckable casks in bump-unversioned-casks. 2023-02-09 16:06:53 +01:00
hyuraku
8eb59869dd rename the method which returns git tags 2023-02-09 23:06:52 +09:00
hyuraku
5fd5d391fd apply extend/os to dev-cmd/update-test 2023-02-09 22:06:26 +09:00
Mike McQuaid
cb1872e5bf
Merge pull request #14553 from MikeMcQuaid/4.0.0-changes 2023-02-08 11:05:08 +00:00
Mike McQuaid
342d40e88d
Merge pull request #14510 from reitermarkus/audit-only-except
Pass `only` and `except` to cask audits.
2023-02-08 09:05:00 +01:00
Markus Reiter
b821a00bc5
Pass only and except to cask audits. 2023-02-08 08:38:32 +01:00
Mike McQuaid
6b4363092d
Revert "Merge pull request #14548 from Homebrew/revert-14382-deprecate-disable-remove"
This reverts commit 932d2cf3b77c9439a57b6a43577fc8d3b6399a62, reversing
changes made to f4e60482791d2ff628efadfdbf0d14d9237d2d29.
2023-02-07 19:25:51 +01:00
Mike McQuaid
2a5d41d41b
Revert "Merge pull request #14547 from Homebrew/revert-14412-homebrew_install_from_api_default"
This reverts commit f4e60482791d2ff628efadfdbf0d14d9237d2d29, reversing
changes made to e26784f424061ca16987afcb21e036c66a298492.
2023-02-07 19:25:40 +01:00
Mike McQuaid
932d2cf3b7
Merge pull request #14548 from Homebrew/revert-14382-deprecate-disable-remove
Revert "Add deprecations and disables"
2023-02-07 19:11:26 +01:00
Mike McQuaid
f4e6048279
Merge pull request #14547 from Homebrew/revert-14412-homebrew_install_from_api_default
Revert "HOMEBREW_INSTALL_FROM_API: make the default for everyone."
2023-02-07 19:11:14 +01:00
hyuraku
ddf4d6af79 repair style 2023-02-07 23:53:09 +09:00
hyuraku
853421e968 repair setup_tar_and_args! method 2023-02-07 23:45:09 +09:00
hyuraku
ade7118057 add new method: gnutar_args 2023-02-07 23:22:33 +09:00
hyuraku
ec1a1566bc separate setup_tar_and_args method 2023-02-07 23:22:33 +09:00
hyuraku
fde7ca31b8 add alias generic_formula_ignores formula_ignores 2023-02-07 23:22:33 +09:00
hyuraku
26a615f009 move dev-cmd/bottle methods to extend/os 2023-02-07 23:22:33 +09:00
Mike McQuaid
0575903868
Revert "HOMEBREW_INSTALL_FROM_API: make the default for everyone." 2023-02-07 15:13:23 +01:00
Mike McQuaid
6882ac17e7
Revert "Add deprecations and disables" 2023-02-07 15:13:19 +01:00
Rylan Polster
ce56fc8afd
Remove unecessary message of brew edit 2023-02-06 16:24:34 +01:00
Mike McQuaid
5f6c69bca2
HOMEBREW_INSTALL_FROM_API: make the default for everyone.
- remove all places we check the flag so it's a no-op now
- flip the messaging to refer to `HOMEBREW_NO_INSTALL_FROM_API` where
  relevant
- adjust the documentation
2023-02-05 18:13:08 +01:00
Mike McQuaid
c1b96e7199
Merge pull request #14382 from MikeMcQuaid/deprecate-disable-remove
Add deprecations and disables
2023-02-05 17:56:58 +01:00
Douglas Eichelberger
24e7c2c5bd Remove active_support Time extensions 2023-02-04 13:51:35 -08:00
Mike McQuaid
59c03cb2a6
Add deprecations and disables
Do the usual dance:
- commented `odeprecated` to `odeprecated`
- `odeprecated` to `odisabled`
- `odisabled` removed
2023-02-03 10:48:43 +00:00
Mike McQuaid
41ad2eba15
update-maintainers/manpages: not all PLC are maintainers.
So list all maintainers separately.
2023-02-02 17:09:25 +00:00
Douglas Eichelberger
dead4de3fc Resolve Lint/EmptyBlock todos 2023-01-26 21:18:24 -08:00
Mike McQuaid
97def3c104
install: better error when using API and --HEAD.
- Tell people what to do to resolve this
- Tweak the instruction ordering to be consistent elsewhere
2023-01-26 11:08:56 +00:00
Mike McQuaid
46d727b475
HOMEBREW_INSTALL_FROM_API: various improvements.
- flip the messaging to refer to `HOMEBREW_NO_INSTALL_FROM_API` where relevant
- remove some duplicate checks
- better scope checks to just core tap formulae
2023-01-25 14:29:35 +00:00
Bo Anderson
142734aec9
dev-cmd/vendor-gems: set SDKROOT for older macOS 2023-01-24 13:24:31 +00:00
apainintheneck
a8ee2b7746 Add closed PR check to bump cmds
Currently we only check for closed PRs in
`bump-cask-pr`. This adds that check to `bump`
and `bump-formula-pr`. The idea is that this
check can warn users about already updated
packages or those that can't be updated
easily and should be updated manually instead.
2023-01-20 18:46:07 -08:00
Caleb Xu
e0915a2c34
dev-cmd/bottle: use Utils::Gzip.compress_with_options 2023-01-06 23:04:03 -05:00
Rylan Polster
68bbe03d04
Remove remaining formula_api_path references 2023-01-06 02:46:21 -05:00
Mike McQuaid
37be5bea52
dev-cmd/edit: handle editing with install_from_api.
Before this change, this would fail every time, even when available on
disk (which was not the case for formulae).

With this change, it will attempt to find it from a tap on disk and only
fail if it cannot be found in any.
2023-01-04 13:51:21 +00:00
Mike McQuaid
585d10fdc8
Merge pull request #14313 from apainintheneck/fix-brew-prof
cmd/prof: Fix gem errors
2023-01-02 19:14:03 +00:00
apainintheneck
3a35ea3e28 Set ruby-prof to v1.4.3
This is the last version of this gem that supports
Ruby 2.6.x. We can stop passing the explicit version
when we move to a newer version of Ruby.
2022-12-29 12:48:13 -08:00
Carlo Cabrera
819aa09e63
Merge pull request #14296 from chenrui333/fix-audit-for-bump-formula-pr-cmd 2022-12-29 16:14:44 +08:00