Issy Long
0c2e6e59c5
rubocop: Remove redundant Style/InverseMethods disables
2023-04-07 21:35:38 +01:00
Issy Long
9302090404
Revert "Allow resource blocks to include on_* blocks or conditionals"
...
This reverts commit b4cd90a3cc47bc2f94e4449fa99b37445b878a5f.
This should never have been merged, given its extraction into PR 15062
had a reasonably long discussion and was decided against in
https://github.com/Homebrew/homebrew-core/pull/126705#discussion_r1149545828 ,
but I didn't realise I hadn't backed it out of PR 15060 before it was
approved and I merged it.
2023-03-29 00:40:46 +01:00
Issy Long
b4cd90a3cc
Allow resource blocks to include on_* blocks or conditionals
...
- d2a58a7853https://github.com/Homebrew/homebrew-core/pull/126705#discussion_r1148558613 is more wieldy, but needed RuboCop tweaks.
2023-03-26 18:25:33 +01:00
Douglas Eichelberger
71402a9a41
Disable false positive violation
2023-03-02 11:49:09 -08:00
Douglas Eichelberger
6c93f6fe91
Enable typing in rubocops
2023-02-16 15:51:20 -08:00
Rylan Polster
d316819f0c
Add tests
2022-12-28 16:10:26 -05:00
Rylan Polster
e08d4f9f31
Check for loose MacOS.version method calls
2022-12-28 16:10:26 -05:00
Rylan Polster
a504d2c1aa
Check for loose Hardware::CPU method calls
2022-12-28 16:10:26 -05:00
Rylan Polster
af99dfba00
Refactor on_system rubocops for use in casks
2022-08-14 17:31:07 -04:00
Mike McQuaid
03f7b254e9
rubocops: fix OnOs block checks.
...
This wasn't correctly flagging the use of `on_os` in `test do` as
invalid.
2022-03-29 19:15:03 +01:00
Bo Anderson
3e4cb206bb
rubocops: silence parser warning
2021-09-23 03:45:15 +01:00
Mike McQuaid
a6e4e195c1
rubocops/lines: recommend on_os/OS.os? based on context.
...
Recommend the use of `on_macos` and `on_linux` unless we're in
`def install`, `def post_install` or `test do` in which case recommend
`OS.mac?` and `OS.linux?` instead.
2021-09-08 13:18:07 +01:00
Bo Anderson
6e2f194e09
rubocops/shell_commands: add cop for shell metacharacters in exec
2021-05-10 16:30:00 +01:00
Bo Anderson
450bc4ab33
Fix brew style
2021-03-26 14:11:03 +00:00
Bo Anderson
9063945b3e
Promote shell commands audit to global cop
2021-03-17 20:45:41 +00:00
nandahkrishna
8e5451df2f
style: use parentheses for assignment in conditions
2021-02-12 18:33:37 +05:30
Seeker
4c42d717fd
rubocops: add cops to check bottle format, indentation, and order
...
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
Co-authored-by: Seeker <meaningseeking@protonmail.com>
2021-02-03 20:46:20 -05:00
Seeker
5c3dec6476
rubocops: move some methods from FormulaCop to HelperFunctions
2021-01-15 10:15:11 -08:00
Jonathan Chang
23b8d0ccb8
rubocops/desc: use rubocop v1 API
2021-01-12 19:16:38 +11:00
Jonathan Chang
9046d778e0
rubocops/checksum: use rubocop v1 API
2021-01-12 19:11:42 +11:00
Jonathan Chang
f81e89193e
rubocops: update helpers for rubocop v1 API
2021-01-12 19:11:42 +11:00
Seeker
b8aa67be5b
bottle: add bottle stanza by traversing AST
2020-12-10 13:38:57 -08:00
EricFromCanada
3768b7a6e9
apidoc: update comment wording, punctuation, formatting
2020-11-06 00:21:02 -05:00
Markus Reiter
24ae318a3d
Move type annotations into files.
2020-10-10 14:59:39 +02:00
Jonathan Chang
f6cd7b72f4
Merge pull request #8757 from reitermarkus/desc-the
...
Check for descriptions starting with “the”.
2020-09-20 15:36:27 +10:00
Markus Reiter
78cd6dc0a9
Allow “macOS virtual machines” in descriptions.
2020-09-19 04:30:54 +02:00
Markus Reiter
9a48568226
Check for descriptions starting with “the”.
2020-09-17 20:44:09 +02:00
Mike McQuaid
8b97c27c21
brew style manual fixes
2020-09-01 14:26:45 +01:00
Markus Reiter
f32b2e0515
Switch unless to if.
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-09-01 13:59:24 +02:00
Markus Reiter
6994556d19
Don't allow platform in cask descriptions.
2020-09-01 13:18:59 +02:00
Markus Reiter
3038ff8726
Improve detection of descriptions starting with cask/formula name.
2020-09-01 02:53:25 +02:00
Markus Reiter
d5ba5cb8f8
Document rubocops/shared modules.
2020-08-26 03:13:59 +02:00
Markus Reiter
750e299d49
Don't take name into account when calculating description length.
2020-08-15 00:16:56 +02:00
Markus Reiter
62ae16bfa8
Allow iOS and iPhone at the beginning of descriptions.
2020-08-13 18:18:03 +02:00
Markus Reiter
9ed16681f3
Fix Desc cop for casks.
2020-08-12 01:07:03 +02:00
Waldir Pimenta
fc6813f094
Extract formula desc auditing code to a separate module
...
The extracted module will be used for Cask descs as well.
Co-authored-by: Markus Reiter <me@reitermark.us>
2020-08-08 23:02:39 +01:00
